uploading files

shantu_roy

Hi all,
I was wondering if someone your point out what I could be doing wrong. I am trying to write a page that users can upload file to but for some reason the file never shows up and I get no errors in the webserver logs. Here is the code that I am using:
<form action='<?=$PHP_SELF?>' method='POST' ENCTYPE='multipart/form-data'>
Upload:<input type='file' size='60' name='image'>
<INPUT TYPE='hidden' name='MAX_FILE_SIZE' value='100000'>
<input type='submit' value='upload' name='done'>
</form>
<BR><HR>

<?php
if ($done) {
copy($image, "/download/");
unlink($image);
}
else {
echo "ERROR IN COPYING FILE<BR>";
}
if ($handle = opendir('/usr/www/htdocs/download')) {
echo "Files available for download:<br>\n";
while (false !== ($file = readdir($handle))) {
echo "$file<br>\n";
}
closedir($handle);
}

theeper

Is file_uploads set to on in your php.ini ?

shantu_roy

yes it is:

;;;;;;;;;;;;;;;;
; File Uploads ;
;;;;;;;;;;;;;;;;

; Whether to allow HTTP file uploads.
file_uploads = On

; Temporary directory for HTTP uploaded files (will use system default if not
; specified).
;upload_tmp_dir =

; Maximum allowed size for uploaded files.
upload_max_filesize = 2M

coditoergosum

Handling file uploads @ php.net

When you upload a file via http post, the $FILES array will hold all of the information concerning your uploaded file. There are five keys in the array; name, size, type, tmp_name, and error. You would call these like this: $FILES['image']['name'], $_FILES['image']['size'], and so on.

Here is a piece of a script I wrote recently:

$tmp_file = $_FILES['image']['tmp_name'];
$original_name = $_FILES['image']['name'];
$img_location = "relative/path/to/location/" . $original_name;
move_uploaded_file($tmp_file, $img_location);

move_uploaded_file moves the file from the temp location, to the specified path/filename.ext. You need to be sure to specify the name of the file in the second argument passed to move_uploaded_file (or copy()), or else nothing will happen. You get the name of the file from the $_FILES['image']['name'] var.

If you want to upload and work with multiple files, use this for your input tag: <input type="file" name="image[]">, and then you can call $_FILES['image']['name']['$i']... where $i == 0 is the first file, $i == 1 is the second file and so on.

rIkLuNd

Try this one:

<form action='<?=$PHP_SELF?>' method='POST' ENCTYPE='multipart/form-data'> 
Upload:<input type='file' size='60' name='fupload'> 
<INPUT TYPE='hidden' name='MAX_FILE_SIZE' value='100000'> 
<input type='submit' value='upload' name='done'> 
</form> 
<BR><HR> 

<?php 
$file_dir = "download"; // No trailing slash at the end!

if ($done)
{ 
copy($fupload, "$file_dir/$fupload_name") or die("Upload failed.");
unlink($image);
} 
else
{ 
echo "ERROR IN COPYING FILE<BR>"; 
} 
if ($handle = opendir('/usr/www/htdocs/download'))
{ 
echo "Files available for download:<br>\n"; 
while (false !== ($file = readdir($handle)))
{ 
echo "$file<br>\n"; 
} 
closedir($handle); 
} 

?>

What I did was that I changed a few things, like the upload field name and a little more... Hope it'll work now!

bav

Also make sure that the folder you are trying to upload your file to has the "write" permission.

rIkLuNd

yes, but that's only necessary if you're running on an UNIX server, I think.

shantu_roy

Yes this is a UNIX server and I verified the permissions. After much toil I used coditoergosum's reccomendation and here is the end result and it works. I would like to thank you guys for your input..🙂 Much appreciated..🙂

<form action='<?=$PHP_SELF?>' METHOD='POST' ENCTYPE='multipart/form-data'>
Upload:<input type='file' size='60' name='image'>
<INPUT TYPE='hidden' name='MAX_FILE_SIZE' value='100000'>
<input type='submit' value='upload' name='done'>
</form>
<BR><HR>

<?php
$foo = $FILES['image']['name'];
$gimp = $FILES['image']['tmp_name'];
$src_ip = $_SERVER['REMOTE_ADDR'];
$inside_ip = "xxx.xxx.xxx.xxx"; /insert correct ip/
$outside_ip = "yyy.yyy.yyy.yyy";/insert correct ip/
if ($foo) {
copy ($gimp,"/usr/www/htdocs/download/$foo");

    if ($handle = opendir('/usr/www/htdocs/download')) {
    echo "<H2>Files available for download:</H2><br>\n";
            while (false !== ($file = readdir($handle))) { 
                    if ($file !='.' && $file !='..'){
                    echo "<table width='50%' border='0'>\n";
                    echo "<tr>\n";
                            if ($src_ip = "192.168.1.*") {
                            echo "<td><a href='http://$inside_ip/download/$file'>$file</a>&nbsp&nbsp&nbsp&nbsp\n";
                            echo "<a target='_new'href='http://$inside_ip/upload/delete_file.php?file_delete=$file'>[DELETE]</a></td>\n";
                            } else {
                            echo "<td><a href='http://$outside_ip/download/$file'>$file</a>&nbsp&nbsp&nbsp&nbsp\n";
                            echo "<a target='_new' href='https://$outside_ip/upload/delete_file.php?file_delete=$file'>[DELETE]</a></td>\n";
                            }
                    echo "</td>\n";
                    echo "</tr>\n";
                    echo "</table>\n";
            }
}
closedir($handle);

}
}