STRANGE problem with PHP

Whipshock

Ive been using this code to read text files into <TEXTAREA>'s

$filename = "scores.txt";
$fileContent = file($filename);
$fileContent = implode("", $fileContent);
$fileContent = htmlentities($fileContent);
print "<textarea rows='20' cols='70' name='fileContent' wrap='virtual'>$fileContent</textarea>\n";
print "<input type='hidden' name='filename' value='$filename'>\n";

on unix machines, and an NT4 machine with IIS and PHP 4.2.2

On my new NT4 server with Apache 1.3.27/PHP 4.2.2 Im trying to run a PHP script with this same code and instead of reading my scores file into the box as:

Score1:0
Score2:0
Score3:0

it reads it in as:

Score1:0

Score2:0

Score3:0

WHY are these blank lines in between appearing? This has never happened before

Also, when I use my Save code to write any changes ive made, the lines in between are Doubled

Heres my save code:

   $file = fopen($filename, "w"); 
   $fileContent = stripslashes($fileContent); 
   fwrite($file, $fileContent); 
   fclose($file); 
   echo "Scores have been updated successfully.";

Any help would be appreciated
Thanks

viper21634

for some reason, it looks like your code is adding a <p> or 2 <br>'s, when you parse it are you parsing it as html or plain text?

Whipshock

what do you mean exactly?

ive written the code in notepad saved it as a .php document
and then i browse to the address of the document in IE, enter my information, and then press Submit and it is writing this to a .txt file (with the addition spaces)

if i go and view this text file in notepad once it was made, it "looks fine" but if i open it in word pad it looks like this:

line1 line2 line3 line4

somewhere in there are hidden line break characters or something?

viper21634

That is what I am thinking, would you post the whole code, i mean at lease every thing in the php tags.

Whipshock

thats pretty much the whole code 🙁

Heres the "editscores.php" code to input the information:

<form method="POST" action="savescores.php">
   <p align="center">

   <?php

   $filename = "scores.txt";
   $fileContent = file($filename);
   $fileContent = implode("", $fileContent); 
   $fileContent= htmlentities($fileContent);
   print "<textarea rows='20' cols='70' name='fileContent' wrap='virtual'>$fileContent</textarea>\n";
   print "<input type='hidden' name='filename' value='$filename'>\n";

 ?>

<br>
<input type="submit" value="Save Scores" name="B1">
<input type="reset" value="Reset" name="B2"></p>
</form>

and upon submitting, the variables are posted to "savescores.php" with this code:

<?php
   $file = fopen($filename, "w"); 
   $fileContent = stripslashes($fileContent);
   fwrite($file, $fileContent); 
   fclose($file); 
?>

register_globals is On so the variables are called in the simple form and the exact code works running on another machine (Win2K/IIS5/PHP4.2.2) its driving me crazy ! 😕

Is there any other type of code to write TEXTAREA data to a textfile thats better or "more correct" in some way that may fix this? or could it need something like htmlentities or a function to remove things? im not very advanced with PHP, just wondering..

viper21634

See if this wont work better.

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<form method="POST" action="savescores.php">
<p align="center"><br>
<textarea rows='20' cols='70' name='fileContent' wrap="soft">
<?php

$filename = "scores.txt";
$fp = fopen($filename,"r");
$scores = array();
while(! feof($fp))
	$scores[] = fgets($fp,1024);
foreach($scores as $key => $value)
{
print $value;
}
$scores = "";
 ?>
</textarea>
   <input type='hidden' name='filename' value='$filename'><br>
    <input type="submit" value="Save Scores" name="B1">
    <input type="reset" value="Reset" name="B2"></p>
</form>

</body>
</html>
<?php
   $newoutput = array(); 
   $filename = "scores.txt";
   $fp = fopen($filename,"w") or die("Couldnt open file!");
   $fileContent= htmlentities($fileContent);
   $newoutput[] = $fileContent;
   foreach($newoutput as $key => $value)
   {
   fwrite($fp,$value,1024);
   }
?>

I am using W2k Adv Serverv /w IIS5 and PHP 4, working fine for me are you up to SP2 or 3?? if 3 chunk it, it is a pice of crap, it crashed my AD. It took users like 10 Min to login.

Whipshock

Hm i am using SP5 I think...
I have not tried your code however I will.

I DID manage to find a 1-line solution however that may only work for me, but I'm not sure...

Im not really sure why or I dont really understand it fully but I read that there are hidden line breaks \n and \r and HTML line breaks like <BR> and all kinds of different ones and different browsers, O/S's and PHP itself interpret them differently.

in my "save to file" code:

<?php

   $file = fopen($filename, "w"); 
   $fileContent = stripslashes($fileContent);

[COLOR=red]$fileContent = preg_replace("/(\r\n|\n|\r)/", "\n", $fileContent); // cross-platform newlines[/COLOR] 

   fwrite($file, $fileContent); 
   fclose($file); 

?>

You see I have found a snipet of code (in red) that replaces certain line breaks and returns correctly to work with all platforms and situations.. or so I am told? 🙂
in any case it works!

But i will check out your code and I appreciate your dedication to my thread and for helping me figure this out

THanks!

viper21634

K, SP5, are you using NT4?? if so you need to go to SP6, that could make it work A LOT better.