Need help with Product Rows...

[Manat]

Hi all

I've reached an impasse, dunno if impasse has an e, is it impass?

Anyhow, I have a page that displays products, problem is that each row contains only two products, and I want to have 3 on each <tr.

There is a file called productrow.tpl that my search.php calls.
This is what productrow.tpl contains:

<tr align=center>

{PRODUCT}

</tr>

That's all. If I change the code to this:

<tr align=center>

{PRODUCT}
{PRODUCT}

</tr>

Then each there are duplicates. Instead of 2 items per row, there are 4. But, the two extra items are the same as the previous two. So it's <td>item1</td><td>item2></td><td>item1></td><td>item2</td>

Which obviously is not what I want. So i'm assuming that this means that {PRODUCT} contains a resultset of two queried items, and two only, so I have to put 3 in {PRODUCT} instead of 2. But i'm not able to find out how, here is the search.php code that uses {PRODUCT}.

Any help you can provide as to how I could put 3 items in one row will be extremely appreciated.
here's search.php.

/
The products found are parsed into the following HTML template files.
/
$prodTableTemp = "templates/ptemp.tpl"; //The general HTML for the page. (header and footer).
$prodRowTemp = "templates/productRow.tpl"; //the HTML for a row of poducts
$prodTemp = "templates/product.tpl"; // the HTML for a single product

/
These are the variables passed by the get request
/
$ageId = $HTTP_GET_VARS["cboAge"];
$priceId = $HTTP_GET_VARS["cboPrix"];
$pieceId = $HTTP_GET_VARS["cboPiece"];
$awardWinner = $HTTP_GET_VARS["AW"]; //A True or False value
$newProduct = $HTTP_GET_VARS["New"]; //A True or False value
$pageIndex = isset($HTTP_GET_VARS["iPage"]) ? $HTTP_GET_VARS["iPage"] : 1; //The page of the results to dislay. If not defined, display 1st page.

$txtKey = $HTTP_GET_VARS["txtKey"]; //Not sure what this is for.

/
These variables, passed by the get request, are a bit more complicated and therefore more difficult to create valid search criterion. These variables are, therefore, not used in this current implementation. They are declared for future development.
/
$typeList = $HTTP_GET_VARS["cboType"]; //comma separated list of type ids.
$skillList = $HTTP_GET_VARS["cboSkill"]; //comma separated list of skill ids.

$imgDir = $uppathImg;
$numToDisplay = $NB_ELEM_AFFICHER;
$pagesToDisplay = 10;

//This function returns an array of products which matched the search criterion.(none,one,many)
$products = searchProducts($db,$ageId,$priceId,$pieceId,$awardWinner,$newProduct,$pageIndex,$numToDisplay);

//This function returns the total number of products matching the search criterion.
$numFound = countProducts($db,$ageId,$priceId,$pieceId,$awardWinner,$newProduct);

//This function returns a string of links which are used to navigate through the search results.
$navigation = searchNavigation($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$numFound,$numToDisplay,$pagesToDisplay,$pageIndex);

//Display, using the given templates, the given products, the navigation links and search count.
displayPage($prodTableTemp,$prodRowTemp,$prodTemp,$products,$numFound,$navigation,$pageIndex,$typeList,$imgDir,$txtKey );

/ End of Script /

/*

Functions

*/

//This function displays the products page
function displayPage($prodTableTpl,$prodRowTpl,$prodTpl,&$products,$numFound,$navigation,$pageIndex,$typeId,$imgDir, $txtKey ) {

//Create a Template to parse the HTML template files.
$template = new Template();

//Set the Product Table HTML Template
$template->set_file($prodTableTpl,$prodTableTpl);

//Write Search Count
$template->set_var("NUM_PRODS_FOUND",$numFound);

//Write Search Navigation links
$template->set_var("PROD_SEARCH_PAGES",$navigation);

//Write the products.
writeProducts($template,$prodRowTpl,$prodTpl,$products);

$template->set_var(array (
"IMAGE_DIR"=>$imgDir,
"PAGE_INDEX"=>$pageIndex,
"PROD_TYPE_ID"=>$typeId,
"PROD_KEY"=>$txtKey ) );

$template->pparse("display",$prodTableTpl);//out put the parsed html

}

//This function counts the total number of products matchin the search criteria
function countProducts(&$db,$ageId,$priceId,$pieceId,$awardWinner,$newProduct) {

$countQuery = countQuery($ageId,$priceId,$pieceId,$awardWinner,$newProduct);
$countQuery->doQuery2($db);
$row = $countQuery->getrow();
    return $row["count"];

}

// echo "curPage = $curPage pagesInSet = $pagesInSet numPages = $numPages, numSets = $numSets curSet = $curSet setOffset = $setOffset";
for( $i=1; $i<=$pagesInSet; $i++ ) { //loop throught the ages in the set.
$pages .= navLink($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$curPage,($i+$offset));
}

//Return the navigation links & images.
    return $prevSet . $prev . $pages . $next . $nextSet;		

}

//This function displays the products found in a 2X2 table.
function writeProducts(&$template,$prodRowTpl,$prodTpl,&$products) {

//Count the number of products found.
$count = is_array($products) ? count($products) : 0;
//Set the Product Row and Product HTML templates.

$template->set_file($prodRowTpl,$prodRowTpl);
$template->set_file($prodTpl,$prodTpl);

    if( !$count ) { //If there are no products to display, display "no products message" and return.
            $noProductsHTML = "<tr><td align=center height=100 width=130>No product found for this criteria.</td></tr>";
            $template->set_var("PROD_ROWS",$noProductsHTML);
            return;
    }   //Otherwise, there exists at least one product to display...


//Determine if there are an even number of products
if( $count % 2 == 0 ) {
	$odd = false;
	$c = ($count)/2;
} else {
	$odd = true;
	$c = ($count-1)/2;
}
$i = 0;
for( $i; $i<$c; $i++ ) { //write an even number of products
	writeTwoProducts($products,$i*2,$prodTpl,$template);
	$template->parse("PROD_ROWS",$prodRowTpl,true);
}

if( $odd ) { //write the remaining product if there was an odd number of products.
	writeOneProduct($products,$i*2,$prodTpl,$template);
	$template->parse("PROD_ROWS",$prodRowTpl,true);
}

}

//Write two products in the template
function writeTwoProducts(&$products,$i,$prodTpl,&$template) {
$p = $products[$i];

writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl);
$p = $products[++$i];

writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl,true);
}

//Write only one product
function writeOneProduct(&$products,$i,$prodTpl,&$template) {
$p = $products[$i];
writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl);
}

//Writes the product to the template
function writeProduct(&$prod,&$template) {

//Get the individual data items of the product
list($prodId,$prodName,$prodAge,$prodPieces,$prodPrice,$prodSKU,$prodThmImg,$prodPopUpImg,
$awardProd,$newProd,$ageId,$skillId,$piecesId,$priceId) = $prod;

//Fill the product HTML template with the product data.
$template->set_var( array (
	"PROD_ID"=>$prodId,
	"PROD_NAME"=>$prodName,
	"PROD_AGE"=>$prodAge,
	"PROD_PIECES"=>$prodPieces,
	"PROD_PRICE"=>$prodPrice,
	"PROD_SKU"=>$prodSKU,
	"PROD_IMAGE"=>$prodThmImg,
	"PROD_AWARD"=>$awardProd,
	"PROD_NEW"=>$newProd,
	"PROD_AGE_ID"=>$ageId,
	"PROD_SKILL_ID"=>$skillId,
	"PROD_PIECES_ID"=>$piecesId,
	"PROD_PRICE_ID"=>$priceId ) );

writePopUpImg($prodId,$prodPopUpImg,$template); //write HTML to template for pop up image of template
writeNewText($newProd,$template);//write HTML to template to display "New" text for the product

}

//This function searches the product table for products matching the given criteria.
function searchProducts(&$db,$ageId,$priceId,$pieceId,$awardWinner,$newProduct,$pageIndex,$numToDisplay) {

//Query the database for matching products
$prodQuery = productQuery($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$pageIndex);
$prodQuery->doquery2($db);
$i=0;
$products = array();
    while( $p = $prodQuery->getrow() ) {//Loop through the rows in the product table which matched the criteria.
	$prod = createProduct($db, $p ); //Creates a product from the given data.
	$products[$i++] = $prod; //put product into array.

}

return $products; //return the products found.

}

//Returns the query which searches the product table
function productQuery($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$pageIndex=1,$numToDisplay=4) {

$offset = ($pageIndex-1)*$numToDisplay;
$limit = " LIMIT $offset,$numToDisplay "; 
$whereClause = constructWhereClause($ageId,$priceId,$pieceId,$awardWinner,$newProduct);
$strSQL =
"SELECT DISTINCT 

	prod.Produit_ID AS prodId,
	prod.Is_New AS newProduct,
	prod.Is_Award_Winner AS awardProd,
	prod.Nom AS prodName,
	prod.img_thumb_1 AS prodThmImg,
	prod.img_pop_1 AS prodPopUpImg,
	prod.SKU AS prodSKU,
	prod.Number_Piece_Range_ID AS piecesId,
	prod.Price_Range_id AS priceId,
	prod.List_Group_Age_ID AS ageId

FROM
	Produit prod,
	Groupe_Age age


WHERE

".$whereClause." 
ORDER BY 
	prod.Nom ASC

". $limit;
$q = new Query();
$q->setSQL($strSQL);
return $q;

}

function countQuery($ageId,$priceId,$pieceId,$awardWinner,$newProduct) {

$strSQL = "

SELECT COUNT(DISTINCT Produit_ID) AS count

FROM 
	Produit prod,
	Groupe_Age age

WHERE " .constructWhereClause($ageId,$priceId,$pieceId,$awardWinner,$newProduct);

$q = new Query();
$q->setSQL($strSQL);
return $q;

}

?>

There may be some } missing, but that's ok, I had to shorten the code due to allowable max text lenght for posts. But the code I took out seemed irrelevant.

Thanks

[jeremuck]

you need to change the functions:
writeProducts, writeTwoProducts, and writeOneProduct.

That part of the code is written wierdly, which is why I'm not going to attempt a fix.

Why is i being doubled when it is passed to writeTwoProducts and writeOneProduct?

[Manat]

I have no idea, lol.
Basically, it's code i'm modifying that another programmer wrote.
And I agree, very weirdly, unfortuanately, our mandate doesn't allow us to re-write to code, only modify. :mad:

But why would I need to modify all 3 functions?
writeOneProduct is for when there is only one product to display.
But since I wouldn't need to put 3 items on one level when there is only one product.......... you know????

I tried many things to have 3 items on one row, but I still haven't succeded. But the only function I tried modifying was writetwoproducts().

{Products} is the key, how do I put 3 items in there?

[IWS]

Don't change productrows.tpl. Instead, change the php code as follows:

Create writeThreeProducts:

function writeThreeProducts(&$products,$i,$prodTpl,&$template) {
$p = $products[$i];
writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl);
$p = $products[++$i];
writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl,true);
$p = $products[++$i];
writeProduct($p,$template);
$template->parse("PRODUCT",$prodTpl,true);
}

Then change the line that calls writeTwoProducts:

$c = floor($count/3);
$i = 0;
for( $i; $i<$c; $i++ ) { //write an even number of products
writeThreeProducts($products,$i3,$prodTpl,$templa
te);
$template->parse("PROD_ROWS",$prodRowTpl,true);
}
if ($count%3==2) {
writeTwoProducts($products,$i3,$prodTpl,$templa
te);
$template->parse("PROD_ROWS",$prodRowTpl,true);
}
elseif ($count%3==1) {
writeOneProduct($products,$i*3,$prodTpl,$templa
te);
$template->parse("PROD_ROWS",$prodRowTpl,true);
}

This will work.

[Manat]

Where do I put:

$c = floor($count/3);
$i = 0;
for( $i; $i<$c; $i++ ) { //write an even number of products
writeThreeProducts($products,$i*3,$prodTpl,$templa

te);
$template->parse("PROD_ROWS",$prodRowTpl,true);
}
if ($count%3==2) {
writeTwoProducts($products,$i3,$prodTpl,$templa
te);
$template->parse("PROD_ROWS",$prodRowTpl,true);
}
elseif ($count%3==1) {
writeOneProduct($products,$i3,$prodTpl,$templa
te);
$template->parse("PROD_ROWS",$prodRowTpl,true);
}
?????????

Do I replace this starting and ending from these lines?

if( $count % 2 == 0 ) {
$odd = false;
$c = ($count)/2;
} else {
$odd = true;
$c = ($count-1)/2;
}
$i = 0;
for( $i; $i<$c; $i++ ) { //write an even number of products
writeTwoProducts($products,$i*2,$prodTpl,$template);
$template->parse("PROD_ROWS",$prodRowTpl,true);
}

if( $odd ) { //write the remaining product if there was an odd number of products.
	writeOneProduct($products,$i*2,$prodTpl,$template);
	$template->parse("PROD_ROWS",$prodRowTpl,true);
}

}

??????????????

Thank You
Much appreciated...

[jeremuck]

replace writeProducts with this.
comment the old version out, just so you don't completely lose it.
Based on my examination of the code, I think this will work, but I'm not gauranteeing anything.

This code can probably be reduced even further, as it still retains some redundancy. However, this should work out better.

Really, the number of products to be shown in a row is something that should be abstracted at least another whole layer, so that it can be altered easily in an administration section.
I've set it up so it should show $multiple's value as the number of products in a row, but I have no idea what template API is, so I can't be %100 sure.

// EDIT: This will display products in a table with whatever $multiple's value is as the number of products per row
//This function displays the products found in a 2X2 table. 
function
writeProducts(&$template,$prodRowTpl,$prodTpl,&$products) 
{ 
//Count the number of products found. 

 $count = is_array($products) ? count($products) : 0; 

//Set the Product Row and Product HTML templates. 
  $template->set_file($prodRowTpl,$prodRowTpl); 
 $template->set_file($prodTpl,$prodTpl); 

if( !$count ) 
{ //If there are no products to display, display "no products message" and return. 
$noProductsHTML = "<tr><td align=center height=100 width=130>No product found for this criteria.</td></tr>"; 
$template->set_var("PROD_ROWS",$noProductsHTML); 
 return; 
 } //Otherwise, there exists at least one product to display... 

$multiple = 3;
$remainder = $count % $multiple;
for($pwalker = 0; $pwalker < $count - $remainder; ++$pwalker)
{
  for($walker = 0; $walker < $multiple; ++$walker)
  {
    $thirdparam = false;
    writeProduct($products[$walker]);
    if($walker == $multiple - 1)
    {
      $thirdparam = true;
    }
    $template->parse("PRODUCT", $prodTpl, $thirdparam);
  } 


while($remainder > 0)
{
    $thirdparam = false;
    writeProduct($products[$count - $remainder]);
    if($remainder - 1 == 0)
    {
      $thirdparam = true;
    }
    $template->parse("PRODUCT", $prodTpl, $thirdparam);
   $remainder--;
}  

}

[Manat]

Hi jeremuck.

Well, writeProduct($products[$walker]); cause a PHP parse error and no products showed.

Is there another way?

[jeremuck]

what was the error?
paste the whole thing in
or post the URL so I can see it

[jeremuck]

my bad I know what it is.

every where that I used writeProduct
you need to add a second parameter: $template

so the end of it should look like this:
], $template);

instead of:
]);

[Manat]

Hi Jeremuck Well I tried it, now it didn't give me any errors, but it also didn't return me a recordset, lol.

So now, no products at all show, the page is just emtpy and no fatal or parse errors.

IWS, I also tried your code, at first it didn't work, then after all I did was take the code inside CreatethreeProducts() and overwrite CreateTwoProducts() code. so I never called CreatethreeProducts(), but I used it's code.
And this was without replacing the other code you told me to replace. But the problem is that on the last 2 two images, it didn't display it's images. It ended being broken images for some reason.

Any idea how?

[IWS]

Yes

[Manat]

Hmmm, so what's the idea?

[jeremuck]

Try this instead of what I gave you earlier.
Upon closer inspection, I noticed a few things missing.

// EDIT: This will display products in a table with whatever $multiple's value is as the number of products per row
//This function displays the products found in a 2X2 table. 
function
writeProducts(&$template,$prodRowTpl,$prodTpl,&$products) 
{ 
//Count the number of products found. 

 $count = is_array($products) ? count($products) : 0; 

//Set the Product Row and Product HTML templates. 
  $template->set_file($prodRowTpl,$prodRowTpl); 
 $template->set_file($prodTpl,$prodTpl); 

if( !$count ) 
{ //If there are no products to display, display "no products message" and return. 
$noProductsHTML = "<tr><td align=center height=100 width=130>No product found for this criteria.</td></tr>"; 
$template->set_var("PROD_ROWS",$noProductsHTML); 
 return; 
 } //Otherwise, there exists at least one product to display... 

$multiple = 3;
$remainder = $count % $multiple;
for($pwalker = 0; $pwalker < $count - $remainder; ++$pwalker)
{
  for($walker = 0; $walker < $multiple; ++$walker)
  {
    $thirdparam = false;
    writeProduct($products[$walker], $template);
    if($walker == $multiple - 1)
    {
      $thirdparam = true;
    }
    $template->parse("PRODUCT", $prodTpl, $thirdparam);
  }
  $template->parse("PROD_ROWS",$prodRowTpl,true); 
} 


while($remainder > 0)
{
    $thirdparam = false;
    writeProduct($products[$count - $remainder], $template);
    if($remainder - 1 == 0)
    {
      $thirdparam = true;
    }
    $template->parse("PRODUCT", $prodTpl, $thirdparam);
   $remainder--;
} 
$template->parse("PROD_ROWS",$prodRowTpl,true);  

}

[Manat]

Ok, so now 3 items are being shown in one row.

Now, when you see a product page, you are able to see 6 products per page, if you want to see the next ones you have to click on 2. If you want to see the next 6 products after that you click on page 3.

But now, now that it shows 3 items per row and 6 items per page, the query is saying, click on 2, but when you click on 2, there is nothing to display, no more products for that category.

Looking at my code, would anyone know how to not make 2 show?

Thanks for all the help guys.

[jeremuck]

No. From the very beginning it looks like there is a function called searchNavigation that is documented as being responsible for generating those navigation links.
I searched through the code but could not find it, I believe you omitted it.

If the project you are working on is truely important, I suggest you find a better code base. The one you are using is relatively poorly designed.
Changing whole functions just to change the number of products shown is indicative of poor design, and so is being able to get rid of two functions in order to implement the change.

There is an excellent e-commerce package called OS-Commerce.
Try searching for oscommerce or some variant at www.sourceforge.com or try this: www.oscommerce.com .

Second if you don't know how to program in PHP, how is it you are the one responsible for maintaining the code? If it is truely important, you should hire someone to help you out. Otherwise, it's time to learn by picking up a book and reading.

[Manat]

Well I do know a little PHP, but not that much. And I am currently in the learning process. The reason I am in charge of it is because this section is the only section written in PHP.

I do know PHP, but as a newbie, and i'm going for training in less than 2 weeks as well.

As for Search Navigation, this is the line that calls it.

//This function returns a string of links which are used to navigate through the search results.
$navigation = searchNavigation($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$numFound,$numToDisplay,$pagesToDisplay,$pageIndex);

And below is the function itself and all other function I found to be relevant:

//Returns a string of links to navigate the search results.
function searchNavigation($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$numFound,$numToDisplay,$pagesToDisplay,$curPage){

$numPages = modCount($numFound,$numToDisplay); // determine, from the number of prods and prods/page, the number of pages of search results.
$numSets = modCount($numPages,$pagesToDisplay);//determine, from number of pages and pages/set, the number of sets of pages of search results.
$curSet = (int)($curPage/$pagesToDisplay); // the current set of pages being displayed.

if( $curPage % $pagesToDisplay == 0 ) { //A new set starts at 1, not 0.   
	$curSet = $curSet -1;
}

$nextSet = ""; //Image Link to first page of next set.
$prevSet = ""; //Image Link to first page of previous set.
$next = ""; //Image Link to next page of results.
$prev = ""; //Image Link to previous page of results.
$pages = ""; //String of text links to particular pages of results in the current set.


if( $curSet > 0 ) { //A previous set of pages exist
	$page = ($pagesToDisplay * ($curSet-1)) + 1; //first page of previous set.
	$image = "flecheg2.gif"; 
	$prevSet = navImageLink($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$image,$page);
}

if( $curSet < ($numSets-1) ) { //A next set of pages exist 
	$page = (($curSet + 1 ) * $pagesToDisplay) + 1; //first page of next set.
	$image = "fleched2.gif";
	$nextSet = navImageLink($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$image,$page);
}

if( $curPage > 1 ) { //A previous page exists
	$page = $curPage - 1;
	$image = "flecheg1.gif";
        $prev = navImageLink($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$image,$page);
}
if( $curPage < $numPages ) { //A next page exists
	$page = $curPage + 1;
	$image = "fleched1.gif";
	$next = navImageLink($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$image,$page);
}	

if ($numPages >= ($pagesToDisplay * ($curSet + 1)) ) { //Current set is at least full
	$pagesInSet = $pagesToDisplay; //Display a full set of pages
} else { //Current set is not full
	$pagesInSet =  $numPages - ($curSet * $pagesToDisplay); // display remainder pages
}

$offset = $pagesToDisplay * $curSet;

// echo "curPage = $curPage pagesInSet = $pagesInSet numPages = $numPages, numSets = $numSets curSet = $curSet setOffset = $setOffset";
for( $i=1; $i<=$pagesInSet; $i++ ) { //loop throught the ages in the set.
$pages .= navLink($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$curPage,($i+$offset));
}

//Return the navigation links & images.
    return $prevSet . $prev . $pages . $next . $nextSet;		

}

function navImageLink($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$image,$page) {
$link = "<a href=$php_self?cboAge=$ageId&dir=products&cboPrix=$priceId&cboPiece=$pieceId&AW=$awardWinner&New=$newProduct&iPage=$page class=MyNavBar>";
return $link. "<img src=../../../../admin/img_site/client/$image border=0 ></a>";
}

function navLink($ageId,$priceId,$pieceId,$awardWinner,$newProduct,$curPage,$page) {
$link = "<a href=$php_self?cboAge=$ageId&dir=products&cboPrix=$priceId&cboPiece=$pieceId&AW=$awardWinner&New=$newProduct&iPage=$page class=MyNavBar>";

if( $page == $curPage ) {
$page = "[ $page ]";
}
return $link . " ".$page . "</a> ";
}

//Returns the number of pages, or sets needed to display all the products or pages found.
function modCount($numFound,$numDisplay) {
$rem = ($numFound % $numDisplay) ? 1:0;
return ((int)($numFound / $numDisplay) + $rem );
}

If anyone can help me out on this last request, I would be more than grateful.

Thank You Very Much
MK