problem with code

turbo99

I have a shopping cart using oo design. I have a cart object that holds cart items. Those items have typical properties id, name, price, qty, etc. I also added a new property called category. I created a function to loop through the cart and create an array of categories.

I am taking that array now to determine the shipping and handling. Items with a category of "Stickers" are not charged. The base shipping price is $3.95. Looping through the category array the shipping price is incremented by $1 for every non-sticker category item.

here is my code snippet:

<?php
	if($CART->getMax() == 1){
		$sh = 3.95;
	}elseif($CART->getMax() > 1){
		$sh = 3.95;
		$catItem = $CART->getCategory();

	foreach ($catItem as $temp){
		if($temp == "Stickers"){
			//echo($temp);
			$sh += 0;
		}
		else{
			$sh += 1;
		}
	}
}

$CART->recalc_total($sh);
?>

It loops through the array but adds a $1 to the shipping when it is a "Stickers". Do I have my control structure set up wrong? Any help would be greatly appreciated.

thx
alex

archangel_617b

Originally posted by turbo99, Modified by Archangel 617B
...
<?php
	if($CART->getMax() == 1){
		$sh = 3.95;
	}elseif($CART->getMax() > 1){
		$sh = 3.95;
		$catItem = $CART->getCategory();

	// removed redundant code
	foreach ($catItem as $temp) {
		if($temp != "Stickers")
			$sh += 1;
	}
}

$CART->recalc_total($sh);
?>
It loops through the array but adds a $1 to the shipping when it is a "Stickers"...

It looks correct to me. The change I may is simply stylistic so don't use it if you find your code clearer since what I did will not actually help 😛

Lets take a look at what's going on in there, shall we? Right after you test $temp compared with "Stickers", print it out ( print($temp) ). If you still don't know what the problem is, then right before you go through the loop, view your object using [man]print_r/man like this:

print('<pre>');
print_r($CART);
print('</pre>');

Good luck 😛 If you need more help, please post the output of print_r so I can see what is happening there.

turbo99

im such a fool. I just realized, for example if I have 2 items in the cart and one of those is stickers. It will add $1 to the base price when it should only be just the base price because of the other non-sticker item.

I need it to loop through to create a sum that is added to the base price.

thx for your help. I didnt realize those functions where available to use.

alex