Help me debug

[Archbob]

I can't get what I'm doing wrong:

<?
$db = mysql_connect("localhost", "username", "password")
        or die("Could not connect"); // Connect to evil database or die if failed



mysql_select_db("betterui_dev",$db);

$SQL=mysql_query("select username, password FROM logintable");
while($row=mysql_fetch_array($SQL))
  {
   if($username === $row[0] && $password === $row[1])
        {       

           return true;
            print "Holy one, you have logged in";
        }
  }
return false;
print "You are unholy and the forces of the divine will not let you enter, stay away beast!";

?>

This gives me:
Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/betterui/public_html/users/ychen/authenticate.php on line 10

I checked php for the right argument but I didn't find an error, please help me!

[bav]

what's on line 10?

[Archbob]

while($row=mysql_fetch_array($SQL))

Not sure why this isn't working.

[bav]

try this:

if($result > 0) {
while($row=mysql_fetch_array($SQL))
{
if($username === $row["username"] && $password === $row["password"])
{

return true;
print "Holy one, you have logged in";
}
}
}

[planetsim]

thats good but
if($result > 0) {
should be changed.. ive seen reasons why, but not sure on how to explain them..

As this is a loggin script... im assuming anyway.. if > 0 than it can be 2 3 4 1 etc

but it should be

if($result != 1) {

so if its 0 it wont log in, 2 it wont login.. it must be exactly 1.. never use == 1 that wont work either...

Now i must seem very negative of that last post.. im sorry.. but this is the way it should be done.. also..

when in registering.. never let the same username be used... if you havent thought about that.. its a suggestion

[Archbob]

I'll give it a try.