dont look if ugly code scares you !

[filn]

hey all, can somebody help me make this really ugly code into something pretty and nice 🙂 ?

there are two sections that are exactly the same (only the vars are diffrent). it just makes a simple table and sticks some pics in them.

File Handling

$file = fopen("$index", "w");

fwrite($file, $header);

####### STRAIGHT #########

fwrite($file, $stable);
fwrite($file, $thead);

fwrite($file, "<tr><td valign=top width=25%>$tittymax $imgtittymax</td>");
fwrite($file, "<td valign=top width=25%>$ebonyjoy $imgebonyjoy</td>");
fwrite($file, "<td valign=top width=25%>$ultra $imgultra</td>");
fwrite($file, "<td valign=top width=25%>$facial $imgfacial</td></tr>");

fwrite($file, "<tr><td valign=top width=25%>$latina $imglatina</td>");
fwrite($file, "<td valign=top width=25%>$ampie $imgampie</td>");
fwrite($file, "<td valign=top width=25%>$anal $imganal</td>");
fwrite($file, "<td valign=top width=25%>$gangbang $imggangbang</td></tr>");

fwrite($file, "<tr><td valign=top width=25%>$racial $imgracial</td>");
fwrite($file, "<td valign=top width=25%>$cheer $imgcheer</td>");
fwrite($file, "<td valign=top width=25%>$supersize $imgsupersize</td>");
fwrite($file, "<td valign=top width=25%>$sports $imgsports</td></tr>");

fwrite($file, $tfoot);

fwrite($file, "<table><tr><td>&nbsp;</td></tr></table>");

thanks 4 yer help !

[herve]

Hi,

may be it's not (only) the code which is ugly 🙂

Well, you can put all your var content ( $tittymax , $imgtittymax, etc.)
into two arrays ? one for the images and the other for the
rest.

That way, you just iterate through your arrays :

fwrite($file, $stable);
fwrite($file, $thead);

---8<-------------------

for ($j=0;$j<$max_array;$j=$j+4)
{

fwrite($file, "<tr>";

    for ($i=0;$i<4;$i++)
    {
        fwrite($file, "<tr><td valign=top width=25%>".$array
        [$j+$i].$array2[$j+$i]."</td>"); 
    }

fwrite($file, "</tr>";

}

---8<-------------------

fwrite($file, $tfoot);

fwrite($file, "<table><tr><td> </td></tr></table>");

Hervé.

[filn]

im sorry your gonna have to explain a little bit by what you mean. yeah lost me 🙂

[ednark]

ummm... i was gonna help... but im not sure your content is appropriate...

you should use your powers for the side of good...

[filn]

hey man, its not my fault that sex is about the only thing that is garunteed to sell on the internet. so im using my powers (all beit very limited powers) to help all the lazy webmatsers out there sell porn, bigger, better, faster.. MORE ! so if you cant see the goodness in that, then well, i dont know what to say ! 🙂

but if i offended you, i applogise. theres just not a better place to get help than here !

[ednark]

if you have static categories like you seem to than use the <<<END syntax like in the example below

one file write is more efficient than many writes and if you use the <<<END syntax you can use any ' or " you want without reservation,
complex php variables like accessing class->var[index]->function() should be wrapped in {}, i tend to wrap everything in {}

$table =<<<EndTable
    {$stable}
    {$thead}
    <tr>
        <td valign="top" width="25%">{$tittymax} {$imgtittymax}</td>
        <td valign="top" width="25%">{$ebonyjoy} {$imgebonyjoy}</td>
        <td valign="top" width="25%">{$ultra} {$imgultra}</td>
        <td valign="top" width="25%">{$facial} {$imgfacial}</td>
    </tr><tr>
        <td valign="top" width="25%">{$latina} {$imglatina}</td>
        <td valign="top" width="25%">{$ampie} {$imgampie}</td>
        <td valign="top" width="25%">{$anal} {$imganal}</td>
        <td valign="top" width="25%">{$gangbang} {$imggangbang}</td>
    </tr><tr>
        <td valign="top" width="25%">{$racial} {$imgracial}</td>
        <td valign="top" width="25%">{$cheer} {$imgcheer}</td>
        <td valign="top" width="25%">{$supersize} {$imgsupersize}</td>
        <td valign="top" width="25%">{$sports} {$imgsports}</td>
    </tr>
    {$tfoot}
EndTable;

$file = fopen("$index", "w");
fwrite($file, $header.$table);
fclose($file);

the other thing you might want to look into if you are trying to write a php document... but save it also int a file is the output buffer function suite found here [man]outcontrol[/man]

here you can do something like this: call a normal file, don't output it to the screen... save it into a string, and write it to a file... so this can really should be called from the command line

<?php
    ob_start()
?>

<table>
 <tr><td>hello world</td></tr>
</table>

<?php
    $content = ob_get_content();
    ob_end_clean();

$file = fopen("$index", "w");
fwrite($file, $content);
fclose($file);
?>