Receiving error

Radon3k

I'm trying to make a very simple registration system. All of the code works with the exception of inserting it into the database, here is the code that I'm using, but when I click "submit" on my form, it outputs "Error." which I told it to if there was an error. Any assistance on this would be great and I appreciate it! 🙂

if ($submit == "Submit") {
	$sql = "INSERT INTO user (Name,Password) VALUES($Name,md5($Password))";
	if (@mysql_query($sql)) {
		echo( "Registered." );
	} else {
		echo( "Error." );
	}
}

wilsonodk

You are trying to call a PHP function within a string and then submitting it to MySQL.

Try this...

if ($submit == "Submit") {
    $Password = md5($Password);
	$sql = "INSERT INTO user (Name,Password) VALUES('$Name','$Password'))";
	if (@mysql_query($sql)) {
		echo( "Registered." );
	} else {
		echo( "Error." );
	}
}

Radon3k

I'm confused, why are you declaring the $Password variable and not the $Name variable as well? Both of these variables were declared in the HTML form, I just didn't put that bit in there.

Radon3k

Actually, the only part that was messing up for me was that I didn't have the apostrophe's around the "$Name" and "$Password" in the VALUES part. Thanks for the help, that did the trick! 🙂

wilsonodk

what's the finished code look like?
i didn't think you could call md5() from within a string.

Radon3k

Here ya go, and works fine for me. 🙂

if ($submit == "Submit") {
	$sql = "INSERT INTO user (Name,Password) VALUES('$uname','md5($passwd)')";
	if (@mysql_query($sql)) {
		echo( "Registered." );
	} else {
		echo( "Error." );
	}
}

All I was forgetting was the '. Again, thanks for the help! 🙂