looping over a table

[fsonaglioni]

It seems not to work . it returns 0 .
Im new in php.help please.

<?php

// $combo=generoCombo("cboProvincia","TPAR_PROVINCIAS","PPRV_COD","PPRV_DESCRED");
// printf($combo);

$nombre="cboProvincia";
$tabla="TPAR_PROVINCIAS";
$columna_valor="PPRV_COD";
$columna_descrip="PPRV_DESCRED";

$comboHtml="";
// me conecto a la BD
$db = db_connect();
mysql_select_db("cacd",$db);
$result = mysql_query("SELECT * FROM ".$tabla,$db);
$number = MYSQL_NUMROWS($result);

$comboHtml="<SELECT name='" . $nombre . "'>";

while($rs = mysql_fetch_row($result)) {
$comboHtml= $comboHtml . "<option value='" . $rs[$columna_valor]+"'>" . $rs[$columna_descrip];
}

$comboHtml=$comboHtml . "</SELECT>";

printf($comboHtml);

?>

[hand]

<?php 
$nombre = "cboProvincia"; 
$tabla  = "TPAR_PROVINCIAS"; 
$columna_valor   = "PPRV_COD"; 
$columna_descrip = "PPRV_DESCRED"; 

mysql_select_db("cacd")
	or print "&gt;&gt;&gt; MySQL-Error: ".mysql_errno()." -&gt; ".mysql_error()."<br>\n";

$result = mysql_query("SELECT * FROM $tabla")
	or print "&gt;&gt;&gt; MySQL-Error: ". mysql_errno()." -&gt; ".mysql_error()."<br>\n"; 

$number = mysql_num_rows($result);

$comboHtml = "<SELECT name='$nombre'>\n";

print "$number rows found!<br>\n";

while($rs = mysql_fetch_array($result)) { 
	$comboHtml .= "<option value='$rs[$columna_valor]'>$rs[$columna_descrip]</option>\n"; 
} 
$comboHtml .= "</SELECT>\n"; 

printf($comboHtml); 
?>

[fsonaglioni]

thanks , i've just fixed it!. here's the complete code

function generarCombo($nombre,$tabla,$columna_valor,$columna_descrip){

$comboHtml="";

// connect to db
$db = db_connect();
mysql_select_db("cacd",$db);
$result = mysql_query("SELECT * FROM ".$tabla,$db);
$number = MYSQL_NUMROWS($result);

$comboHtml="<SELECT name='" . $nombre . "'>\n";

while($rs = mysql_fetch_array($result)) {
//while($rs = mysql_fetch_row($result)) {
$comboHtml= $comboHtml . "<option value='" . $rs[$columna_valor] . "'>" . $rs[$columna_descrip]. "\n";
}

$comboHtml=$comboHtml . "</SELECT>";

return $comboHtml;

}