previous next revisited, link limits

archivia

I have a script that is 95% functional but Im getting hung up on 2 issues.
on some result sets where I have 900 or more items in the database the list of 123 links at the bottom of the page is far too much for nice display, what I need is perhaps
[prev] 1 2 3 4... [next] in short I need to limit the number of links displayed at any given time, ala google or even like here in the forum. I have checked the articles but those scripts are a bit outdated and buggy, not to mention that this peticular problem is not addressed. currently I have previous and next buttons and a page number display, but if over 10 pages show, it looks like crap.
Also on the first page, the first and last page links are disabled, on later pages the current page link is disabled (like it should be), why is that last page link getting disabled on the first page of results?
to see the script in action go to www.archivia.com/browse.html

Here is the code (it has been hacked together from many scripts and suggestions):

<html> <head><title>Search Results</title></head>
<?

/ connection information /
$hostname = "site.com";
$username = "myuserid";
$password = "********";$dbName = "mydb";

/ make connection to database /
MYSQL_CONNECT($hostname, $username, $password) OR DIE( "Unable to connectto database");
@mysql_select_db("$dbName") or die( "Unable to select database");

/ define user input vars and vars for no data entered /

if ($title == "") {$title = '%';}

if ($author == "") {$author = '%';}
if ($keywords == "") {$keywords = '%';}

/ sql statement /
$sql = "SELECT * FROM $table WHERE title LIKE '%$title%' AND author LIKE '$author%' AND keywords LIKE '%$keywords%' ORDER BY author, title";
$vara = $author;
$vart = $title;
$kw = $keywords;
$tab = $table;

$limit = 20; // rows to return
$numresults=mysql_query($sql);
$numrows=mysql_num_rows($numresults);

// next determine if page has been passed to script, if not use 1
if (empty($page)) {
$page = 1;
}

$page = $limit * ($page-1);

// get results
$result = mysql_query("$sql limit $page,$limit");

// now you can display the results returned
WHILE ($data=MYSQL_FETCH_ARRAY($result))
$number = mysql_num_rows($result);
if (!$number) print(" \n");
/ Print the relevant information /
$i = 0;

PRINT "
$numrows books found, displaying 20 records at a time. ";
PRINT "To order call 212-439-9194, fax 212-744-1626 or email info@archivia.com";

PRINT "<table width=100% cellpadding=5 cellspacing=5>";

PRINT "<TR bgcolor=black> <td>description</td></tr>";
WHILE ($i < $number):

$author = mysql_result($result, $i,"author");

$title = mysql_result($result,$i,"title");

$bookid = mysql_result($result,$i,"bookid");

$price = mysql_result($result,$i,"price");

$description = mysql_result($result,$i,"description");

$image = mysql_result($result,$i,"image"); {

PRINT "<table valign=top width=100% cellspacing=5 cellpadding=5><tr>
<td width=15%> $image</td>
<td width=85%> $author $title $description(#$bookid) \$$price</td>
</tr>
 <hr> 
</table>";

}
$i++;ENDWHILE;
PRINT "</table>";

echo " <hr> ";
echo "<center>";

$numofpages = $numrows/$limit;

if($page >= 1) {
$pageprev= $page/$limit;
echo "<A HREF=\"$PHP_SELF?page=$pageprev&table=$tab&author=$vara&title=$vart&keywords=$kw&sort=author%2C+title\"><img src='previous.gif' border='0'> </A>";
/ if page is not equal to one, prev goes to $page - 1 /
}

for($i= 1; $i <= $numofpages; $i++) {
$newoffset = $limit($i-1);
if ($newoffset == $page) {
print "  $i \n";
}
else
{
PRINT "<img src='spacer.jpg' border='0'><A HREF=\"$PHP_SELF?page=$i&table=$tab&author=$vara&title=$vart&keywords=$kw&sort=author%2C+title\"> $i </A><img src='spacer.jpg' border='0'>";
/ make number navigation /
}
}
if($page <1) {
print "  $i \n";
}
elseif($numrows%$limit != 0) {
PRINT "<A HREF=\"$PHP_SELF?page=$i&table=$tab&author=$vara&title=$vart&keywords=$kw&sort=author%2C+title\"> $i </A>";
/ if there is a remainder, add another page */
}

if($numrows-$page > 10){
$pagenext = ($page/$limit)+2;
echo "<A HREF=\"$PHP_SELF?page=$pagenext&table=$tab&author=$vara&title=$vart&keywords=$kw&sort=author%2C+title\"> <img src='next.gif' border='0'> </A>";
/ if the totalrows - $limit $page is > 0 (meaning there is a remainder), leave the next button. */
}

echo "</center>";
?>
</html>

leatherback

HI,

I think the solution might be so easy that you will slap your forehead. (Yes, this is a warning: Get the first-aid kit out!)

Change:
WHILE ($data=MYSQL_FETCH_ARRAY($result))

to:

$x = 0; //Set the counter to 0
WHILE ($data=MYSQL_FETCH_ARRAY($result) and $x <=3) // disply 3+1 = 4 page numbers

Then in your script, somewhere (of course where creating the page-number listing)

$x++ (This will increment the value of $x with 1)

Rememeber the first line I wrote: I THINK the solution is this easy: Please let me / us know if it works please!

Buddha443556

To solve the disabled last page bug try this:

echo "<BR><hr><br><br>"; 
echo "<center>"; 

$numofpages = $numrows/$limit;

//missing this:
if ($numrows % $limit) {
    $numofpages++; // add one page if remainder
}

Did it work?

archivia

Thanks to those who replied to my post

Leather,

It sounds like it could in fact be that easy, Though I cant seem to find the correct place to add the incriment $x++ (i've tried several places in the script with various effects, but none affected the list of page numbers... well one place gave me an infinite loop of 1's at the bottom LOL)

buddha,

I do have a "display remainder" call lower on the script, the problem is not that the last remainder records dont show as a page, its that the last page shows as a number, not a linked number when you are on page 1.
I have a routine that makes the current page number display as plain text and not a link, however on page 1 of... say 44 pages... page 1 and page 44 are plain text with no link, on page 2 and all other pages only the current page is unlinked (this is right).

so its only broken on page 1, it must be some sort of arithmatic error.

Aint programming fun? who sed that 😛

leatherback

hi,

reading your code again, I think there might be a little glitch in thinking.

This because you do not loop through the actual search results for each page link, but you create a link based on the total number of results, divided by a number of books per page.

How about: you could just create ndividual links for each output page.
For the number of results < 5 (If you only want 5 links) you use the current routine to create page numbers. All other pages you can set the link manually:

$x = 0;
$i = $page; //or set this to ($page - 2) to get it in the middle of the range

for $x =< 4
{
$i2 = $i + $x;
PRINT "<A HREF=\"$PHP_SELF?page=$i2And whatever else on sel.vars\"></a>
$x++;
}

Where you use 5 as offset for your next / prev links.

Understand the idea? It is basically the same as you have in your script, but you use $numofpages to limit the display.

Now this I suppose, should work. Except maybe for some typos. Sorry for my sloppy reading in the last post. Normally I'd owe you a beer, but I suppose it is kind-a hard to offer you one now!

Buddha443556

I was working with a navigation function yesterday when I saw your post. And I think you pointed out your error rather well, too. :rolleyes: Anyway, I decided to dupe the vBulliten's page nav function for the hell of it. Here what I came up with:

// this function just creates hyperlinks
function create_link($href, $text, $class = "", $target = "", $status = "" ){
	$link = '<a';
	if($class){
		$link .= ' class="'.$class.'"';
	}
	$link .= ' href="'.$href.'"';
	if($target){
		$link .= ' target="'.$target.'"';
	}
	if($status){
		$link .= ' onmouseover="status=\''
			.$status
			.'\';return true" onmouseout="status=\' \'"';
	}
	$link .= '>'.$text.'</a>';
	return $link;
}

function page_chain($link, $class, $prev, $next, $curpage, $numpage){	
	$chain = '';
	$window_width = 5; // might be better called radius
	// get start of for..next loop
	$left = $curpage - $window_width;
	if($left < 0){
		$left = 0;
	}
	// get end of for..next loop
	$right = $left + ($window_width * 2);
	if($right > $numpage){
		$right = $numpage;
	}
	// do we need a FIRST page link
	if($numpage > 10 && $curpage != 0 && $left > 0){
		$chain .= create_link(
			$link.'0',
			$prev.'[FIRST]',
			$class).' ';
		$chain .= '...';
	}
	// do we need a prev page link
	if($curpage != 0){
		$chain .= create_link(
			$link.($curpage - 1),
			$prev,
			$class).' ';
	}
	// is there more than 10 links in the chain?
	if($numpage > 10){
		// complex chain
		for	( $i = $left ; $i <	$right ; $i++	) {
			if ( $i	!= $curpage ) {
				$chain .= create_link(
					$link.$i,
					($i + 1).' ',
					$class);
			} else {
				$chain .= ($i + 1).' ';
			}
		}
	} else {
		// simple chain
		for	( $i = 0 ; $i <	$numpage ; $i++	) {
			if ( $i	!= $curpage ) {
				$chain .= create_link(
					$link.$i,
					($i + 1).' ',
					$class);
			} else {
				$chain .= ($i + 1).' ';
			}
		}
	}
	// need a next page link	
	if(($curpage + 1) <	$numpage){
		$chain .= create_link(
			$link.($curpage + 1),
			$next,
			$class);
	}
	// need a LAST page link
	if($numpage > 10 && $right != $numpage){
		$chain .= '...';
		$chain .= create_link(
			$link.($numpage - 1),
			'[LAST]'.$next,
			$class).' ';
	}
	return $chain;
}

And it's called like this:

	$var['chain'] = page_chain(
		$PHP_SELF.'?op=show&page=',
		'pagenav',
		'&lt;&lt;',
		'&gt;&gt;',
		$curpage,
		$numpage);

It's not documented or done yet. "Done" as in relation to what I'm doing. But it works! When it is done I'll stick it in the 'Code Library' like a good lil' programmer. Hope it helps?

[edited for booboo in last page link.]

archivia

Thanks for the help guys, I'll have to look at this over the weekend, I'll let ya know how it works out. 🙂