uploading files by forms

grizclient

Hi,

I made a script so that users can enter articles, headlines, etc. and upload pictures for a newspaper site. The text information will eventually be stored in a mySQL database and the pictures will be copied to a directory. The problem arises with uploading the pictures.

The form:

<FORM METHOD="POST" ACTION="submit.php" enctype="multipart/form-data">
Picture 1: <INPUT TYPE="file" NAME="picture1"><br>
<INPUT type="hidden" NAME="MAX_FILE_SIZE" value="1000000">
<INPUT TYPE="submit" NAME="submit" value="Submit">
</FORM>

The upload script:

$pic1 = $_FILES["picture1"];
function copy_pics($pic,$img_var,$date)
{
	if($pic!="")
	{
		copy($_FILES[$img_var]["tmp_name"], "D:\\web\\images\\".$date.$_FILES[$img_var]['name']) or die("Error copying file.");
		echo $_FILES[$img_var]["name"]." (".$_FILES[$img_var]["size"]."bytes) of type, ". $_FILES[$img_var]["type"].", successfully uploaded.";
	}
	else
	{
		echo "Input file unavailable.";
	}
}

When I run the script, "Input file unavailable." is what shows up. What am I missing?

blanius

First line you have $pic1 then in your if you check for $pic

$pic1 = $_FILES["picture1"];
function copy_pics($pic,$img_var,$date)
{
	if($pic!="")
	{
		copy($_FILES[$img_var]["tmp_name"], "D:\\web\\images\\".$date.$_FILES[$img_var]['name']) or die("Error copying file.");
		echo $_FILES[$img_var]["name"]." (".$_FILES[$img_var]["size"]."bytes) of type, ". $_FILES[$img_var]["type"].", successfully uploaded.";
	}
	else
	{
		echo "Input file unavailable.";
	}
}

When I run the script, "Input file unavailable." is what shows up. What am I missing? [/B][/QUOTE]

grizclient

When I call the function, I pass $pic1 as an argument so that shouldn't be the problem, right?

copy_pics($pic1,"picture1",$date);

Weedpacket

Another problem will become apparent when you look at the syntax highlighting of your posted code. I recommend a few judicious \ characters, or maybe replacing a few " with '.

grizclient

I figured out the problem. I was calling my function outside of if($_POST['submit']) and it was screwing around a bit. Silly me. :rolleyes:

Additionally the copy to directory did not exist and apparantly this is somewhat of a problem on win98se.

Thanks for the help.