Help with INSERT INTO

Jander

😕 I am creating a website for one of my classes and have run into a brick wall with something simple. I am making a checkout script for an e-business and need to insert data into my customer information table. Here is my code for the HTML form.

<html>	
	<body>
	  <p><center><font size="+3"><u>Check Out</center></font size></u></p>
	    <p>Please fill out this form so we can add your shipping information to our database.</p>
	      <form method="POST" action="submit.php">
	  	<p><u>Please enter your name:</u></p>
		<p>First Name: <input name="First_name" type="varchar" size="12" maxlength="20">
		   MI: <input name ="Middle_Init" type="Text" size="1" maxlength="1">
		   Last Name: <input name="Last_Name" type="Text" size="15" maxlength="30"></p>

    <p><u>Please enter your address:</u></p>
    	<p>Address: <input name="Address" type="Text" size="30" maxlength="255"></p>
	<p>City: <input name="City" type="Text" size="15" maxlength="50"</p>
	<p>State: <input name="State" type="Text" size="2" maxlength="2"</p>
	ZIP&#47;Postal Code: <input name="Zip_Code" type="Text" size="10" maxlength="10"></p>

    <p><u>Please enter  your Contact Information:</p></u>
	<p>Home Phone: <input name="Home_Phone" type="Text" size="12" maxlength="12"</p>
	<p>Work Phone: <input name="Work_Phone" type="Text" size="12" maxlength="12"</p>
	<p>E-mail address: <input name="Email" type="Text" size="50" maxlength="30"</p><br>
	<br>

	<input type="Submit" name="Submit" value="Submit">
	</form>
</body>

</html>

and here is the code for submit.php

<?php

include("db.php");
global $dbServer, $dbUser, $dbPass, $dbName;

$cxn = @ConnectToDb($dbServer, $dbUser, $dbPass, $dbName);

$query="INSERT INTO customer VALUES(",'$First_Name','$Middle_Init','$Last_Name','$Address','$City','$State','$Zip_Code','$Home_Phone','$Work_Phone','$Email')";
mysql_query($query);

?>

Anyone have any ideas as to where I am goin wrong?

edit: This is my error message

Parse error: parse error, unexpected ',' in c:\program files\apache group\apache\htdocs\bas\submit.php on line 8

barand

$query="INSERT INTO customer VALUES(" ,'$First_Name','$Middle_Init','$Last_Name','$Addre
ss','$City','$State','$Zip_Code','$Home_Phone','$W
ork_Phone','$Email')";

should be (note removal of " , before $firstname )

$query="INSERT INTO customer VALUES('$First_Name', '$Middle_Init', '$Last_Name', '$Address', '$City', '$State', '$Zip_Code', '$Home_Phone', '$Work_Phone', '$Email')";

assuming you are entering data into all the fields in the table in the right order.

Jander

Originally posted by barand

should be (note removal of " , before $firstname )
$query="INSERT INTO customer VALUES('$First_Name', '$Middle_Init', '$Last_Name', '$Address', '$City', '$State', '$Zip_Code', '$Home_Phone', '$Work_Phone', '$Email')";
assuming you are entering data into all the fields in the table in the right order. [/B]

all the fields are in the right order, the only thing is that I have a Customer_ID field in my table which is the primary key and is auto_increment.

edit: my INSERT INTO query "seems" to run but nothing is inserted into the table. 😕

barand

Safest way is to specify the fields you are inserting values into. That way it doesn't matter if the table design alters (as long as none of your fields are removed).

$query="INSERT INTO customer (firstname,initial,lastname, .... etc ... , email) 
VALUES('$First_Name', '$Middle_Init', '$Last_Name', '$Address', '$City', '$State', 
'$Zip_Code', '$Home_Phone', '$Work_Phone', '$Email')";

Jander

Woohoo it works now, thank you barand