File downloads...

The_Chancer

Just a little problem really, using the code:

<?php
$size=filesize($file);
header("Content-Type: application/octet-stream");
header("Content-Length: $size");
header("Content-Disposition: attachment; filename=".$file);
header("Content-Transfer-Encoding: binary");
readfile($file);
?>

to force download of a file, everything goes OK and I get the file in the end, however in the download dialogue box.. I get the following...

download.php?file=filename.ext

Instead of just the filename specified. Any way round this at all ?

evo4ever

Use this instead...


if($_GET['fileid'] == "filename"){
     header("location: FILE URL");
}

Go here: www.evostation.com/view.php?PAGEID=downloads and rollover your curser over a download url and click to download it.

[edit]to query for the download the url will be: page.php?fileid=filename. or u can use page.php?file=filename depending on what u want the $_GET name to be.[/edit]

evo4ever

Forgot to add that if you have multiple downloads (which im sure u have) then do the following:

<?php
if($_GET['fileid or file or whatever'] == "filename"){
     header("location: file url");

} elseif($_GET['fileid or file or whatever'] == "filename2"{
              header("location: file url");

} elseif$_GET['fileid or file or whatever'] == "filename3"{
              header("location: file url");

} and so on....

?>

Weedpacket

I think certain browsers aren't http-compliant.

$attachment=(
	strpos($HTTP_USER_AGENT,"Mozilla/4")===false // Not Moz4
	||                                           // or
	strpos($HTTP_USER_AGENT,"MSIE")!==false)     // is IE
	? ' attachment;'
	: '';
header("Content-Disposition:$attachment filename=$file");

Have a go with that. Maybe I've got the !==/=== back to front.

tyson

Guys - any idea how I get round this :

Cannot add header information - headers already sent by (output started at /home/user/public_html/config/ftpconfig.inc.php:69)

this is stopping me from sending the header info to force file download when someone clicks on 'file download' !!!!

any help would be much appreciated !!

Tyson

Weedpacket

See here. Anything that isn't a header is content. Including blank lines.

The_Chancer

Thanks for the ideas..

Weedpacket: The use of my application is purely on IE5.0 and above - company doesn't use anything but.. so it will always use content-disposition: attachment;

evo4ever: I am trying to force download of excel and word documents, which as the new IE includes the office API, will open it in the IE window, so a header(location: URL) cannot work in this instance.

I am just concerned that the "normal user" may not think they are getting the required file and not continue with the download - so I need the correct filename to be shown.