more efficient way to solve this problem....

[martincrumlish]

Hi,

I have a problem regarding functions. Its more of an optimisation problem as opposed to a functionality one.

The project I am working on is a bet calculator. I have all the bet types controlled through functions which have the bet details passed to them.

The problem is this:

If I have a 4 selection bet and 1 selection loses then this becomes a 3 selection bet and calls the 3 selection bet function.

Now, as I have it set up, there are if statements for every combination of winning selections and 1 losing selection.
Here is a snippet of the code:

function fourfold($odds1, $odds1a, $odds2, $odds2a, $odds3, 
$odds3a, $odds4, $odds4a, $stake, $rf1='', $rf2='', $rf3='', 
$rf4='', $deadheat1='', $deadheat2='', $deadheat3='', 
$deadheat4='', $eachway1='', $eachway2='', $eachway3='', 
$eachway4='', $status1='', $status2='', $status3='', $status4='')
{

if(
	(
		($status1 == "win") && 
		($status2 == "win") && 
		($status3 == "win") && 
		(($status4 == "void") || ($status4 == "lose"))) || 
		(($status1 == "placed") && 
		($status2 == "placed") && 
		($status3 == "placed") && 
		(($status4 == "void") || ($status4 == "lose"))) && 
		$eachway1 && 
		$eachway2 && 
		$eachway3 && 
		$eachway4
	)
	{
		return $total = treblecalc($odds1, 
$odds1a, $odds2, $odds2a, $odds3, $odds3a, $stake, $rf1, $rf2,
 $rf3, $deadheat1, $deadheat2, $deadheat3, $eachway1, 
$eachway2, $eachway3, $status1, $status2, $status3);
			$unitstake = $stake;
		}

In the code above, selection 4 is void so a treblecalc function is called which passes the variables for the 3 winning selections.

Now, if selection 1 loses, I have to repat this code only instead, passing all the values for the winning selections (which would be 2, 3 and 4) This is quite a long winded way of doing it and considering I have to code every combination up to 8 selections, its going to be a lot of code!

I was wondering, is there a way that this could be done:

There is a 4 selection bet, if any 1 selection loses it calls the treblecalc and adds the variables that only relate to the winning selections. Basically, I need a function or something that will remove the need to hard code every variation of winning and losing bets.

Your help with this is appreciated. 🙂

Thanks,
Martin

[Weedpacket]

I'm going cross-eyed just looking at it 🙂

Maybe you should take a step back and really have a ponder on the sort of data you're going to have to work with, and then design a structure that reflects that.

For example, instead of $status1, $status2, ...., why not just have a single $status[] array? (Not that I'm saying it would be best to have a $status[] array - just that it would be better than what you have now.)

You've got so many things labelled 1234 (bets, I presume they are), that you could consider something like

$bet = array(
'status'=>[i]whatever[/i],
'odds'=>[i]whatever[/i],
'oddsa'=>[i]whatever[/i],
...
);

And have a $bets[] array that contains those things. Instead of $status1, you'd have $bets[1]['status'].

Something I learnt for myself the hard way: Smart data structures and dumb code works a lot better than the other way around.

[martincrumlish]

Thanks for the reply.

Before taking on this project I new nothing about betting but seeing as i got a job with a bookmaker that has an online betting service, i have been forced to learn.

What you say about using arrays etc might be better but I have had so much trouble getting the calculations to work exactly (cant have any mistakes) that I dont think i would be able to change it.

All of the numbered varables relate to the different bets. On the bet form say you have 3 selections, then everything with a 1 at the end relates to selection 1 and so on.

basically, I need code that will say: if 3 out of these 4 are true, then do this.

[tomhath]

Adding to what Weedpacket said, this looks like a natural application of Object Oriented. You could hide all that complexity in a couple of php classes without major changes to the code; just use the classes to keep thinks organized.

[martincrumlish]

Hi,

I would agree that in hindsight, object oriented would be the best way to go. However, at the moment and with regard to this particular app, I dont have time to rework it as object oriented or to learn the object oriented methodology for PHP.

I have a deadline looming for this so its critical i can get the quickest dirtiest hack that will make it work 🙂 Once I do this, then i can rework everything to be object oriented etc. Its a case of getting a working version online now and then I could concentrate on making it according to good coding practices.

So, I appreciate your advice Weedpacket and tomhath 🙂

For the timebeing, any ideas on how I can code what i need:

if 3 out of 4 are true: do this, and pass the values of the 3 that are true to the function.

Thanks,
Martin

PS: Hope i dont seem stupid not going with the OO approach, at the moment its a case of getting it working to satisfy my boss who isnt very technical. He wouldnt go for me putting back the deadline to rework the code - he just wants it to work! 😉

[martincrumlish]

Ok, I have been trying to make a workaround for this problem, heres what I have come up with so far:

if(
	($status1 == "win") &&
	($status2 == "win") &&
	($status3 == "win") &&
	($status4 == "win") &&
	($status5 == "lose")
	)
	{
	$a = 1;
	$b = 2; 
	$c = 3; 
	$d = 4; 
	$false == $status5;
	}

if($a)
	{
	return $total = fourfold($odds.$a, 
$odds.$a."a", $odds.$b, $odds.$b."a", $odds.$c, $odds,
$c."a", $odds.$d, $odds.$d."a", $stake, $rf.$a='', $rf.$b='', 
$rf.$c='', $rf.$d='', $deadheat.$a='', $deadheat.$b='', 
$deadheat.$c='', $deadheat.$d='', $eachway.$a='', 
$eachway.$b='', $eachway.$c='', $eachway.$d='', $status.$a='', 
$status.$b='', $status.$c='', $status.$d='');
		}
	elseif(!$a){

// Carry out normal calculation code
}
}

Basically, i am going to hard code the different combinations and set each winning selection to a letter. ie: if the first selection of the 5 to win was number 1 I set $a = 1; If numbers 2,3,4 and 5 was the first to win, i would set $a = 2, $b = 3, $c = 4, $d = 5 and I would set $false = 1 (because selection 1 lost)

in this way, i only need to code 1 function call (fourcalc) and i can change around all the code for the if() statements, which is much easier to organise and maintain.

Now, the problem i have with this code is as follows: I dont think that is the correct way to write the variables.

the first part of erach variable is the same ie: $odds followed by a number. What i want to do is have $odds.$a and whatever is in $a will be appended onto $odds to make a new variable called $odds1 (if $a was = to 1)

To sum it up: I need help with the variables being passed to the function to make my hacked solution work 🙂

thanks for your help,

Martin

[martincrumlish]

Problem solved: used variable variables

${'odds'.$a}