Graphic duplication

dcjones

Hi Pete.

This is a follow on from an earlier thread. I have posted a new one because the original problem has bee solved thanks to many of your guys.

The issue at the moment is I have a script which displays records in a table of cols and rows.

the output is:

Table containing row and cols, yes great so far.

Col 1 contains the record ID.
Col 2 contains the country name.
Col 3 contains a pic of the coutry flag.

But the problem now is

first row: ID = 1, country= Argentina, flag = Argentina
second row: ID = 2, country= Australia, flag = Argentina and Australia
Third row: ID = 3, country = Austria, flag = Argentina, Australia and Austria.

This continues dow the table. Each row has the corect flag plus every other counties flag.

Any ideas as to why or how it is picking up the other flags.

SCRIPT

<?php
include 'error.inc';
include 'fb.inc';

$connection = mysql_connect($server, $user, $password);
mysql_select_db($database, $connection);

$offset=$_GET['offset'];
$step = $diff = 9;
$r = mysql_query("SELECT COUNT(*) FROM flags") or die(mysql_error());
$anz = mysql_result($r,0);
if ($offset+$diff>=$anz) {
$diff = $anz - $offset;
$vor = TRUE;
}
if (!$offset || $offset<0) {
$offset = 0;
$zur = TRUE;
}

$query = "select id, flag from flags order by flag LIMIT $offset,$diff";
$result = mysql_query($query) or die(mysql_error());

// Start a table, with column headers

echo "\n<table bgcolor=\"#EDF3F2\" width=\"100%\" border=\"0\" cellpadding=\"0\" cellspacing\"0\" bgproperties=\"fixed\">" .
"\n\t<td width=\"10%\" bgcolor=\"#99000\"></td>" .
"\n\t<td width=\"30%\" bgcolor=\"#990000\">id</td>" .
"\n\t<td width=\"60%\" bgcolor=\"#990000\">Flag</td>" .
"\n</tr>";
echo "\n<tr>\n\t<td></td>\n</tr>";
echo "\n<tr>\n\t<td></td>\n</tr>";
echo "\n<tr>\n\t<td></td>\n</tr>";

 // Until there are no rows in the result set,
 // fetch a row into the $row array and ...

while($row = mysql_fetch_array($result))
{
$body .="<img src = \"flags/$row[flag].gif\">";

// ... start a TABLE row ...

echo "<tr bgcolor=\"#EDF3F2\" onMouseOver=\"this.style.backgroundColor ='#FFFF99'\" onMouseOut=\"this.style.backgroundColor ='#EDF3F2'\">";
echo "<td align=\"left\">" .$row["id"] ."\n\t";
?>
<td align="left" width="766"> <a href=\"embassies/emb.php?idname=<? echo urlencode($row["flag"]).">".$row["flag"] ?></a></td>
<? "\n\t";
echo "<td align=\"left\">" .$body ."\n\t";
echo "</tr>";

// Finish the row
echo "\n</tr>";

}
if($zur!=TRUE)echo'<a href="'.$PHP_SELF.'?id='.($id-($tmp+$step)).'&offset='.($offset-$step) . ' ">Back </a> ';
for ($i=1;$i<=(int)ceil($anz/$step);$i++) echo '<a href="'.$PHP_SELF.'?id='.(($i-1)$step).'&offset='.(($i-1)$step). '" > '.$i.'</a> ';

if ($vor != TRUE) echo '<a href="'.$PHP_SELF.'?id='.$id.'&offset='.($offset+$step).'">Next</a>';

 // Then, finish the table
 echo "\n</table>\n";

// Close the connection
if (!(mysql_close($connection)))
showerror();

?>
Regards

PHPdev

Not sure if this is just a typo or a copying error.. but

$body .="<img src = \"flags/$row[flag].gif\">";

does not have " around your array index.

Dont think this is causing your problem...

PHPdev

PS. Try putting your code in the {php} {/php} tags, the color coding aids in debugging

JMHO

PHPdev

Ok found your problem...

You are using $body .= when you set the body variable...

I think you need to use the =

or you are just appending <img src="....> to the $body...

You probably already knew most of this.. but I think that should solve your problem

PHPdev

dcjones

Hi.

Thanks for your reply, you were right about the "body . ="
I took the "." out and it's fine now.

I thank you for that, it was driving me mad.

With regard to putting the code into PHP tags. How would you recommend I do this for future threads.

Many thanks

Dereck

PHPdev

Just replace the {} with [] in my earlier post

it will look something like this

echo "test";

for ($x = 1; $x > 10; $x++) {

}

Just makes it a little easier to read... for me anyway...

PHPdev