Curly braces - making code easier to read

[crickettdt]

Why don't people write nice easy to read code - by using curly braces to shape code, and make it more pliable

for example:

if ($var != "1")
{
//see how much easier it is to read
}

rather than:

if ($var != "1") {
//it doesn't make much difference here, but does in large blocks of code
}

It's just so much easier to read, and maintain. Also, you will waste less time as you may see the obvious mistakes in your code - such as too many/too few curly braces etc

[hand]

<?
if ($dir = @opendir($dirname )) {
   while (($file = readdir($dir)) !== false) {
      if (!is_dir($file)) {
            // this code, I think is more readable than ...
         }
      }
   }  

   closedir($dir);
}
?>


<?
if ($dir = @opendir($dirname ))
   {
   while (($file = readdir($dir)) !== false)
   {
      if (!is_dir($file))
	  {
            // this code, but  

         }
      }
   }  

   closedir($dir);
}
?>

[crickettdt]

Its obviously a very subjective subject - and dependant on how you learnt to write code - and what you're used to.

[rIkLuNd]

I agree with you, crickettdt. I think that the second example is "better" than the first one.

[barand]

... and both have 3 {'s and 4 }'s😉

[crickettdt]

barand

Thanks for spotting that on hand's code, just reinforces my belief that it is easier to spot mistakes etc using my style.

Cheers

[barand]

But the mistake was made using BOTH styles . The compiler will spot errors in both instances, but when it comes to finding the error, it's the indentation that is the great help, not the style.

[crickettdt]

I didn't write the erroneous code, i was merely pointing out that it is easier to spot errors such as too many braces - i am fully aware that the compiler will spot the errors in both styles.