Upload an image..

FidoDifo

Why do I upload an image file and the name listed in the database is like "/tmp/php8YU8Kj or /tmp/phpvBUib1" instead of the filename??
The file is copy to the specific directory but the filename in the database is /tmp/php8YU8Kj....

Is this the correct way to upload a file
=> copy($FILES['img']['tmp_name'], $dir.$FILES['img']['name']) or die("Couldn't copy the file!");

????

Rayn


$new_temp_dir = "$DOCUMENT_ROOT";
$filename = basename($data_name);
  if (!copy($data, "$new_temp_dir/$filename")) {
    echo "Error";
    exit;
  }

$newdata = "$new_temp_dir/$filename";
$image_data = addslashes(fread(fopen($newdata, "r"), filesize($newdata)));

$imageinfo = GetImageSize($newdata);
$imagewidth = $imageinfo[0];
$imageheight = $imageinfo[1];



  if ($imagewidth>$imagewidth2) {
    exit;
  } else if ($imageheight>$imageheight2) {
    exit;
  } else {
      mysql_query("INSERT INTO affiliate (filedata,filename,filesize,filetype) ".
      "VALUES('$image_data','$data_name','$data_size','$data_type')");
  }

but you will want to have this in your <form>

ENCTYPE="multipart/form-data"

FidoDifo

I tried it, it is still the same...

This is my Field type for the image name...
I use varchar, does this have any difference..???
img | varchar(25)

This is my part of my code...
$dir = "/mydirectory/images/";
$filename = basename($img_name);
copy($img, "$dir/$filename") or die("Could not copy File");

Is it correct??

Rayn

For the image upload I would suggest using a blob since it is very large. But for the other fields use varchar.

[deleted]

"Why do I upload an image file and the name listed in the database is like "/tmp/php8YU8Kj or /tmp/phpvBUib1" instead of the filename"

Because PHP saves the uploaded file under a temporary name after the upload.

This is for obvious reasons: two people could upload files that have the same name.

The original filename is also uploaded, if you read the PHP manual about 'handlding file uploads' you'll see how that is done.

Also, do not, EVER, save a file under it's original name. Hackers can easily create names like '.htaccess' or 'htpasswd' or even '../../etc/passwd' and instantly hack your system.

Always save the file using som random name, or using the record-id of the database (because that is unique).

Also, never every put files into blobs in a database, it is completely pointless and just slows down your database.
Put the original filename in the database, put the location of the file on disk in the database, but don't store the file itself in the database.

Rayn

Originally posted by vincente
Also, never every put files into blobs in a database, it is completely pointless and just slows down your database.

Thats a matter of opinion...🙂

And the act of putting a image file into a database is slowing it down.

[deleted]

"Thats a matter of opinion..."

Give me one example of an application where you'd benefit from having binary data stored in a mysql database. 🙂

Some databases can do nifty things with binary data, but mysql cannot, it can only store it, and the filesystem is much faster at doing that.

"And the act of putting a image file into a database is slowing it down."

'also' slows it down. The bigger a table gets, the slower it gets on insert and select, especially for mysql. And there are limits to the size of a table (allthough these days the limits are much higher than a few years ago)

The real point is that you can only get the data out of the database by running a query. And HTML works by sending one request per image and each request starts a script, so if you want to display 10 images, you much start 10 scripts that run 10 queries on the database. If you have 10 concurrent pageviews, you have to run 100 concurrent queries (at least) on the database. And mysql does not like high-concurrency at all.

But if you have some good arguments for storing binary data in a DB, I'm all ears! 🙂