Form auto submitting!!?? why?

[evo4ever]

Hey all. Ive just wrote a php script which allows me to add members to a database. The problem is that the form is automatically submitting it's self! which i obviously dont want it to do! heres the code:

<?php
	$user="subastic";
	$host="localhost";
	$password="pass";
	$database = "evostation_com_1";
	$connection = mysql_connect($host,$user,$password)
		or die ("Couldnt connect to server");
	$db = mysql_select_db($database,$connection)
		or die ("Couldn't select database");

/* check information from the form */

/* set up array of field lables */
$label_array = array ( "nickname" => "Nick Name",
					   "firstName" => "First Name",
					   "country" => "Country",
					   "dob" => "Date of Birth");
foreach ($HTTP_POST_VARS as $key => $value)

{

/* check each field for blank fields */
if ( $value == "" )
{
	$blank_array[$key] = "blank";
}
elseif ( ereg("(name)",$key) ) 			// if key includes "name"
{
    if (!ereg("^[A-Za-z' -]{1.50}$",$HTTP_POST_VARS[$key]) )
	{
		 $bad_format[$key] = "bad";
	}
}
}
/* if any feilds were not okay, display error message and form */
if (@sizeof($blank_array) > 0 or @sizeof($bad_format) > 0)
{
  if (@sizeof($blank_array) > 0)
  {
  	  /* display message for missing information */
	  echo "<b>You didn't fill in one or more required fields. You must
	  		 enter:</b><br>";
	  /* display list of missing information */
	  foreach($blank_array as $key => $value)
	  {
	     echo "&nbsp;&nbsp;&nbsp;{$label_array[$key]}<br>";
	  }
  }
  if (@sizeof($bad_format) > 0)
  {
      /* display message for bad information */
	  echo "<b>One or more fields have information that appears to be
	         incorrect. Correct the format for:</b><br>";
	  /* display list of bad information */
	  foreach($bad_format as $key => $value)
	  {
	     echo "&nbsp;&nbsp;&nbsp;{$label_array[$key]}<br>";
	  }
  }
  /* display form */
  echo "<p><hr>
    <form action='createmem.php' method='post'>
	<center>
	<table width='95%' border='0' cellspacing='0' cellpadding='2'>
	<tr><td align='right'><B>{$label_array['nickname']}:</br></td>
	  <td><input type='text' name='nickname' size='65' maxlength='65'
	         value='$nickname' > </td>
	</tr>
	<tr><td align='right'><B>{$label_array['firstName']}:</B></td>
	  <td><input type='text' name='firstName' size='65' maxlength='65'
	          value='$firstName' > </td>
	</tr>
	<tr><td align='right'><B>{$label_array['country']}:</B></td>
	  <td><input type='text' name='country' size='65' maxlength='65'
	          value='$country' > </td>
	</tr>
	<tr><td align='right'<B>{$label_array['dob']}:</B></td>
	  <td><input type='text' name='dob' size='65' maxlength='65'
	          value='$dob' > </td>
	</tr>
	</table>
	<p><input type='submit' value='Create Member'>
	</form>
	</center>";
  exit();
 }
 else // if data is okay
 {
   $nickname = trim($nickname);
   $nickname = strip_tags($nickname);
   $firstName = trim($firstName);
   $firstName = strip_tags($firstName);
   $country = trim($country);
   $country = strip_tags($country);
   $dob = trim($dob);
   $dob = strip_tags($dob);

   $query = "INSERT INTO pk_mem_db (nickname,firstName,country,dob) VALUES
              ('$nickname','$firstName','$country','$dob')";
   $result = mysql_query($query)
      or die ("Couldn't execute query.");
   echo "New member added to database<br>";
  }

?>

help would be most appreciated! Thx.

[edit] the page is called createmem.php[/edit]

[tomhath]

I'm not sure what you mean by "automatically submitting itself".

How is the php page being requested the first time? This page always assumes its processing a POST request (from the form that's echoed in the middle of the page). Unless you already displayed the form somewhere else, there's no way for this to ever display the form without trying to process the POST first (before you even displayed the form the first time).

All you need is to call the "isset" function for all the form fields at the top of the page and skip the processing unless the form was posted.

[planetsim]

Are you refreshing the page..

[evo4ever]

When i try to view the page i immediately get a message saying: "New member added to database" or "Couldn't execute query."

its totally skipping the form! Which means the form is automatically submitting its self with no values in the text feilds.

[planetsim]

Try where it adds to the db.. have if(!empty($Create Member)){do db stuff}else{show form}

you should change this

<input type='submit' value='Create Member'>
and the var i created to

<input type=submit name=submit value=Submit>

if(!empty($Create Member)){ change the to then

if(!empty($submit)){

it doesnt seem likes its autosubmitting
its a coding error on your terms

[evo4ever]

hmm. you've lost me! just amend your changes to my code and post it back. thx.

[planetsim]

<?php
    $user="subastic";
    $host="localhost";
    $password="pass";
    $database = "evostation_com_1";
    $connection = mysql_connect($host,$user,$password)
        or die ("Couldnt connect to server");
    $db = mysql_select_db($database,$connection)
        or die ("Couldn't select database");

/* check information from the form */

/* set up array of field lables */
$label_array = array ( "nickname" => "Nick Name",
                       "firstName" => "First Name",
                       "country" => "Country",
                       "dob" => "Date of Birth");
foreach ($HTTP_POST_VARS as $key => $value)

{

/* check each field for blank fields */
if ( $value == "" )
{
    $blank_array[$key] = "blank";
}
elseif ( ereg("(name)",$key) )             // if key includes "name"
{
    if (!ereg("^[A-Za-z' -]{1.50}$",$HTTP_POST_VARS[$key]) )
    {
         $bad_format[$key] = "bad";
    }
}
}
/* if any feilds were not okay, display error message and form */
if (@sizeof($blank_array) > 0 or @sizeof($bad_format) > 0)
{
  if (@sizeof($blank_array) > 0)
  {
        /* display message for missing information */
      echo "<b>You didn't fill in one or more required fields. You must
               enter:</b><br>";
      /* display list of missing information */
      foreach($blank_array as $key => $value)
      {
         echo "&nbsp;&nbsp;&nbsp;{$label_array[$key]}<br>";
      }
  }
  if (@sizeof($bad_format) > 0)
  {
      /* display message for bad information */
      echo "<b>One or more fields have information that appears to be
             incorrect. Correct the format for:</b><br>";
      /* display list of bad information */
      foreach($bad_format as $key => $value)
      {
         echo "&nbsp;&nbsp;&nbsp;{$label_array[$key]}<br>";
      }
  }
  /* display form */
if(empty($submit)){
  echo "<p><hr>
    <form action='createmem.php' method='post'>
    <center>
    <table width='95%' border='0' cellspacing='0' cellpadding='2'>
    <tr><td align='right'><B>{$label_array['nickname']}:</br></td>
      <td><input type='text' name='nickname' size='65' maxlength='65'
             value='$nickname' > </td>
    </tr>
    <tr><td align='right'><B>{$label_array['firstName']}:</B></td>
      <td><input type='text' name='firstName' size='65' maxlength='65'
              value='$firstName' > </td>
    </tr>
    <tr><td align='right'><B>{$label_array['country']}:</B></td>
      <td><input type='text' name='country' size='65' maxlength='65'
              value='$country' > </td>
    </tr>
    <tr><td align='right'<B>{$label_array['dob']}:</B></td>
      <td><input type='text' name='dob' size='65' maxlength='65'
              value='$dob' > </td>
    </tr>
    </table>
    <p><input type='submit' name=submit value='Submit'>
    </form>
    </center>";
  exit();}
 }
 else // if data is okay
 {
   $nickname = trim($nickname);
   $nickname = strip_tags($nickname);
   $firstName = trim($firstName);
   $firstName = strip_tags($firstName);
   $country = trim($country);
   $country = strip_tags($country);
   $dob = trim($dob);
   $dob = strip_tags($dob);

   $query = "INSERT INTO pk_mem_db (nickname,firstName,country,dob) VALUES
              ('$nickname','$firstName','$country','$dob')";
   $result = mysql_query($query)
      or die ("Couldn't execute query.");
   echo "New member added to database<br>";
  }

?>

Now that wont work. Cos i cant really tell what your doing up top. Is that for it to insert to the database or is that to show information in the form itself

[evo4ever]

The purpose of the form is to insert data into a database.

[planetsim]

I know that.. but whats the top bit for.. The part before you echo the form..

[evo4ever]

form validation. it checks if the fields are filled in or filled correctly etc.

[planetsim]

Ok that makes things easier... If its checking validation. Wouldnt it be good if it was with the insert to database bit.. cos what its doing.. Is quickly going through the validation. Then going to the insert database skipping the form..

<?php
//moving the validation
    $user="subastic";
    $host="localhost";
    $password="pass";
    $database = "evostation_com_1";
    $connection = mysql_connect($host,$user,$password)
        or die ("Couldnt connect to server");
    $db = mysql_select_db($database,$connection)
        or die ("Couldn't select database");

/* check information from the form */

/* set up array of field lables */
$label_array = array ( "nickname" => "Nick Name",
                       "firstName" => "First Name",
                       "country" => "Country",
                       "dob" => "Date of Birth");
foreach ($HTTP_POST_VARS as $key => $value)

{

/* check each field for blank fields */
if ( $value == "" )
{
    $blank_array[$key] = "blank";
}
elseif ( ereg("(name)",$key) )             // if key includes "name"
{
    if (!ereg("^[A-Za-z' -]{1.50}$",$HTTP_POST_VARS[$key]) )
    {
         $bad_format[$key] = "bad";
    }
}
}
/* if any feilds were not okay, display error message and form */
if (@sizeof($blank_array) > 0 or @sizeof($bad_format) > 0)
{
  if (@sizeof($blank_array) > 0)
  {
        /* display message for missing information */
      echo "<b>You didn't fill in one or more required fields. You must
               enter:</b><br>";
      /* display list of missing information */
      foreach($blank_array as $key => $value)
      {
         echo "&nbsp;&nbsp;&nbsp;{$label_array[$key]}<br>";
      }
  }
  if (@sizeof($bad_format) > 0)
  {
      /* display message for bad information */
      echo "<b>One or more fields have information that appears to be
             incorrect. Correct the format for:</b><br>";
      /* display list of bad information */
      foreach($bad_format as $key => $value)
      {
         echo "&nbsp;&nbsp;&nbsp;{$label_array[$key]}<br>";
      }
  }
  /* display form */
//end move
if(empty($submit)){
  echo "<p><hr>
    <form action='createmem.php' method='post'>
    <center>
    <table width='95%' border='0' cellspacing='0' cellpadding='2'>
    <tr><td align='right'><B>{$label_array['nickname']}:</br></td>
      <td><input type='text' name='nickname' size='65' maxlength='65'
             value='$nickname' > </td>
    </tr>
    <tr><td align='right'><B>{$label_array['firstName']}:</B></td>
      <td><input type='text' name='firstName' size='65' maxlength='65'
              value='$firstName' > </td>
    </tr>
    <tr><td align='right'><B>{$label_array['country']}:</B></td>
      <td><input type='text' name='country' size='65' maxlength='65'
              value='$country' > </td>
    </tr>
    <tr><td align='right'<B>{$label_array['dob']}:</B></td>
      <td><input type='text' name='dob' size='65' maxlength='65'
              value='$dob' > </td>
    </tr>
    </table>
    <p><input type='submit' name=submit value='Submit'>
    </form>
    </center>";
  exit();}
 }
 else // if data is okay
 {
   $nickname = trim($nickname);
   $nickname = strip_tags($nickname);
   $firstName = trim($firstName);
   $firstName = strip_tags($firstName);
   $country = trim($country);
   $country = strip_tags($country);
   $dob = trim($dob);
   $dob = strip_tags($dob);

   $query = "INSERT INTO pk_mem_db (nickname,firstName,country,dob) VALUES
              ('$nickname','$firstName','$country','$dob')";
   $result = mysql_query($query)
      or die ("Couldn't execute query.");
   echo "New member added to database<br>";
  }

?>

ok this may not work.. But play around with it..

<?php
if(empty($submit)){
  echo "<p><hr>
    <form action='createmem.php' method='post'>
    <center>
    <table width='95%' border='0' cellspacing='0' cellpadding='2'>
    <tr><td align='right'><B>{$label_array['nickname']}:</br></td>
      <td><input type='text' name='nickname' size='65' maxlength='65'
             value='$nickname' > </td>
    </tr>
    <tr><td align='right'><B>{$label_array['firstName']}:</B></td>
      <td><input type='text' name='firstName' size='65' maxlength='65'
              value='$firstName' > </td>
    </tr>
    <tr><td align='right'><B>{$label_array['country']}:</B></td>
      <td><input type='text' name='country' size='65' maxlength='65'
              value='$country' > </td>
    </tr>
    <tr><td align='right'<B>{$label_array['dob']}:</B></td>
      <td><input type='text' name='dob' size='65' maxlength='65'
              value='$dob' > </td>
    </tr>
    </table>
    <p><input type='submit' name=submit value='Submit'>
    </form>
    </center>";
  exit();}
 }
 else // if data is okay
 {
  //moving the validation
    $user="subastic";
    $host="localhost";
    $password="pass";
    $database = "evostation_com_1";
    $connection = mysql_connect($host,$user,$password)
        or die ("Couldnt connect to server");
    $db = mysql_select_db($database,$connection)
        or die ("Couldn't select database");

/* check information from the form */

/* set up array of field lables */
$label_array = array ( "nickname" => "Nick Name",
                       "firstName" => "First Name",
                       "country" => "Country",
                       "dob" => "Date of Birth");
foreach ($HTTP_POST_VARS as $key => $value)

{

/* check each field for blank fields */
if ( $value == "" )
{
    $blank_array[$key] = "blank";
}
elseif ( ereg("(name)",$key) )             // if key includes "name"
{
    if (!ereg("^[A-Za-z' -]{1.50}$",$HTTP_POST_VARS[$key]) )
    {
         $bad_format[$key] = "bad";
    }
}
}
/* if any feilds were not okay, display error message and form */
if (@sizeof($blank_array) > 0 or @sizeof($bad_format) > 0)
{
  if (@sizeof($blank_array) > 0)
  {
        /* display message for missing information */
      echo "<b>You didn't fill in one or more required fields. You must
               enter:</b><br>";
      /* display list of missing information */
      foreach($blank_array as $key => $value)
      {
         echo "&nbsp;&nbsp;&nbsp;{$label_array[$key]}<br>";
      }
  }
  if (@sizeof($bad_format) > 0)
  {
      /* display message for bad information */
      echo "<b>One or more fields have information that appears to be
             incorrect. Correct the format for:</b><br>";
      /* display list of bad information */
      foreach($bad_format as $key => $value)
      {
         echo "&nbsp;&nbsp;&nbsp;{$label_array[$key]}<br>";
      }
  }
  /* display form */
//end move


   $nickname = trim($nickname);
   $nickname = strip_tags($nickname);
   $firstName = trim($firstName);
   $firstName = strip_tags($firstName);
   $country = trim($country);
   $country = strip_tags($country);
   $dob = trim($dob);
   $dob = strip_tags($dob);

   $query = "INSERT INTO pk_mem_db (nickname,firstName,country,dob) VALUES
              ('$nickname','$firstName','$country','$dob')";
   $result = mysql_query($query)
      or die ("Couldn't execute query.");
   echo "New member added to database<br>";
  }

?>

Now its not tested of course.. But this should know display the form.. Just fix a few things..

[evo4ever]

Bah it didnt work!!!! :mad: :mad: :mad: Planetsim have u got any simple scripts were they insert data into a database?

[Weedpacket]

The problem is that your script never bothers to check to see if it has a form to process before it jumps in trying to process it.

Give your submit button a name - name="sumitbutton" - will do as well as any other.

Then take all the form processing code, wrap a test around it:

if(isset($HTTP_POST_VARS['submitbutton']))
{
.........form processing code...........
}

[Weedpacket]

Originally posted by evo4ever
Bah it didnt work!!!! :mad: :mad: :mad: Planetsim have u got any simple scripts were they insert data into a database?

The problem isn't your database insertion, it's your form processing.

An example script? Too easy.

<?php
if($_POST['submit'])
{	echo "I got: ".$_POST['textfield'];
	...do stuff to database.
}
else
{	echo "Someone give me something.";
}
?>
<form action="$PHP_SELF" method="POST">
<input type="text" name="textfield">
<input type="submit" name="submit">
</form>