Weird Form Update Error

[bjblackmore]

Hi,

I'm having problems with a simple form update, its very basic, and a copy of some code I've used 100s of times before. Can anyone see anything wrong? Maybe I just can't see the woods for the trees! I keep getting

"ERROR - Query was empty"

On the form page..

echo '<form action="'. $PHP_SELF .'" method="POST">
<p align="center">
<input type="text" name="addtodo" size="30" maxlength="30">
<select name="addpriority">
<option value="1">1</option>
<option value="2">2</option>
<option value="3">3</option>
</select>
</p>
<p align="center">
<input type=submit name="add" value="Add">
</p>
</form>';

if ($add) {
update_todo($addtodo,$addpriority);
}

On the included code page

function update_todo($addtodo,$addpriority){
global $feedback;
$sql = "INSERT INTO todo VALUES (null, '$addtodo', '$addpriority')".
$result=db_query($sql);
if (!$result || db_affected_rows($result) < 1) {
$feedback .= ' ERROR - '.db_error();
return false;
} else {
$feedback .= ' Successfully Added ';
return true;
}
}

Many thanks

Ben

[planetsim]

try using double quotes on echo's instead of single quotes. But thats not your error though.. I just had a quick glance. And i couldnt really see any error.

Whats the line.. and the line that associates the error

[bjblackmore]

The error comes from the code

$feedback .= ' ERROR - '.db_error();

And all I get is

ERROR -
Query was empty

So I don't know what line, but its as if the contents of addtodo and addpriority aren't being passed to the function!

[Weedpacket]

Could a problem be that the todo table has changed so that the fields you're inserting don't line up with the fields in the table? I always explicitly list the fields, myself, just in case that happens.

I think $addtodo and $addpriority are getting passed; but then, if they weren't that still wouldn't cause the query to fall over (unless those fields are required to be non-NULL and the error message is wrong about the problem). You could always echo them before making the query to be sure.

Does $result always get a nonzero result in the event of a successful insertion? What does db_error() return if there's never been an error?

[bjblackmore]

Don't think the table has changed, I have

id | todo | priority

In my sql statement I use

$sql = "INSERT INTO todo VALUES (null, '$addtodo', '$addpriority')"

If, from telnet, when in mysql I do..

INSERT INTO todo VALUES (null, 'test', '1');

It inserts!

So the statement and fields seem fine. But somehow the values or query are null!

Cheers

Ben

[bjblackmore]

Arghhhhh!

Last night I spent 2 hrs looking at this, trying to get it working! I've just now looked at it with a fresh pair of eyes and I saw this

$sql = "INSERT INTO todo VALUES (null, '$addtodo', '$addpriority')".

Which should have been

$sql = "INSERT INTO todo VALUES (null, '$addtodo', '$addpriority')";

a ; rather than .

/me bangs head on desk repeatedly!

Cheers guys

Ben