How come there's an ARRAY ERROR???

FillePille

Hi, Why does this ARRAY ERROR come up?

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in C:\Program\Apache Group\Apache2\htdocs\eym\sjdb\admin.php on line 30

Warning: Cannot add header information - headers already sent by (output started at C:\Program\Apache Group\Apache2\htdocs\eym\sjdb\admin.php:9) in C:\Program\Apache Group\Apache2\htdocs\eym\sjdb\admin.php on line 41

This is the php-page:

<?
include("session.php");

$loginID = $_GET[loginID];

if ("".session_id()."" == ($loginID))

{
echo "välkommen";
}

else

{
header("Location: index.php");
}

<?
$answer = mysql_query("SELECT session_id FROM login WHERE id=$userid");
if(!$answer)
die(mysql_error());

$row = mysql_fetch_array($query);

if (($loginID) == ($row['session_id']))

{
echo "välkommen";
}

else

{
header("Location: index.php");
}

<BR>

<?
echo ("$loginID");
?>

<html>

</FORM>

</html>

the "$loginID" is a session_id stored in the url!..

suntra

$answer = mysql_query("SELECT session_id FROM login WHERE id=$userid"); 
if(!$answer) 
die(mysql_error()); 

$row = mysql_fetch_array($query);

Why you "fetch" $query ? Why don't you "fetch" $answer ??

FillePille

noo!! that was a miss, that's old, it now says :

$answer = mysql_query("SELECT session_id FROM login WHERE id=$userid");
if(!$answer)
die(mysql_error());

$row = mysql_fetch_array($answer);

But it doesn't work... it gets the same error message... 🙁((

EDIT: It works when I logg in, but The error message is when I try to access the webpage "admin.php?jkl34j5k5345345kl53k4j5vb" after logged out!.. I wan't to prevent people to go to that page... it's when I'm logged out I get that error message when going to admin.php...

Weedpacket

Originally posted by FillePille
noo!! that was a miss, that's old, it now says :

Slight modificiation (slightly cleaner)

 $answer = mysql_query("SELECT session_id FROM login WHERE id=$userid") or die(mysql_error());

And do a similar modification to the database connection command as well (it might be that statement that's failing).

Of course, if you're logged out, then wouldn't $userid be empty? Shouldn't you check that before you try and fish anything out of the database with it?

FillePille

Well, that's THAT that is the point! If $userid is nothing then it wouldn't be found togheter with the session_id in the database, and therefor would denie access to the webpage!.. The meaning is that you should only visit this page if you're logged in!.. Well, anyways it works fine, but I want to exchange that error message with something like "header", to take the user to the loginpage.... well well....

Weedpacket

Like I said, check to see if $userid exists. If it doesn't use header() to go back to the login page (and then exit() just to be tidy).

Only if $userid exists should you go to the work of connecting to the database, querying it to see if $userid is in there, etc. (You should still check this, just in case someone managed to slip in a bogus $userid somehow).