Updating Users Info PROBLEM!!

[jonsof]

i have written this script

<?php

mysql_connect("localhost");
mysql_select_db("authentication");

$uname=$_POST['users'];

$result=mysql_query("SELECT * FROM users WHERE username='$uname'");
$row=mysql_fetch_array($result);
echo "<table height=100% width=100% border=1>
<tr> <td align=center valign=center><a href=admin_panel.php>Go to the Admin Panel</a>

<table border=1>
<form method=post action=$PHP_SELF>
<tr><td>Id</td><td>$row[id]</td></tr>
<tr><td>Name</td><td><input type=text name=fname size=20 value=$row[fname]></td></tr>
<tr><td>Surname</td><td><input type=text name=lname size=20 value=$row[lname]></td></tr>
<tr><td>Username</td><td><input type=text name=usern size=20 value=$row[username]></td></tr>
<tr><td>Password</td><td><input type=password name=pass size=20 value=$row[password]></td></tr>
<tr><td></td><td><input type=submit value=Save name=save></td></tr>
</form></table>";

if ($_POST['save']) {
echo $name=$_POST['fname'];?><br><?
echo $surname=$_POST['lname'];?><br><?
echo $username=$_POST['usern'];?><br><?
echo $password=$_POST['pass'];?><br><?


if(($name)&&($surname)&&($username)&&($password)) {

mysql_query("UPDATE users SET fname='$name',lname='$surname', username='$username', password='$password' WHERE username='$uname'");

echo "Successfully updated the acount of $username";}

else {echo "You must fill all the fields in the form";}

echo "<meta http-equiv='refresh' content='3;url=select_user.php'>";}

echo"</td></tr>
</table>";
mysql_close();
?>

So the problem is the values are not changed every time i wanna change a field like Name, Surname, Password or Username!

Could you tell me what is going on?
$_POST['users'] variable comes from a drop down list in a php page like select_user.php

[twilson]

jon,

You are using the variable "$uname" in the UPDATE command but you didn't pass it using a HIDDEN form type from your form. $uname is therefore not defined.

Add this somewhere in your form:

<input type=hidden name=uname value=$uname>

Should work then.

Hope this helps,
Tom 🙂

[jonsof]

should i use

$uname1=$_POST['uname'];

mysql_query("UPDATE ...... WHERE username='$uname1'");

????

What can i achive with hidden forms what about the variables in them?

[twilson]

Well you said you passed the username variable from a dropdown box to your form page. You need to then include the hidden field in your form page, so when you submit that it is passed again because you use it again in the UPDATE command.

Peace,
Tom

[jonsof]

Allright it worked!!! Thank you very much!!!!

I need to learn a lot about hidden forms!!

[planetsim]

I doubt this has been said to you. But before starting PHP.. You should have a really good Understanding of HTML.

Otherwise little things like that can make the process of learning PHP extremely hard.

I didnt mention Javascript. Although its extremely useful. Most things it can be used for. PHP can do it..(I must say sometime/most times.)