frame inside javascript inside of php

jwbworks

Hi all

Im coding a dynamic frame set which will open a new window as people click on links on my site. In the frame set is a header, a hidden from for link recipricating, a frame for the landing url of the link the person clicked on, and then there is my trouble frame

I have written a frame inside a document.writin so I can pass some variables to php script. The roblem I am having is netscape is totally ignoring the frame set and rending it as a large frame border.

if any can review my code and let me know what I am doing wrong.

the url is (netscape only):

http://www.bigvaluezone.com/promo_search/promo_click_test.php?link_id=1

and the actual code in my php is:

echo "<html>\n";
echo "<head>\n";
echo " <title>" . $MERCH_NAME . "</title>\n";
echo " <script language=\"JavaScript\">\n";
echo " var \$W = screen.width;\n";
echo " var \$H = screen.height;\n";
echo " var \$C = screen.colorDepth;\n";
echo " </script>\n";
echo "</head>\n";
echo "<frameset framespacing=\"0\" border=\"0\" rows=\"120,1,99%,50\" frameborder=\"0\">\n";
echo "<frame name=\"header\" scrolling=\"no\" src =\"top.htm\" noresize target=\"_top\">\n";
echo "<frame name=\"exchange\" scrolling=\"no\" src=\"exchange.htm\" noresize target=\"_blank\">\n";
echo "<frame name=\"merchant\" scrolling=\"auto\" noresize src=\"" . $LINK_URL . "\" noresize target=\"_self\">\n";
echo "<script language = language=\"JavaScript\">\n";
echo "<frame name=\"track\" src=\"merch_tracker.php?url=" . $URL_REFER ."&link_id=1document.writeln('&W='+\$W+'&H='+\$H+'&C='+\$C+'\" noresize>');";
echo "</script>\n";
echo " <noframes>\n";
echo " <META HTTP-EQUIV=Refresh CONTENT=\"0; URL=" . $LINK_URL . "\">\n";
echo " <body>\n";
echo " <script language=\"JavaScript\">\n";
echo " document.writeln('<iframe src=\"merch_tracker.php?url=" . $URL_REFER ."&link_id=1&W='+\$W+'&H='+\$H+'&C='+\$C+'\" height=1 width=1 border=0></iframe>');\n";
echo " </script>\n";
echo "  \n";
echo " <script src=\"http://count.exitexchange.com/js/1169469\" language=\"JavaScript1.1\" type=\"text/javascript\">\n";
echo " </script>\n";
echo " \n";
echo " </body>\n";
echo "</noframes>\n";
echo "</frameset>\n";
echo "</html>\n";

any help would be greatly appreciated

thanks for your time

Jeff

sarahk

Ok, some thoughts

You don't have to have the entire code in php, you can break out to pure html if you want to, so that's what I've done. You'll notice that I can go into php midline if I want.

You've been really careful to escape your double quotes which is excellent but html is a bit more flexible so where you have
echo " <script language=\"JavaScript\">\n";
you could also have
echo " <script language='JavaScript'>";

Remember that the \n are 2 more characters to be downloaded and avoid them if you can, it makes no difference to the user's experience.

If you can put the javascript into an external file, easier to manage.

good luck

<html>
<head>
<title><?php echo $MERCH_NAME; ?></title>
<script language="JavaScript">
 var $W = screen.width;
 var $H = screen.height;
 var $C = screen.colorDepth;
</script>
</head>
<frameset framespacing="0" border="0" rows="120,1,99%,50" frameborder="0"> 
<frame name=\"header\" scrolling=\"no\" src =\"top.htm\" noresize target=\"_top\">\n"; 
<frame name=\"exchange\" scrolling=\"no\" src=\"exchange.htm\" noresize target=\"_blank\">\n"; 
<frame name=\"merchant\" scrolling=\"auto\" noresize src=\"" . $LINK_URL . "\" noresize target=\"_self\">\n"; 
<script language = language="JavaScript">; 
document.writeln('<frame name="track" src="merch_tracker.php?url="<?php echo $URL_REFER; ?>&link_id=1');
document.writeln('&W='+\$W+'&H='+\$H+'&C='+\$C+'\" noresize>');
</script>; 
<noframes>
<META HTTP-EQUIV=Refresh CONTENT="0; URL="<?php echo $LINK_URL; ?>"> 
<body>
<script language="JavaScript">
  document.writeln('<iframe src=\"merch_tracker.php?url="<?php echo $URL_REFER;>&link_id=1&W='+\$W+'&H='+\$H+'&C='+\$C+'\" height=1 width=1 border=0></iframe>');
</script>
<!-- Begin ExitExchange Code --> 
<script src="http://count.exitexchange.com/js/1169469\" language="JavaScript1.1" type="text/javascript"> 
</script>
<!-- End ExitExchange Code --> 
</body>
</noframes> 
</frameset>
</html>