ooh this is driving me crazy, please help !

benbox

Can anyone spot why this isnt editing the database?

Thanks!

<?
if($action=="edit" && isset($edit) && !isset($part)) {
$sql = mysql_query("SELECT * FROM news WHERE id = $edit") ;
while ($news = mysql_fetch_array($sql)) {
$id = $news["id"] ;
$title = $news["title"] ;
$message = $news["writing"] ;
$posted = $news["whenposted"] ;


?><form action="<?=$PHP_SELF?>?page=news&action=edit&part=2" method="post">
  <p>News ID: <?=$id?><br>
    Title:
    <input name="newtitle" type="text" value="<?=$title?>">
    <input name="id" type="hidden" value="<?=$id?>">
    <br>
    Date: <?=$posted?>
    <br>
    News Body: <br>
    <textarea name="newbody" cols="50" rows="5"><?=$message?></textarea>
  </p>
  <p>
    <input type=submit name=Submit value="Edit: <?=$title?>">
  </p>
</form><?

}
exit;
}

if($action=="edit" && $part==2) {
 mysql_query("UPDATE news SET title = '$newtitle', writing = '$newbody' WHERE id = $which") ;
 print "<b>Message</b>: News item updated.<br><br><br>";

}

Tessa

Is that a loner php tag after </form>
Is your php config file set to register_globals = on?

DigitalExpl0it

if($action=="edit" && $part==2) {
mysql_query("UPDATE news SET title = '$newtitle', writing = '$newbody' WHERE id = $which") ;
print "Message: News item updated. ";

}

try this

if($action=="edit" and $part=="2") {
 mysql_query("UPDATE news SET title = '$newtitle', writing = '$newbody' WHERE id = $which") ;
 print "<b>Message</b>: News item updated.<br><br><br>";

}

also where is the varible $which getting its data from?

looks to me like

$which = "";

so it might beable to know where to update to

jerdo

&& is and

benbox

hi people,

Tess... It is a section from a load of other php that works (not affecting this bit)... and for question 2: I dont know, but everything else seems to work this way..

DigitalExpl0it.. $which is the ID for the row to edit - it must be working because a hidden variable (printed with the submitting form) has the ID as its value, and it is also named which. So if this is the case, it seems to be loosing its value or not getting passed on when the form is submitted...
hidden fields can be anywhere within the form tags cant they?

Ill try AND instead of && now...

thanks for the help guys and gurls

benbox

<?
if($action=="edit" && isset($edit) && !isset($part)) {
$sql = mysql_query("SELECT * FROM news WHERE id = $edit") ;
while ($news = mysql_fetch_array($sql)) {
?>

works tho... so it cant be &&

rheroux

I always put my database connection identifier after my query, I don't know if it's mandatory, but it wouldn't hurt to try it.

So, change this part:

<?
if($action=="edit" && isset($edit) && !isset($part)) {
$sql = mysql_query("SELECT * FROM news WHERE id = $edit") ;

to:

<?
if($action=="edit" && isset($edit) && !isset($part)) {
$sql = mysql_query("SELECT * FROM news WHERE id = $edit",$dbcx) ;

If that doesn't work, try debugging it with some or die ("Can't execute query") code to see where the query is dying.