Delete row using "Delete" link

[lobster]

OK...I have been mucking with this for a while now.

I have rows of users and thier data on a page. And after each user I have a link "delete". I want the user row in the table to be deleted when the admin clicks on the delete link.

Can this be done?

Here's a snippet of the code in register.php:

echo "<td><font color='#990000' size='2' face='Arial'><b>";
echo "<a href='#' onClick='doDelete('";
echo htmlspecialchars( stripslashes($row["login"]));
echo "')'>";
echo "delete</a>";
echo "</b></font></td>

Where I have a class in remove.inc that looks like this:

<?

class Remove
{
function doDelete($this)
{
$dbh=mysql_connect ("localhost", "user", "password") or
die ('I cannot connect to the database.');

   mysql_select_db("my_db");

   $query = "DELETE from MEMBERS where login=$this"
    }

}
?>

Of course...this does not work...can anyone help?

Laura

[bastien]

you are using clientside javascript to call a serverside function - no can do...this echo "<a href='#' onClick='doDelete('";

will not work...

there are a couple of different ways to handle this
1. use clientside javascript to pass the id of the 'to delete' item to another page(via some kind of popup window), place the data in a form and autosubmit that form (could ask for confirmation here)
to a serverside script that deletes the data.

pros - looks good, asks for confirmation, never leave the page so multiple deletes can be done

cons - more complex to program

2. change the link to call the serverside script directly

echo "<a href='www.mysite.com/delete.php?id=$login'>Delete</a>";

pros - simpler to do, just a small mod of what you do now, cleaner to code, easy to do

cons - doesn;t ask for confirmation

it's up to you how you would like to approach it.

let me know if you need more details.

hth

[lobster]

OK I have the value being passed through in id= (finally!) and here is delete.php

<?

   $dbh=mysql_connect ("localhost", "user", "password") or
       die ('I cannot connect to the database.');

   mysql_select_db("my_db");    

   $query = "delete from MEMBERS where callsign=$id";
   $result = mysql_query($query);


   header("location:register.php");

?>

What am I doing wrong? It is returning to the page I want due to the header...but the delete is not working...Perhaps I am not going about this the right way.

[bastien]

can you check that? it might be as simple as that the page (registration.php) is loading from the cache and not the server with the altered data...

also check the delete statement by echoing it out before executing it to see if the $id value is set....maybe you need to use

$_GET to access the value being passed through the url

$query = "delete from MEMBERS where callsign=$id";

echo $query; //check if data okay to execute query

$result = mysql_query($query);

id $id is not available then try

$query = "delete from MEMBERS where callsign=".$_GET['id'];

also is $id numeric or alphanumeric?

then you might need quotes around the value

[lobster]

Thanks Bastien,

I put ' ' around $id in the delete.php file (because it is a string) and the echo query really helped...it didn't like where the header statement was. The delete.php file now looks like this (for anyone following this)

<?

   $dbh=mysql_connect ("localhost", "user", "pass") or
       die ('I cannot connect to the database.');

   mysql_select_db("my_db");    

   $query = "delete from MEMBERS where callsign='$id'";

   echo header("location:register.php");     

   $result = mysql_query($query);

?>

You're the best! Thanks for the help.

Laura

[bastien]

i think the echo is wrong with the header....

i think the problem is caused by a blank space/line in the file in the first line...php might interpret this as a blank sent to the client therefore causing an error

i always comment out the first lines - generally with a file name to prevent this

try it

[lobster]

OK. I removed the word "echo" and it worked fine. Was that what you meant just to remove the echo part?

Thanks for your help.