UPDATE problem...

lukemedway

OK I have a get style website where I have certain variables stored in the url such as the Username. I'm trying to make a news/commenting system, but for some reason the news will not update, due to the query being messed up and I'm not sure how to go about it.

Anyway, the query is...

$query = "UPDATE news_data SET Author=".$_GET['User'].", Date='$Date', Title='$Array[Title]', News_content='$Array[News_content]' WHERE news_id = '$news_id'";

The Author is obviously the username and I have tried it with GET, just the variable and the array method. The date is being taken from a variable which stores the value on the page. Title is being passed from a text box and news content is being passed from a text area.

What am I doing wrong? Please help. 🙁

barand

Does

$query = "UPDATE news_data SET Author=".$_GET['User'].", Date='$Date', Title='{$Array[Title]}', News_content='{$Array[News_content]}' WHERE news_id = '$news_id'";

work?

lukemedway

Not as well as I'd hoped 🙁

barand

If, after creating your $query, you

echo "$query<br>";

does it look OK or are values missing?

lukemedway

aha... This is what's being printed...

UPDATE news_data SET Author=DJBUCKSHOT, Date='07/12/2002 at 11:49PM', Title='', News_content='' WHERE news_id = '2'

So that means there is something wrong with the arrays...Because there is actually something in them fields... ?

barand

You need quotes round a few things

$query = "UPDATE news_data SET Author='".$_GET['User']."', Date='$Date', Title='{$Array['Title']}', News_content='{$Array['News_content']}' WHERE news_id = '$news_id'";

lukemedway

Damn, it's doing the same thing... Thank you for helping though mate. 🙂

Anymore ideas?

barand

If news_id is numeric, you don't need the quotes round $news_id.

What error message are you getting? Are you getting the array values yet?

lukemedway

Yeah just put quotes around it to be sure, I'm just going through a trail and error basis really.

The result is...

$result = mysql_query($query) or die("ERROR: blah blah blah");

So it's showing the die message...

barand

try

$result = mysql_query($query);
if (!$result) echo mysql_error();

lukemedway

ROFLMFAO - I forgot to select the db!!!!!!!!!!!!!!!! OMFG - What am i doing...

Anyway, now the result goes through, but the update isn't actually working, instead it's just emptying the fields...

lukemedway

Well whatever, it's all working now, the query was...

$query = "UPDATE news_data SET Author='".$_GET['User']."', Date='$Date', Title='".$_POST['Title']."', News_content='".$_POST['News_content']."' WHERE news_id = '$news_id'";

In the end...

Thanks for all the help though 🙂