Deleting images from a edit screen

Dillenger

Ok,

I've got a script that displays my images from a certain folder, but i'm having trouble with my delete function:

The code i'm working on is at the bottom, called function deleteme()... Which is called by a delete form action...

I just don't think i'm doing this right at all... any help would be appreciated.

Thanks

<html>
<head>
<title>Your Title</title>
<link href="../../css.css" rel="stylesheet" type="text/css">
</head><div align="center">
<?php

// You can change the control the colors of the page and tables from the values below

$backColor = "FFFFFF";         // Page Background Color
$textColor = "000000";        // Page Text Color
$tbheadcolor = "#000000";   // Color of the control table header
$tbheaderfont = "#FFFFFF";     // Color of the control table header text
$tbbodycolor = "#CCCCCC";     // Color of the control panel body 
$tbbodyfont = "#000000";     // Color of the control panel text

/* 
You can leave the folder names alone unless you need to change them. 
If you do not have a low resolution folder just leave this value alone,
the script will detect its non-existance and not show the option in the
control panel.   

*/

$fullimages = "full";     //hi res images directory
$lowimages = "lowres";         //low res image directory
$thumbdir = "thumbs";         //The thumbnail folder
$set1 = 0;

//DO NOT EDIT BELOW HERE

 //write body open tag
    echo ("<body bgcolor=\"$backColor\" text=\"$textColor\">");
?>
<?php
//DO NOT EDIT BELOW HERE

//if the low image directory doesn't exist just use the full one
    if (is_dir($lowimages) != 1){
        $lowexists = 0;
        $lowimages = $fullimages;
    }
        else {
            $lowexists = 1;
        }

//set variables when undefined
    if ($columns == "") $columns = 1;     //How many images displayed per line
    if ($rows == "") $rows = 20;         //How many row are display per page

//find this number, and use it below
    $imagenumber = $columns * $rows;     //how many images per page

//set directory depending on state
    if ($res == ""){
        if ($resolution == "Low Res" or $resolution == ""){
            $imagedir = $lowimages;
            $res = 0;
        }
            else{
                $imagedir = $fullimages;
                $res = 1;
            }
    }
        else {
            if ($res == 0) $imagedir = $lowimages;
            if ($res == 1) $imagedir = $fullimages;
        }

//determine page state
    if ($page == "") $page = "1";
    $begin = ($page * $imagenumber) - $imagenumber;
    $end = ($page * $imagenumber) - 1;

//get files
    $j=0; //just initializing
    $handle=opendir($imagedir); //open image folder
    while (false!==($file = readdir($handle))) {
        if ($file != "." && $file != "..") {
            //echo "$file";
            $imageArray[$j]=$file;

        $j++;
    }
}
closedir($handle); 

//find out the how many images there are
    $numimages = sizeof($imageArray);

//write main table beginning
    echo ("<div align='center'><table width='100%' border='0' align='center'><tr><td width='140' valign='top'>");

//write image page navigation
    $pages = ceil($numimages / $imagenumber);
    if ($pages != 1){
        echo("<table border='0' cellspacing='0' cellpadding='2' align='center' class='formtex'><tr><td>Page</td>");

    for ($d=1; $d<=$pages; $d++){
    echo "<td align='center'><a href=\"edit.php?page=$d&columns=$columns&rows=$rows&res=$res\">$d</a></td>";
    }
    echo "</tr></table></p>";
}

//begin writing table
    echo ("<div align='center'><center><table><tr><td>");
    echo("</td></tr></table></center></div>");

echo ("<div align='center'><center><table><tr>");

$i=0; //nothing to see, just initializing

for ($x=$begin; $x <= $end; $x++){
    //begin writing images
    echo "<td>";
    if ($imageArray[$x] != ""){ //make sure we don't include images that aren't there
    print "<img src=$thumbdir/$imageArray[$x] border=0 align=\"absmiddle\"> <font class=\"formtex\">&nbsp;&nbsp;&nbsp;<form name=\"form1\" method=\"post\" action=\"$set = 1\"><input type=\"submit\" name=\"Submit\" value=\"delete\" class=\"formtex\"></form></font><br>";
    }
    echo "</td>";
    //write end column when needed
    ++$i;
    if($i == $columns) { print "</tr><tr>"; 
        $i = 0;
    }

}

//finish inside table
    echo ("</tr></table></center></div>");

//close outside page table
    echo ("</td></tr></table></div>");
?>
<?PHP
function deleteme(){
if ($set1 = 1){
unlink("/home/dhill/simplebit-www/dillenger/gallery/$thumbdir/$imageArray[$x]");
}else{
}
?>
</body>
</html>

diego25

Well, just looking at your function (without looking at the rest of the code) I can already see some errors:

function deleteme(){
if ($set1 = 1){
unlink("/home/dhill/simplebit-www/dillenger/gallery/$thumbdir/$imageArray[$x]");
}else{
}

You're missing one closing curly bracket. You've got one for the "else" but you're missing one for the function.

Also, where do the variables $set1, $thumbdir, $imageArray, and $x come from? You have to either pass them to the function, or declare them as globals (which I wouldn't recommend).

Diego