update query

[olking]

Can anyone help me with this update problem?

I have been more of an html person and some graphic expertise, but I want to become proficient in php/mysql.

The detail is in a text file attached

[cgraz]

Change

     <input type =HIDDEN name="id" value="<?php $id?>" >

to

     <input type =HIDDEN name="id" value="<?php echo $id; ?>" >

You forgot a semicolon, and if there's no value for $id, then WHERE id='$id' means nothing and mysql won't have anything to upddate.

Also on your UPDATE, you have a comma after $picture (right before WHERE) that you don't need. Change your $sql to the following

$sql = "UPDATE products SET code='$code', product='$product', size='$size', unitprice='$unitprice', picture='$picture' WHERE id='$id'";

Let me know how that goes.

[nemonoman]

hard to tell where the error is without access to your database, but this could help lead to the solution:

in the error part of your SQL handler, add

echo "$sql"; // or whatever var you're using for your query.

This will print the query being sent to the database with the actual values plugged in so you can view it.

I've found that those error "near id=1" errors typically refer to a problem BEFORE the id=1 clause.

My guess is you have some weirdness in your value for $picture -- for example, a stray single quote.

Printing out the actual value of $sql will help figure this out.

PS In fact, could I recommend using a query-handler function?

function dosql($query) {
$result = mysql_query($query);
if($result) {  echo("<p>Your data has been added.</p>");
		   }else{ 
		   echo("<p>Error adding submitted data: ".mysql_error()."<BR>$query");}
return $result;}

then use this for all your queries:

$result =dosql('SELECT * FROM mytable'); //etc.

[nemonoman]

just read cgraz's post. DEFINITELY it's the unneeded comma after $picture before WHERE.

[olking]

thanks to those who have replied.
It is great to know that there are people out there who are ready and able to help!

I have made the corrections suggested and it now appears that the update query is willing to operate, but now I get a message that there is a parse error in any line number after the actual query line.

It doesn't seem to matter what i put there I get the same message even if i have rem'd it out with //

any thoughts?

olking

modified "updatename" attached

[cgraz]

Change

$sql = " UPDATE products SET code='$code',product='$product',size='$size',unitprice='$unitprice',picture='$picture' WHERE id='$id'

to

$sql = "UPDATE products SET code='$code',product='$product',size='$size',unitprice='$unitprice',picture='$picture' WHERE id='$id'";

You were missing a " and ; at the end of your query.

Normally when PHP gives you a parse error, if the error isn't on the actual line, it's a couple lines up.