updating database entry

[Dillenger]

Can anyone tell me why this isn't submitting? I'm trying to edit data in a database table. The Data shows up, but when i hit submit, nothing happens.

<?
mysql_pconnect("localhost","****","******"); //enter name and password
mysql_select_db("simplebit_com"); //select the database

$result = mysql_query("select * from bio_intro"); //replace news with your table name
    while($r=mysql_fetch_array($result))
    {    

        $entry=$r["entry"];
	}
?>
            Message: <br>
            <TEXTAREA NAME="entry" ROWS=10 COLS=30><? echo $entry ?></TEXTAREA>
            <br><input type="Submit" name="submit" value="submit"> 
            <?
    if($submit)
    {
        $sql = "UPDATE bio_intro SET entry='$entry' WHERE entry=$entry";
        //replace news with your table name above
         $result = mysql_query($sql);
        echo "Thank you! Information updated.";
    }
?>

[cgraz]

where's your <form tag? I'm guessing it's farther up, but seeing that might help figure out why it's not submitting.

Here's something else I noticed. You're missing a colon after you echo $entry

<? echo $entry ?>

And on your update command, it's not a good idea to use the same info you're updating in the WHERE part of your clause. Right now you have

$sql = "UPDATE bio_intro SET entry='$entry' WHERE entry=$entry";

entry will never = $entry if they just modified the textarea and hit submit. If entry used to say hello, and i just modified it to say goodbye, $entry has now become goodbye.

so that's like saying WHERE hello='goodbye'

I'd change it to a unique id like WHERE id='$id', something unique for each record that never changes.

[Dillenger]

Thanks, that fixed it, I'm wondering how I can reverse the oder of how my post are displayed, so the most recent is placed on the first page, rather than the first post I ever did.

<?
mysql_pconnect("localhost","****","******");
mysql_select_db("simplebit_com");

if(!$rowstart) $rowstart=0;

$result = mysql_query("select * from news limit $rowstart,1");
$result2 = mysql_query("select * from news");

//put all the code here for running the script itself using $result in the while loop
while ($directory = mysql_fetch_array($result)) { 

  $id = $directory['id']; 
  $title  = $directory['title'];
  $entry = $directory['entry'];
  $date = $directory['date'];

  echo "$date<br><br>";
  echo "<b>$title</b><br><br>";
  echo "$entry<br><br><br>";

}

if ($rowstart>$numrows) 
{?>    

<A HREF="<? $php_self ?>?rowstart=<? echo $rowstart-1;?>"> 
< Previous Page</A>
<?}?>
| 
<?
$numrows=mysql_num_rows($result2);
if($rowstart+1<$numrows) 
{?>
<A HREF="<? $php_self?>?rowstart=<?echo $rowstart+1 ;?>">
Next Page ></A>
<? } ?> 

[cgraz]

Firstly, I wouldn't reccomend putting your mysql info (username, password, etc) in your posts. I'd replace them with

mysql_pconnect("localhost","user","pass");

Sorry, but that's a good habit to get into. 🙂

To sort them by most recent posts, you can create a date field in your database and posts the date, lets say you call that field inputedon. Then in your SELECT query, you ORDER BY inputedon and you can use ASC or DESC (i always get the two mixed up, but you can figure it out quickly)

$result2 = mysql_query("SELECT * FROM news ORDER BY inputedon ASC");

Cgraz

[Dillenger]

Hey thanks,

I just forgot to edit out my username password...fixed that 🙂

thanks for your help, i've got it working now... do you have any idea how to put the current time into my database? is it something like time(h-m-s)?????

thanks

[cgraz]

You really shouldn't double post.

To do what you want, you'll want the date and time in the database. When you create, your table, you'll have to make a timestamp field

$query = mysql_query("CREATE TABLE $table (
  id int(11) DEFAULT '0' NOT NULL auto_increment,
  field1 varchar(6) NOT NULL default '',
  field2 varchar(20) NOT NULL default '',
  field3 varchar(35) NOT NULL default '',
  inputedon timestamp NOT NULL,
  PRIMARY KEY (id)
)");

like that for example.

Then, to timestamp the database at the time you input your info. . .

$query = mysql_query("INSERT INTO yourtable (field1, field2, field3, inputedon) VALUES ('$field1', '$field2', '$field3', now()
)");

Change that example to fit your needs. now() inputs the timestamp into the database.

Good luck.