Getting a file into an array

xwin

I want to take a file (let's say members.txt), read it into php, then see if passwords and usernames match...

I have it set up like
id|user|password|

How do I get it into an array from:

list($user,$pass,$uid,$gid,$extra)= split ("|", $line);

Is it like:

array[1] = $user;

Sorry, I'm not good with arrays. Any help would be greatly appreciated.

Using a flatfile database.

dalecosp

Not sure that "I'm the man" on this or many other issues, but here's a couple of things.

Array keys start at zero by default, so assuming the first entry in an array is to be "user" call it with the key [0]

Second, your assignment statement there looks backwards, although it's probably just that you put it there for purposes of discussion rather than coding.

It might be possible to use "file," then explode twice, assuming something like this.

Contents of flatfile:

id1, username1, password1
id2, username2, password2
id3, etc......

Then you could:

$file_content=fread("flatfile", filesize("flatfile"));
    $lines = explode ( "\n", $file_contents );

foreach ( $lines as $line ) {

    list( $id, $username, $password ) = explode( ',', $line );

.....and then do your conditional checking within this loop with each potential user in turn. Could be a tad expensive, I guess, if the list of potential users is real long.

HTH,

xwin

I tried doing this:

<?php
if(isset($_POST["login"]))
{
   $user = $_POST["username"];
   $password = $_POST["password"];
   $cookie = $_POST["cookie"];
}
ob_start();
include("./root.txt");
$root = ob_get_contents();
ob_end_clean();
$file = file ("$root/data/members.txt");
foreach ($file as $line)
{
list($id, $user, $password)= split ("|", $line);
	if($user == $userdata and md5($password) == $md5password)
		{
		header("Set-Cookie: userid=$user; path=/");
			if ($user == $userdata)
				{
				header("Set-Cookie: id=$id; path=/");					
					if (md5($password) == $md5password)
						{
						header("Set-Cookie: pass=$md5password; path=/");
						header("Location: [url]http://[/url]".$HTTP_SERVER_VARS['HTTP_HOST']."/forums/index.php");
       		print("Thanks.  You are now logged in as: <b>{$user}</b> - <a href='../index.php'>Click here</a> to return to the forum index.");
						}
				}
		}
			else
   				{
    					print("Incorrect username/password combination.");
   				}
}
?>

But it comes up with:

Warning: REG_EMPTY in /home/virtual/site18/fst/var/www/html/forums/process/login.php on line 15
Incorrect username/password combination.

that comes up x however many lines are in the flatfile...

😐

diego25

The vertical bar "|" is a special character in regular expressions. Use explode() instead, which doesn't use regular expressions so will generally be faster.

Also, shouldn't
list($id, $user, $password)=
be
list($id, $user, $md5password)=

Diego

xwin

Ah, fixed those silly errors, but now I'm back to where it does this: It compares it line by line, so if I try to log in with user 5, say, I get 4 Incorrect username/password messages before that. And it only seems to process the first one. Also, says headers already sent when I login with an account that isn't the first one.

:-/

diego25

Don't put the "Password correct" or "Password incorrect" messages inside the loop -- that's the reason why you get "Password incorrect" many times before you get the right password. Put instead a boolean variable in the loop, and after the loop, check the boolean variable. If it's true, output the header and cookie, if it's false, output "Password incorrect".

Diego

xwin

example?

diego25

I'll give you a simplified example:

$auth = false;
foreach ($file as $line) {
list($id, $userdata, $md5password)= explode("|", $line);
if ($userdata == $user && md5($password) == $md5password) {
$auth = true;
break;
}
}
if ($auth) {
setcookie();
header();
//etc
}

Watch out though, this code can be fooled if you have register_globals on.

Diego

xwin

erm. That code doesn't work...

diego25

I said it was a simplified example, not a complete example...you're not supposed to copy and paste that into your program and expect it to work -- you're supposed to read through the code, understand it, and do some changes to your program.

Diego

xwin

Basically what I did.

Apparently, even when I build the $auth = true into if name and passwords equal, the echo message comes out when I do an if $auth = true echo "logged in" elseif (! $auth) echo "not logged in" test.

diego25

Can I see your modified code?

Diego

xwin

<?php
$auth = false;
if(isset($_POST["login"]))
{
   $user = $_POST["username"];
   $password = $_POST["password"];
   $cookie = $_POST["cookie"];
}
ob_start();
include("./root.txt");
$root = ob_get_contents();
ob_end_clean();
$file = file ("$root/data/members.txt");
foreach ($file as $line)
{
list($id, $userdata, $md5password)= explode ("|", $line);
	if($user == $userdata and md5($password) == $md5password)
		{
			$auth = true;
		}
else
{
    	print("Incorrect username/password combination.");
}

if ($auth = true)
	{
		header("Set-Cookie: userid=$user; path=/");
			if ($user == $userdata)
				{
				header("Set-Cookie: id=$id; path=/");					
						{
						header("Set-Cookie: pass=$md5password; path=/");
						header("Location: [url]http://[/url]".$HTTP_SERVER_VARS['HTTP_HOST']."/forums/index.php");
       		print("Thanks.  You are now logged in as: <b>{$user}</b> - <a href='../index.php'>Click here</a> to return to the forum index.");
						}
				}
	}
}
?>

Gets really angry now.

Incorrect username/password combination.
Warning: Cannot add header information - headers already sent by (output started at /home/virtual/site18/fst/var/www/html/forums/process/login.php:23) in /home/virtual/site18/fst/var/www/html/forums/process/login.php on line 28

Warning: Cannot add header information - headers already sent by (output started at /home/virtual/site18/fst/var/www/html/forums/process/login.php:23) in /home/virtual/site18/fst/var/www/html/forums/process/login.php on line 34
Thanks. You are now logged in as: xwin - Click here to return to the forum index.Incorrect username/password combination.
Warning: Cannot add header information - headers already sent by (output started at /home/virtual/site18/fst/var/www/html/forums/process/login.php:23) in /home/virtual/site18/fst/var/www/html/forums/process/login.php on line 28
Incorrect username/password combination.
Warning: Cannot add header information - headers already sent by (output started at /home/virtual/site18/fst/var/www/html/forums/process/login.php:23) in /home/virtual/site18/fst/var/www/html/forums/process/login.php on line 28
Incorrect username/password combination.
Warning: Cannot add header information - headers already sent by (output started at /home/virtual/site18/fst/var/www/html/forums/process/login.php:23) in /home/virtual/site18/fst/var/www/html/forums/process/login.php on line 28
Incorrect username/password combination.
Warning: Cannot add header information - headers already sent by (output started at /home/virtual/site18/fst/var/www/html/forums/process/login.php:23) in /home/virtual/site18/fst/var/www/html/forums/process/login.php on line 28
Incorrect username/password combination.
Warning: Cannot add header information - headers already sent by (output started at /home/virtual/site18/fst/var/www/html/forums/process/login.php:23) in /home/virtual/site18/fst/var/www/html/forums/process/login.php on line 28
Incorrect username/password combination.
Warning: Cannot add header information - headers already sent by (output started at /home/virtual/site18/fst/var/www/html/forums/process/login.php:23) in /home/virtual/site18/fst/var/www/html/forums/process/login.php on line 28

dalecosp

Getty really angry now.

I completely understand---I have the same problem myself often....however, it never makes me a better coder, it just means I have to buy new keyboards, monitors, pencils, pets, etc.

Here's the crux of this issue:

if ($auth = true) {

You need to use "==", not "=". One "=" is the assignment operator --- that will not do a comparison check to see if the values are equal, it will just set $auth to the value of true.

You've got some other stuff that looks a bit funny to me, too. Like the auth comparison itself --- I'd code it this way, I think:

if (if($user == $userdata) && (md5($password) == $md5password))

Also, that last 'header' line---I'll be checking back to see if it's working. I've never seen <html> tags in a location header before---does it work?

I'd recommend inserting some 'print' or 'echo' statements as variable checks inside some of the critical points of your loop(s). I find them usually very enlightening as to what is going on in my scripts.

G'luck,

xwin

I can now once again login as the first user, but the first user only.

diego25

Put the

else
{
print("Incorrect username/password combination.");
}

in the if-statement that checks if $auth == true.

Diego

Weedpacket

Well, you've got a } in the wrong place somewhere: the code

foreach ($file as $line)
{
list($id, $userdata, $md5password)= explode ("|", $line);
    if($user == $userdata and md5($password) == $md5password)
        {
            $auth = true;
        }
        else
        {
            print("Incorrect username/password combination.");
        }

Should be

foreach ($file as $line)
{	list($id, $userdata, $md5password)= explode ("|", $line);
	if($user == $userdata and md5($password) == $md5password)
	{	$auth = true;
	}
}

Or even better:

foreach ($file as $line)
{	list($id, $userdata, $md5password)= explode ("|", $line);
	if($user == $userdata and md5($password) == $md5password)
	{	$auth = true;
		break;
	}
}
else

Wherever that extra } is later on, drop it; and as diego25 points out, put the Invalid Password notice as the else condition when you test $auth==true.