can i optimise this code?

mrsocks

hello,

this code is to check the item id number againsst an array of arrays of items in a cart. the first array is the whole list of items. the internals arrays contain the item ID and the quanty.

what this does is build an array of id numbers and then check the newly ordered item's id number against it. if it is already in their cart, the quantity is simply added to the current items qty. otherwise it just adds a new items to the list.

the code i have seems a bit complicated to do this. is there a simpler, more efficient way of doing this?

thanks
//////////////////
reset($mycart);
$size_cart = sizeof($mycart);

if ($size_cart != 0)
{
	reset($mycart);
	while ($rowA = each($mycart))
	{
		$item_name = $rowA['value'][0];
		$mycart_items[] = $item_name;
	}

			if (in_array($item,$mycart_items))
			{
				reset($mycart);
				while ($row7 = each($mycart))
				{
				$key_val7 = $row7['key'];
				$item_name7 = $row7['value'][0];

					if ($item_name7 == $item)
					{
					$item_qty8 = $mycart["$key_val7"][1];
					$final_qty8 = $item_qty8 + $qty;
					$mycart["$key_val7"][1] = $final_qty8;
					}
				}				
			}
			else
			{
				$new_items = array($item, $qty);
				$mycart[] = $new_items;
			}
}
else
{
	$new_items = array($item, $qty);
	$mycart[] = $new_items;
}

//////////////

the_Igel

As you need only to store ID and qty of an item, I can suggest the next:
you have only 1D array ('id' => 'qty')

// we have new item $id and $qty;
// cart is stored in $cart array;

if (array_key_exists($id, $cart))
   $cart[$id] += $qty;
else $cart[$id] = $qty;

Remark: if you aren't afraid of some warnings, you can do it even simplier:

$cart[$id] += $qty;

- if $cart[$id] exists, the $qty will be added, and if it doesn't, it will be initialized as 0, and then $qty added.

mrsocks

Thanks!
i didnt even think about that.

can you just explain what this line means?
$cart[$id] += $qty;

i looks as though it will add the current qty to the new qty. i just havent seem the +=

thanks again.

ednark

yup your right

$var += 10;

is a short cut for

$var = $var + 10;

same as

$var++;

is a short cut for

$var = $var + 1;

mrsocks

thanks guys.

when i used the id number as the key, i was able to remove much of that code and make things much simpler and quicker.

mrsocks

ok,
i am back to this issue.
i forgot that i needed to store a sku number also for each item. So i have to store the product ID, qty for each and the SKU # for each item in the cart. unfortunately, not all items have sku numbers and the way we do it, you have one record with multiple skus if available.

i think that the way i had it orgianlly (posted at top) is ok. it is fast but if there is a way to optimize it, please fire away.

ALSO....

register_gloals are now OFF. i am having real problems being able to read and display the cart contents now. how would i access a value of an item in a session variable named "mycart" with a value of rand()?

i have tried a few thigns but nothing seems to be working. i think i am leaving out a very basic step.

when i add something to the cart or even go through a few pages, i check the phpinfo() and i dont see the session var mycart. WHY????

hopefully this makes sense.

thanks

ednark

with globals off....

you still need to initialize the session
session_start() or set session.autostart (or some variable similar) in the php.ini file

then you can read and write to the $_SESSION
variable

so to get mycart var you need

$_SESSION['mycart']

to write to it you need

$_SESSION['mycart'][] = $new_row;

if you are doing this and still having problems then please post the [session] chunck of your php.ini, as well as a your current test code... its important if its even a bit different than your first post

mrsocks

thanks alot. i will post if i have any further issues. i think i am using the sessison_start again. that is probbaly where i am having the problem. i thought that with the globals off, i wasnt supposed to use it.

either way, it is kind of working, but this advice will help to make me check what i have.

thank you and happy holidays.