simple file upload script results in wierd error

Bret

Whats wrong with this simple file upload script? I have no clue. Here's the error message I get:

Parse error: parse error, unexpected $ in c:\inetpub\wwwroot\test\upload.php on line 11

This seems strange to me since theres no code on line 11. Any help would be much appreciated. thanks. -B-

$userfile = $HTTP_POST_FILES['userfile']['tmp_name'];
$userfile_name = $HTTP_POST_FILES['userfile']['name'];

$upfile = "\uploads\".$userfile_name;
copy ($userfile, $upfile);

Bret

here's the form Im using:

<html>
<head>
<title>upload</title>

</head>
<body>
<h1> upload file: </h1>

<form enctype="multipart/form-data" action="upload.php" method=post>
<input type="hidden" name="MAX_FILE_SIZE" value="100000">
Upload this file: <input name="userfile" type="file">
<input type="submit" value="Send File">
</form>

</body>
</html>

Thanks...........................

nemonoman

it's this:

$upfile = "\uploads\".$userfile_name;

your \" is the problem: it's how you note to print a " in a string where you use quotes: and since it isn't an end quote, it leaves the string unclosed -- everything that follows is part of the string down to 'line 11'.

What you meant to say was

"\uploads\".$userfile_name;

but it would be easier and more maintainable to say:

"\uploads\$userfile_name";

Bret

Yes. Thank you. You deffinitely gave me the right idea but your solution didnt fully solve my problem. Here's the script that finally worked....

$userfile = $HTTP_POST_FILES['userfile']['tmp_name'];
$userfile_name = $HTTP_POST_FILES['userfile']['name'];

$upfile = "C:\Inetpub\wwwroot\test\uploads\$userfile_name";
copy ($userfile, $upfile);

For some reason it wouldnt work when I didnt specify the full path and I had to double slash everything since PHP tries to evaluate everything in quotes.

nemonoman

DOH!

I would have figured out about the \ of your final version -- if I'd run the code!

Lucky for me I'm using *ix style paths, with / instead of \, or I'd go nuts trying to debug my code!

Glad you at least got pointed in the right direction.