edit post

[Dillenger]

Can anyone tell me what is wrong with this script???

I've been trying for hours, but just can't seem to get it to work.

		  <form action="title.php" method="post">
              <?
require('../config.inc');
// connect to database
$cid = mysql_connect($host,$usr,$passwd);
$select_db = mysql_select_db($db);

// processed when form is submitted back onto itself
if ($REQUEST_METHOD=="POST") {	

// setup SQL statement
$SQL = " UPDATE title SET";
$SQL = $SQL . " page_name = '$page_name', ";
$SQL = $SQL . " background_url = '$background_url', ";
$SQL = $SQL . " WHERE id = '$id' ";		
// execute SQL statement
$result = mysql_db_query($db,"$SQL",$cid);		
// check for errors

	$uconfirm = "Information Updated!";


} else { 
require('../config.inc');
// connect to database
$cid = mysql_connect($host,$usr,$passwd);
$select_db = mysql_select_db($db); 

$sql = "select * from title";

$result = mysql_query($sql); 

while ($directory = mysql_fetch_array($result)) { 

    $page_name=$directory['page_name'];
	$background_url=$directory['background_url'];


  }

?>

This is the error I get when processing:
Parse error: parse error, unexpected $ in /home/dhill/simplebit-www/dillenger/bio/title.php on line 113

[cahva]

Add } in the end.

[Dillenger]

alright,

I added the } at the end, now everything works fine, except my information doesn't update when I submit, it just stays the same... any reason why?

<?
require('../config.inc');
// connect to database
$cid = mysql_connect($host,$usr,$passwd);
$select_db = mysql_select_db($db);

// processed when form is submitted back onto itself
if ($REQUEST_METHOD=="POST") {    

// setup SQL statement
$SQL = " UPDATE title SET";
$SQL = $SQL . " page_name = '$page_name', ";
$SQL = $SQL . " background_url = '$background_url', ";
$SQL = $SQL . " WHERE id = '$id' ";        
// execute SQL statement
$result = mysql_db_query($db,"$SQL",$cid);        
// check for errors

    $uconfirm = "Information Updated!";


} else { 
require('../config.inc');
// connect to database
$cid = mysql_connect($host,$usr,$passwd);
$select_db = mysql_select_db($db); 

$sql = "select * from title";

$result = mysql_query($sql); 

while ($directory = mysql_fetch_array($result)) { 

    $page_name=$directory['page_name'];
    $background_url=$directory['background_url'];


  }
  }
?>

		  <input type=hidden name="id" value="<?echo$id;?>">
<table width="100%" border="0" cellpadding="5" cellspacing="0" class="formtex">
              <tr> 
                <td>Webpage Name:</td>
                <td><input name="page_name" type="TEXT" class="formtex" value="<?echo$page_name;?>" size=40></td>
              </tr>
              <tr> 
                <td>Background Image:</td>
                <td>[url]http://[/url] 
                  <input name="background_url" type="TEXT" class="formtex" value="<?echo$background_url;?>" size=32></td>
              </tr>
            </table>

        <br>
        <br>
<input name="submit" type="Submit" class="formtex" value="Enter information">
</form>
<?
if ($REQUEST_METHOD=="POST") {
    echo ("$uconfirm\n");
}
?>

[cahva]

Maybe you have globals turned off. Use $POST['variable'] in your update query.

// setup SQL statement
    $SQL = " UPDATE title SET";
    $SQL = $SQL . " page_name = '".$_POST['page_name']."', ";
    $SQL = $SQL . " background_url = '".$_POST['background_url']."', ";
    $SQL = $SQL . " WHERE id = '".$_POST['id']."' ";        

[Dillenger]

nope,

I changed them and its still doing the exact same thing 🙁

[cahva]

Either you have something wrong in the update-query. Or the form is not submitting right.

Print $SQL to see if the values are in place. If they are, then its your insert-query that has something wrong.

[planetsim]

Unless your using SELECT in you query you do not need a variable

try this
mysql_query($SQL);

dont make it a db_query

[cahva]

Yeah, that is the reason why it doesnt work. I didnt notice that earlier. But to be more specific, change

// execute SQL statement
    $result = mysql_db_query($db,"$SQL",$cid);

To:

// execute SQL statement
mysql_query($SQL);