Only bringing back 1 post! why?

[evo4ever]

Hi. I've just written a script enabling me to post news on my news page. One problem tho! When I posted first time it worked fine, but my second post wont display? it gets into the database successfully but its not getting to the news page! why? My code:

news page:

<?php echo '<font face="Palatino Linotype" size="2"> ' . $a_row['postDate'] . '</font>' ?>
<?php echo '<font face="Palatino Linotype size="2"> ' . $a_row['postedBy'] . '</font>'; ?>
?php echo '<font face="Palatino Linotype" size="2"> ' . $a_row['postSubject'] . '</font>'; ?>
<?php echo '<font face="Palatino Linotype" size="2"> ' . $a_row["posttext"] . '</font>'; ?>
<?php echo '<font face="Palatino Linotype" size="2"> ' . $a_row["postRule"] . '</font>'; ?>

create post page:

<?php

if($Submit=="Post News"){
	$error = verify_data($HTTP_POST_VARS);
	if ($error == "")
		$success = "News Posted Successfully!";
}									
?>
<?php
function verify_data($formdata) {

$error = "";
$form_data = trim_data($formdata);
$user = $form_data['posttext'];


if (!check_form($form_data)) {
	$error="All Form Fields must be filled in";
	return($error); }


data into table
	$insert_check = insert_data($formdata);


error
	if ($insert_check != "true") 
		return($insert_check);

inserted successfully	
return("");			
}

function insert_data($formdata) {

$error = "";
$myhost = "localhost";
$myuser = "subastic";
$mypass = "pass";
$mydb = "evostation_com_2";


$postDate = $formdata['postDate'];
$postSubject = $formdata['postSubject'];
$postedBy = $formdata['postedBy'];
$posttext = $formdata['posttext'];
$postRule = $formdata['postRule'];


$mysql = mysql_connect($myhost, $myuser, $mypass);
if (!$mysql) {
	$error = "Cannot connect to mySQL server";
	return($error);
	}

$mysqldb = mysql_select_db($mydb, $mysql);
if (!$mysqldb) {
	$error = "Cannot open Database";
	return($error);
	}

$myquery = "INSERT INTO es_news_posts ( PostDate, postSubject, postedBy, posttext, postRule) VALUES ('$postDate', '$postSubject', '$postedBy', '$posttext', '$postRule')";			
$result = mysql_query($myquery, $mysql);
if (!$result) {
	$error = "Cannot run Query";
	return $error;
	}

return("true");	
}	
?>

I have an include file for that (obviously). Whats going wrong? thx.

[jesus_hairdo]

As the news is getting into the database properly there is nothing wrong with the posting PHP. The problem lies with how its being displayed.

What is the sql you are using to retrieve the news articles ??

Is the news page section contained within a

 
while ($a_row = mysql_fetch_array($result)
{
   ... echo statements
}

// $result is something like $result = mysql_query($sql);

loop ???

[evo4ever]

no. this...

<?php echo '<font face="Palatino Linotype" size="2"> ' . $a_row['name'] . '</font>' ?>

[evo4ever]

lol sorry, this....

$query = mysql_query("SELECT * FROM es_news_posts");
$a_row = mysql_fetch_array($query);

[jesus_hairdo]

What you need to do then is change

$query = mysql_query("SELECT * FROM es_news_posts");
$a_row = mysql_fetch_array($query);
//echo statements

into

while ($a_row = mysql_fetch_array($query))
{
     ?>
<font face="Palatino Linotype" size="2"><?= $a_row[postDate]?></font>
<font face="Palatino Linotype" size="2"><?= $a_row[postedBy]?></font>
<font face="Palatino Linotype" size="2"><?= $a_row[postSubject]?></font>
<font face="Palatino Linotype" size="2"><?=$a_row[posttext]?></font>
<font face="Palatino Linotype" size="2"><?=$a_row[postRule]?></font>
    <?
}

[Weedpacket]

Originally posted by evo4ever
lol sorry, this....

$query = mysql_query("SELECT * FROM es_news_posts");
$a_row = mysql_fetch_array($query);

[/B]

Well, the $a_row line (and the code to actually display the news) will have to be in a loop, otherwise it will only look at the first record and that will be the end of it.

[evo4ever]

Originally posted by jesus_hairdo
What you need to do then is change

$query = mysql_query("SELECT * FROM es_news_posts");
$a_row = mysql_fetch_array($query);
//echo statements

into

while ($a_row = mysql_fetch_array($query))
{
     ?>
<font face="Palatino Linotype" size="2"><?= $a_row[postDate]?></font>
<font face="Palatino Linotype" size="2"><?= $a_row[postedBy]?></font>
<font face="Palatino Linotype" size="2"><?= $a_row[postSubject]?></font>
<font face="Palatino Linotype" size="2"><?=$a_row[posttext]?></font>
<font face="Palatino Linotype" size="2"><?=$a_row[postRule]?></font>
    <?
}

[/B]

didnt work. first it started with a load of parse errors, coz u typed it up rather dirty. I cleaned it up, got rid of the errors and nothing... no news.

[jesus_hairdo]

The code i posted looks clean to me, where were the parse errors and what have you change it to ??

[evo4ever]

for a start u had "=" connected to the starting php delimator.. looking like this: "<?=" that is a clear error. Secondly you never quoted the $a_row values!

[jesus_hairdo]

the tag <?=$var?> is short hand for <? echo $var?>

and where do the $a_row variables need quoting ??

Oh and you should have the

$query=mysql_query("select * from es_news");

line before the while loop, i just realised i missed it off.

[jesus_hairdo]

If it still doesn't work with these modifications, post your whole news script for me to look at.

[dalecosp]

Originally posted by jesus_hairdo
the tag <?=$var?> is short hand for <? echo $var?>

It's possible that this is turned off in his config, isn't it? Although it shouldn't be, IMO.....

Also, the manual is now telling us that $foo[bar] is wrong, (although it does work) and we should always use $foo['bar'] instead....

[evo4ever]

Ok...

the news page's code:

<?php
  $dbhost = "localhost";
  $dbuser = "user";
  $dbpassword = "pass";
  $db = "evostation_com_2";

@mysql_connect($dbhost, $dbuser, $dbpassword) or DIE("Couldn't Connect to MySQL Database");
@mysql_select_db($db) or DIE("Couldn't Select Database");

$query = mysql_query("SELECT * FROM es_news_posts");
$a_row = mysql_fetch_array($query);
?>
<html>
<head>

Note that its above the html tag.

[evo4ever]

Doesnt matter now. I got it working! One problem tho! its TOTALLY screwed up the page!!!! have a look: www.evostation.com/view.php?PAGEID=default

[Weedpacket]

Originally posted by dalecosp
Also, the manual is now telling us that $foo[bar] is wrong, (although it does work) and we should always use $foo['bar'] instead....

Actually, it's been saying that for quite a while (and explaining why, too).

As for <?=.... if short-tags is turned on so that <? is valid, <?= is valid too. (Nah, I prefer to have it turned off.)

If short tags is turned off, then the <? stuff ?> won't be interpreted, and instead just sent to the browser. Of course, because it's wrapped in < >, the browser would probably treat it as an unknown tag and not display any of it - it would still be visible in the HTML source. I think...

Oh, and evo4ever: you don't want that $a_row line before your <html> - you'll just end up not displaying the first row in your table if you leave it there.

Really, jesus_hairdo has pretty much done it for you here (stylistic idiosyncracies notwithstanding).

[jesus_hairdo]

OK, try this.

<?php
  $dbhost = "localhost";
  $dbuser = "user";
  $dbpassword = "pass";
  $db = "evostation_com_2";

@mysql_connect($dbhost, $dbuser, $dbpassword) or DIE("Couldn't Connect to MySQL Database");
@mysql_select_db($db) or DIE("Couldn't Select Database");

$query = mysql_query("SELECT * FROM es_news_posts") or die(mysql_error())
?>
<html>
<head>
//insert head here
</head>
<body>
<!-- insert all body code that should appear before the news headlines here -->
<?
while ($a_row = mysql_fetch_array($query))
{
     ?>
<font face="Palatino Linotype" size="2"><? echo $a_row[postDate];?></font>
<font face="Palatino Linotype" size="2"><? echo $a_row[postedBy];?></font>
<font face="Palatino Linotype" size="2"><? echo $a_row[postSubject];?></font>
<font face="Palatino Linotype" size="2"><? echo $a_row[posttext];?></font>
<font face="Palatino Linotype" size="2"><? echo$a_row[postRule];?></font>
    <?
}
?>
<!-- insert any content after the headlines here -->
</body>
</html>

Jamie

[Scott_J]

You should need it like this

<?php
  $dbhost = "localhost";
  $dbuser = "user";
  $dbpassword = "pass";
  $db = "evostation_com_2";

@mysql_connect($dbhost, $dbuser, $dbpassword) or DIE("Couldn't Connect to MySQL Database");
@mysql_select_db($db) or DIE("Couldn't Select Database");

$result = mysql_query("SELECT * FROM es_news_posts");

?>
<html>
<head></head>
<body>
<h1>News Page</h1>

<?php

while ($a_row = mysql_fetch_array($result))
{
     ?>
<font face="Palatino Linotype" size="2"><?= $a_row["postDate"]?></font>
<font face="Palatino Linotype" size="2"><?= $a_row["postedBy"]?></font>
<font face="Palatino Linotype" size="2"><?= $a_row["postSubject"]?></font>
<font face="Palatino Linotype" size="2"><?=$a_row["posttext"]?></font>
<font face="Palatino Linotype" size="2"><?=$a_row["postRule"]?></font>
    <?
}

?>

</body>
</html>

[Scott_J]

lol - I was in the middle of that when you've posted yours. They are the same anyway.

[evo4ever]

It's all working like a dream now guys! thx for the help! I'd like to know something else aswel, how can I make newer posts to appear at the top of the page? cos when I post it appears below the older posts.

PS: BTW James.... your hosting is set up.

[jamie_kerwick]

to order the posts by newest date, you would alter the SQL, to read

$query=mysql_query("SELECT * FROM es_news_posts ORDER BY postDate DESC")

That orders the records by the postDate DESCending in value, so it starts with the most recent and works backwards.

And if you wanted only the last 4 posts, you would add, "LIMIT 0,4" to the end.

Jamie

PS. thanks for the hosting setup, i haven't received an email yet tho 🙁