Problem with a function's code

johnie

Hi. I have the following function which despite the fact that it works ok it returns me some errors in the log file which i have to fix.

function DisplayTemplate($templatefile, $vars) {

$line=implode(file($templatefile), "");
eval( "global $vars;");
$vars = str_replace(",","",$vars);
$var_list = explode("\$",$vars);
$i=0;
while($i<=sizeof($var_list)) {
$line = str_replace("<%$var_list[$i]%>",$$var_list[$i],$line);
$i++;
}
print $line;
}

The log file returns more than 10 errors per reload about :
Undefined offset: 4 in ..
Undefined offset: 3 in ..
Undefined variable: in .. (it doesn't say which variable)

All the errors is about the red line

I can't figure out what's wrong so i'd appreciate any help.

Thanks
John

128kb_com

The problem is with the line:

$line=implode(file($templatefile), "");

which should be:
$line=implode( "", file($templatefile));

What you have is taking the empty string "" and trying to concatenate it with the contents of file($templatefile), which is an array.

The first argument to implode/COLOR is the string to concatenate with, you have it in reverse. Thats why $line = str_replace.... produces errors because $line is not what you think it is.

the_Igel

Not sure, but try
${$var_list[$i]}

johnie

128kb.com i tried and i still get the same errors in the log file.
The problem (i guess) is somewhere in

$line = str_replace("<%$var_list[$i]%>",$$var_list[$i],$line);

and the way i should escape some variables.

The ${$..} way also doesn't work.

Weedpacket

$vars = str_replace(",","",$vars);
$var_list = explode("\$",$vars);
for($i=0; $i<count($var_list); $i++) {
$line = str_replace("<%$var_list[$i]%>",$$var_list[$i],$line);
}
print $line;
}

One problem would probably be that your previous loop ran off the end of the $var_list array - off into to realm of undefined offsets and undefined variables.