recursive file list

[klansman]

hi everyone!

i am not sure whether this should be here or in the newbies section... whatever.

i am trying to make a recursive file list, using a recursive function, but i'm not getting any success... seems like the script hangs in some kind of infinite loop. i have a stop-condition to stop the recursion... but the program seems to ignore it... here is the code:

<?php

function recurse_test($directory)
{

echo "--> scanning: ".$directory."\n";

$dir=opendir($directory);

if(!$dir)
{
    echo "# opendir not ok\n";
    return false;
}

while(($file=readdir($dir))!=false)
{
    $temp=$directory."/".$file;
    if(!strcmp($file,".") || !strcmp($file,".."))
    {
        // no go folder
        echo "F ".$temp."\n";
        continue;
    }

    if(is_dir($temp))
    {
        echo "F ".$temp."\n";
        recurse_test($temp);
    }
    else
      echo $temp."\n";
}
closedir($dir);
return true;

}

echo "<pre>\n";

$base_dir="/home/klansman";
$base_dir=rtrim($base_dir,"/");
recurse_test($base_dir);

echo "</pre>\n";

?>

could anyone give me a hint on what's wrong?

thank you much in advance! :-)

[]

[klansman]

i got it.

the continue inside the while loop did not stop the recursion function to test the "." and ".." directories, thus resulting in an infinite loop recursing in "."

thanks anyway!

[]

[klansman]

i am kind of lost again... i got it working, using a modified if: i used

_if(is_dir($temp) && (!strcmp($file,".") || !strcmp($file,"..")))

instead of

_if(is_dir($temp))

and it worked.

i thought that the continue was not doing what i wanted it to do, so i removed it.

surprise!! it doesn't work again!!

why the hell is this happening??

1. the continue was useless, so i include that comparison directly in the recursion-stop-clause
2. it now works
3. i remove the continue
4. it doesn't work

why must i compare the $file twice? why is not the continue jumping to the next step in the while loop?

[]

[128kb_com]

strcmp/COLOR; returns 0 if str1 and str2 are equal, so if you use it in an if statement it will return false.

I have a recursive ls function and to check for . and .. I just use

if ($file == '.' || $file == '..') continue;

[klansman]

i agree. that's why i don't use strcmp(). instead i use !strcmp, which returns true if $file and "." match.

[]

[diego25]

But I've never seen anyone use strcmp when you could have just used ==. It's easier to understand, in my opinion.

Try this:

function recurse_test($directory) {
    echo "--> scanning: ".$directory."\n";

$dir=opendir($directory);

if(!$dir) {
    echo "# opendir not ok\n";
    return false;
}

 while(($file=readdir($dir))!==false) {

    $temp=$directory."/".$file;

    if($file == '.' || $file == '..') {
        // no go folder
        echo "F ".$temp."\n";
    } else if(is_dir($temp)) {
        echo "F ".$temp."\n";
        recurse_test($temp);
    } else {
        echo $temp."\n";
    }
}

closedir($dir);
return true;
}

Diego

[klansman]

thankx diego.

i got it working now.

really, i don't know why i insist on using strcmp instead of '=='... C-programming habbits, i guess.

thanks anyway!

[]