idea what I'm doing wrong?

[Henri]

I made this code: (see end of post)

when I check, the database has'nt been updated. the 2 files weren't uploaded and the count.php file was not updated.

thanx a lot for any help.

switch ($action) {
default:

echo "
<form method=\"post\" action=\"wallpaper.php?action=add\" enctype=\"multipart/form-data\">
<center><b>Upload a wallpaper</b></center><p>
<input type=\"file\" name=\"wallpaper\" size=\"20\"> - Wallpaper<p>
<input type=\"file\" name=\"wallpaper_small\" size=\"20\"> - 80x80 Wallpaper Preview<p>
<button type=\"submit\" name=\"submit\">Add Wallpaper</button> 
</form>";

break;

case add:

$abpath = "../images/wallpaper"; //Absolute path to where wallpaper is uploaded.

$log = "";

//checks if file exists
if ($wallpaper_name == "" && $wallpaper_small_name == "") {
$log .= "No file was selected<br>";
}

if ($wallpaper_name != "" && $wallpaper_small_name != "") {

include("../scripts/mysql_connect.php");
$number = mysql_query("", $linkid);




$image_file = "../images/wallpaper/count.php";

$image_number_line = file($image_file);

$image_number_line[0]++;

$FP = fopen("../images/wallpaper/count.php", "w");
fputs($FP, "$image_number_line[0]");
fclose($FP);
$wallpaper_name = $image_number_line[0] . ".jpg";  

$wallpaper_small_name = $image_number_line[0] . "_small" . ".jpg";  

@copy($wallpaper, "$abpath/$wallpaper_name") or $log .= "Couldn't copy the wallpaper to the server<br>";
@copy($wallpaper_small, "$abpath/$wallpaper_small_name") or $log .= "Couldn't copy the wallpaper preview to the server<br>";
}

if (file_exists("$abpath/$wallpaper_name")) {

$content = "<a target=\"_blank\" href=\"images/wallpaper/$wallpaper_name\"><img border=\"0\" class=\"opacity_70\" onmouseover=\"this.className='opacity_100'\" onmouseout=\"this.className='opacity_70'\" src=\"images/wallpaper/$wallpaper_small_name\"></a>";

include("../_scripts/mysql_connect.php");
mysql_query("INSERT INTO RPGI_wallpaper (link) VALUES ('$content')", $linkid);

$log .= "The wallpaper was successfully uploaded<br>";
}

echo "$log";

break;
}

anf I get this as an awnser:

No file was selected
The wallpaper was successfully uploaded

[tomhath]

Your form has the fields "wallpaper" and "wallpaper_small" but your php code is using "$wallpaper_name" and "$wallpaper_small_name".

<input type=\"file\" name=\"wallpaper\" size=\"20\"> - Wallpaper<p>
<input type=\"file\" name=\"wallpaper_small\" size=\"20\"> - 80x80 Wallpaper Preview<p>
...
if ($wallpaper_name == "" && $wallpaper_small_name == "") {

[Henri]

I changed it but it still does'nt work😕 anyways, $wallpaper_name is automatically set when the form is processed.

any other idea about what's wrong?

by the way, can someone tell me if they can access this page?

http://membres.lycos.fr/ffn3t/RPGI/staff/wallpaper.php

[Henri]

anyone? I really would like some help🙁

[Weedpacket]

Well, I generally use $FILES and the {move|is}uploaded_file() functions, myself... using registered_globals and $field_name etc. is seriously deprecated.

You've got two tests:

if ($wallpaper_name == "" && $wallpaper_small_name == "")
if ($wallpaper_name != "" && $wallpaper_small_name != "")

Now I suspect that one of them is wrong (that the && should be a ||), because neither would succeed if one file name is set but not the other.

PS: ../images/wallpaper is not an absolute path; and you really should get in the habit of putting quotes around your strings.

And what about the database? Was anything uploaded? You don't even say if you tried to upload something or left the fields blank when you got that response (or is it the same either way)?

I presume the line
$number = mysql_query("", $linkid);
can be dropped, since you've switched to using a text file. I can't see why; what does that give you that "SELECT count(*) from RPGI_wallpaper" doesn't?