Need help with a edit page that would show all records in db (editable).

wreed

I want to show all my records on one page and be able to edit numerous ones all at one time....here is my code right now showing my one at a time code, but this is useless as I have 30 entries and I want to show all at once....help. Config file is where my connection info is...any suggestions...I know this code is not tight, but anything will help now! Out put is like this....

http://208.221.239.73/islanders/powerrankings/index.php

<?php
include("config.php");

if(!empty($team)) {
$team = addslashes($team);
$teamabbr = addslashes($teamabbr);
$rank = addslashes($rank);
$prank = addslashes($prank);
$record = addslashes($record);
$comment = addslashes($comment);

$sql = "UPDATE powerrankings SET team='$team', teamabbr='$teamabbr', rank='$rank', 
prank='$prank', record='$record', 
comment='$comment' WHERE ID='$id'";
$query = mysql_query($sql) or 
die("Cannot query the database.
<br>" . mysql_error());

echo "Database Updated. <br><a href=../powerrankings/index.php>
Power Rankings</a><br>
<a href=test.php?id=$pr>Next Rank $pr</a>";
} else {

$sql = "SELECT * FROM powerrankings WHERE ID='$id'";
$query = mysql_query($sql) or die("Cannot query the database.<br>" . mysql_error());
$result = mysql_fetch_array($query);
$team = stripslashes($result["team"]);
$teamabbr = stripslashes($result["teamabbr"]);
$rank = stripslashes($result["rank"]);
$prank = stripslashes($result["prank"]);
$record = stripslashes($result["record"]);
$comment = stripslashes($result["comment"]);
?>

<img src="../images/<?php echo $teamabbr; ?>.gif">

<form name="powerrankings" method="post" action="<?php echo $PHP_SELF; ?>">

<table border=1 cellpadding=0 cellspacing=1>
<tr>
<td>Team 
</td>
<td>Team Abbreviation: 
</td>
<td>New Rank:
</td>
<td>Previous Rank:
</td>
<td>Record:
</td>
<td>Comment:
</td>
</tr>
<tr>
<td><input type="text" name="team" value="<?php echo $team; ?>">
</td>
<td>

<SELECT name="teamabbr" value="<?php echo $teamabbr; ?>">
<option selected value=<?php echo $teamabbr; ?>><?php echo $teamabbr; ?></option>
<OPTION value="ana">ana</OPTION>
<OPTION value="atl">atl</OPTION>
<OPTION value="bos">bos</OPTION>
<OPTION value="buf">buff</OPTION>
<OPTION value="cal">cal</OPTION>
<OPTION value="car">car</OPTION>
<OPTION value="chi">chi</OPTION>
<OPTION value="col">col</OPTION>
<OPTION value="clb">cob</OPTION>
<OPTION value="dal">dal</OPTION>
<OPTION value="det">det</OPTION>
<OPTION value="edm">edm</OPTION>
<OPTION value="flo">flo</OPTION>
<OPTION value="los">los</OPTION>
<OPTION value="min">min</OPTION>
<OPTION value="mon">mon</OPTION>
<OPTION value="nas">nas</OPTION>
<OPTION value="njd">njd</OPTION>
<OPTION value="nyi">nyi</OPTION>
<OPTION value="nyr">nyr</OPTION>
<OPTION value="ott">ott</OPTION>
<OPTION value="phi">phi</OPTION>
<OPTION value="pho">pho</OPTION>
<OPTION value="pit">pit</OPTION>
<OPTION value="san">san</OPTION>
<OPTION value="stl">stl</OPTION>
<OPTION value="tam">tam</OPTION>
<OPTION value="tor">tor</OPTION>
<OPTION value="van">van</OPTION>
<OPTION value="was">was</OPTION>
</SELECT>
</td>
<td> <select name="rank" size="1">
<option selected value=<?php echo $rank; ?>><?php echo $rank; ?></option>
<option value="1">1</option>
<option value="2">2</option>
<option value="3">3</option>
<option value="4">4</option>
<option value="5">5</option>
<option value="6">6</option>
<option value="7">7</option>
<option value="8">8</option>
<option value="9">9</option>
<option value="10">10</option>
<option value="11">11</option>
<option value="12">12</option>
<option value="13">13</option>
<option value="14">14</option>
<option value="15">15</option>
<option value="16">16</option>
<option value="17">17</option>
<option value="18">18</option>
<option value="19">19</option>
<option value="20">20</option>
<option value="21">21</option>
<option value="22">22</option>
<option value="23">23</option>
<option value="24">24</option>
<option value="25">25</option>
<option value="26">26</option>
<option value="27">27</option>
<option value="28">28</option>
<option value="29">29</option>
<option value="30">30</option>
</select>
</td>
<td><input type="text" name="prank" value="<?php echo $prank; ?>">
</td>
<td><input type="text" name="record" value="<?php echo $record; ?>">
</td>
<td><textarea name="comment"><?php echo $comment; ?></textarea>
</td>
</tr>
<tr>
<td colspan=6 align=right><input type="submit" name="Submit" value="Submit">
<input type="hidden" name="id" value="<?php echo $id; ?>">
</form>

<?php
$br = ($id - 1);
$pr = ($id + 1);
echo "<a href=test.php?id=$br>Back</a> | <a href=test.php?id=$pr>Next</a>";
}
?>
</td>
</tr>
</table>

planetsim

Please use [php ][/php ] without the spaces. its also not possible to edit 2 rows at the same time unless you code it the way you want. You'd need a for loop in the update

wreed

So I cant have a huge page with say all 30 items in my db to edit at one time?

I am a newbie, so the for loop is alittle confusing, do you mind going into more detail?

wreed

Could somebody help me or show me how to maybe make a loop with code for each line, and at the end of each line maybe have a submit button, so when hit it submits that row and not the whole page, so then the loop would make all 30 lines show each with there own submit button.

ahundiak

You can do this by using arrays for form inputs. Something like
<input type="text" name="team[]">
<input type="text" name="rank[]">

The [] after the field name causes php to generate an array.

$teams = $POST['team[]'];
$ranks = $POST['rank[]'];
for($i = 0; $i < count($teams); $i++) {
$team = $teams[$i];
$rank = $ranks[$i];
// Process the record
}

You have to be careful with check boxes. You only get back those elements that have actually been checked so if you have 10 records and only two are checked then you only get back two entries in the array. You have to include a record_id of some sort in the value to know which record was checked.

wreed

I am alittle confused, are you on any im programs? I need to be sort of walked through alittle bit......or email me.

ahundiak

I don't do IM at work. So I guess I'll need your email.

One mistake in my earlier post, use
$teams = $POST['team']; instead of
$teams = $POST['team[]'];

Also, my post describes how to edit multiple records with one submit button as your original post requested.

Understand that what you are trying to do in not exactly trivial. You need to know how html forms and tables work. And you need to learn about php arrays and loops. Spend some time with the manual.

wreed

heh I know HTML well, its this php thats kicking my ass....yea one submit button would work, but would it be easier to use a submit button after each line, liks say a huge table and each row (would be each instance in the table) would have a submit button which would only update that row.....is that more feasible?

wreed@riker.com

wreed

hmm maybe i can explain myself better.

I want to make a Power Rankings for NHL league I am in...online hockey.

Now what I want to do is eactly like the ESPN one.

http://sports.espn.go.com/nhl/powerranking?season=2003&week=9

So I am thinking but having a hard time laying out the table....so ok I have a semi table working.

Now I want to make a edit page for someone else to update teh rankings. now thats why I want to put it all on one page, so they dont have to go to each next page to see the next team in the list......that way they can just do it all in one page and put all the info in. Now I wanted to also do it twice a month, and if you look at the espn page it has each week....do you think this is all done in one page?

ahundiak

There is no problem at all with having a submit button for each row. And it makes the code much easier. Each time you start a new row in the table, just put out a complete form. The user can only update one record at a time but that does not sound like a problem.

wreed

Ok any suggestions for laying out the table then?

wreed

bump

ahundiak

Are you asking for help on the html side? Nothing really special, just add a complete form to each row in the table.

wreed

Its more on teh php side, I am not really great at this, i take code from a few pages and try to patch it together, but it does not always work.....I know html, its more the php thats giving me headaches.

ahundiak

Here is the code used to generate the html table. But be warned. My approach to generating html is not typical. I don't like to mix php and html code together. And I never really got comfortable with templates.

$hp->pnl($hp->table->start(1));
for($row = 1; $row < 3; $row++)
{

$hp->pnl($hp->table->rowStart());
$hp->pnl($hp->form->startPost('index.php','record' . $row));

$hp->pnl($hp->input->hidden('key',$row));

$hp->pnl($hp->table->col(
$hp->input->text('name',array(HTML_INPUT_SIZE  => 20,
                              HTML_INPUT_VALUE => 'Record ' . $row))));

$hp->pnl($hp->table->col($hp->input->submit('Update'))); 

$hp->pnl($hp->form->finish());    
$hp->pnl($hp->table->rowFinish());

}
$hp->pnl($hp->table->finish());

$hp is a class instance with assorted Html Page methods.
$hp->pnl($str) outputs the string followed by a new line character for readability.
$hp->table->start($border) returns the string <table > with an optional border flag.
$hp->table->rowStart and rowFinish returns <tr> or </tr>
$hp->table->col($str) returns $str surrounded by td tags.
$hp->form->startPost returns the form element.
$hp->input->hidden and text returns input elements.

Maybe this will give you some ideas on how to proceed.

wreed

whoa that left me in worse shape....I am clueless.

ahundiak

Sorry for the confusion. I was afraid that would happen. Your original post shows the more typical style of flipping between html and php. That style is just too difficult for me.

I would suggest trying to generate a table with only one or two columns just to get the syntax correct. Then add the rest of the columns.

wreed

Yea i have that just cant get the stupid thing to work right, here check this out

http://208.221.239.73/islanders/powerrankings/edit.php


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
	<title>Sinbin 3 Power Rankingsd</title>
</head>

<body>

<? include('../css.php'); ?>

<table border=1 cellspacing=0 cellpadding=2>
	<tr bgColor=0B64A7><td colspan=6><font face=arial size=2 color=#FFFFFF><b>Sinbin 3 Power Rankings</b></font></td></tr>
	<tr bgColor=#c1c1c1>
	<td class=verb10><b>&nbsp;</b></td>
	<td align=right class=verb10><b>Rk</b></td>
	<td align=left class=verb10><b>Team</b></td>
	<td align=left class=verb10><b>Rec.</b></td>
	<td width=250 align=left class=verb10><b>Comment</b></td>
	<td width=250 align=left class=verb10><i>Edit</i></td>
	</tr>

<?php

$connection = mysql_connect ("localhost", "username", "pass");
if ($connection == false){
  echo mysql_errno().": ".mysql_error()."<BR>";
  mysql_select_db ("islanders");
  exit;
}
If (isset($id)) 
{ 
$orderby = "ORDER BY $id "; 
} 

$query = "SELECT  *  FROM  `prankings`  ORDER  BY  `1rank`  ASC ";
$result = mysql_db_query ("islanders", $query);

if ($result){

  $numOfRows = mysql_num_rows ($result);
  for ($i = 0; $i < $numOfRows; $i++){
    $id = mysql_result ($result, $i, "id");
    $team = mysql_result ($result, $i, "team");
	$teamabbr = mysql_result ($result, $i, "teamabbr");
    $rank1 = mysql_result ($result, $i, "1rank");
    $record1 = mysql_result ($result, $i, "1record");
    $comment1 = mysql_result ($result, $i, "1comment");
    $rank2 = mysql_result ($result, $i, "2rank");
    $record2 = mysql_result ($result, $i, "2record");
    $comment2 = mysql_result ($result, $i, "2comment");
    $rank3 = mysql_result ($result, $i, "3rank");
    $record3 = mysql_result ($result, $i, "3record");
    $comment3 = mysql_result ($result, $i, "3comment");


echo "<form name='$id' method='post' action='$PHP_SELF'>
	<tr bgColor=#ffffff>
	<td align=center><img src=../images/powerrankings/$teamabbr.gif border=0 width=50 height=50>
	</td>
	<td class=verb10 align=right><nobr>

<select name='rank' size='1'>
            <option selected value=$rank1>$rank1</option>
			<option value='1'>1</option>
            <option value='2'>2</option>
            <option value='3'>3</option>
            <option value='4'>4</option>
            <option value='5'>5</option>
            <option value='6'>6</option>
            <option value='7'>7</option>
			<option value='8'>8</option>
			<option value='9'>9</option>
			<option value='10'>10</option>
			<option value='11'>11</option>
			<option value='12'>12</option>
			<option value='13'>13</option>
			<option value='14'>14</option>
			<option value='15'>15</option>
			<option value='16'>16</option>
			<option value='17'>17</option>
			<option value='18'>18</option>
			<option value='19'>19</option>
			<option value='20'>20</option>
			<option value='21'>21</option>
			<option value='22'>22</option>
			<option value='23'>23</option>
			<option value='24'>24</option>
			<option value='25'>25</option>
			<option value='26'>26</option>
			<option value='27'>27</option>
			<option value='28'>28</option>
			<option value='29'>29</option>
			<option value='30'>30</option>
		</select>

 ($rank1)</nobr>
</td>
<td class=verb10 align=left><a href=http://www.sinbin.ca/teaminfo.cfm?team=$teamabbr target=_blank>$team</a>
</td>
<td class=verb10 align=left><input type='text' name='$record1' value='$record1'>
</td>
<td class=verb10 align=left><textarea name='$comment1'>$comment1</textarea>
</td>
<td align=right><input type='submit' name='Submit' value='Submit $team Info'><input type='reset' name='Clear' value='Clear'>
<input type='hidden' name='id' value='$id'>
</form></td>
</tr>";
 }

}
else{
  echo mysql_errno().": ".mysql_error()."<BR>";
}

mysql_close ();

?>

</table>
</body>
</html>

ahundiak

Some suggestions.
Move the form element to be after the tr element i.e.
<tr>
<form ... >
<td>
<input ... />
</td>
</form>
</tr>

Right now </form> is actually inside of the last <td> element. So move it down just a bit to match the above layout.

Your input elements are not being closed. Use <input ... /> instead of <input ... >

I don't know if it really matters or not but it's usually not a good idea to start html names with a number i.e. <form name='1'> might cause some problems. So do somthing like
$formName = 'form' . $id;
<form name ='$formName'

That should clean things up a bit.

Also, just as a debugging aid, it wouldn't hurt to comment out all of the code except for one column and the submit button. Once that's working then turn on each column one at a time and retest.