Editing news posts = problems!

[evo4ever]

Hey ppl. I've just recently got my news post system working. I now want a feature were it allows me and my team to edit thier posts... incase of mistakes etc. My code is the following:

edit_news_post.php:

<?php

if($Submit=="Amend Changes"){
	$error = verify_data($HTTP_POST_VARS);
	if ($error == "")
		$success = '<font face="Palatino Linotype" size="2">News Edited Successfully!
					Go<a href="http://www.evostation.com/view.php?PAGEID=default"> Here</a></font>';

}									
?>
<?php
function verify_data($formdata) {

$error = "";
$form_data = trim_data($formdata);
$user = $form_data['posttext'];

if (!check_form($form_data)) {
	$error="All Form Fields must be filled in";
	return($error); }

$insert_check = insert_data($formdata);

if ($insert_check != "true") 
	return($insert_check);

inserted successfully	
return("");			
}

function insert_data($formdata) {

$error = "";
$myhost = "localhost";
$myuser = "user";
$mypass = "pass";
$mydb = "database";


$posttext = $formdata['posttext'];
$subject = $formdata['postSubject'];


$mysql = mysql_connect($myhost, $myuser, $mypass);
if (!$mysql) {
	$error = "Cannot connect to mySQL server";
	return($error);
	}

$mysqldb = mysql_select_db($mydb, $mysql);
if (!$mysqldb) {
	$error = "Cannot open Database";
	return($error);
	}

$myquery = "UPDATE es_news_posts SET posttext = '$posttext' WHERE subject = '$postSubject' ";			
$result = mysql_query($myquery, $mysql);
if (!$result) {
	$error = "Cannot run Query";
	return $error;
	}

return("true");	
}	
?>

Everytime I amend a change I get the "Cannot run Query" error! whats going wrong??? Thx.

[diego25]

Use the function mysql_error (http://www.php.net/manual/en/function.mysql-error.php) to see what the error is.

But just a tip, whatever you send to the database, call mysql_escape_string first on the data, to make sure it won't mess up your query (like single quotes inside your data).

Diego

[evo4ever]

I've sorted it now lol. It was a SIMPLE mistake in my script! knew id do it! lol

before:

// Variable:
 $subject = $formdata['postSubject']
// Query:
 WHERE subject = '$postSubject'

after:

// Variable: 
$postSubject = $formdata['postSubject']
// Query: 
WHERE postSubject = '$postSubject'