query and email

[[deleted]]

I've create a page that lists all new users who have not yet been approved. To approve I check a checkbox which updates the database. This works fine. The problem is that the script should also e-mail the userid and password to the newly approved user. It does not. Instead I keep getting a Bad Destination error.

Here 's the code:

This part works fine.

<?php

// generate and execute query list news
$qryListNotApprovedUsers = "SELECT ID,UserID,FullName,Email,RegistrationDate,Password
FROM tblUsers
WHERE fk_StatusID = '0'";
$rsltListNotApprovedUsers = mysql_query($qryListNotApprovedUsers) or die ("Error in query: $qryListNotApprovedUsers. " . mysql_error());

// if records present
if (mysql_num_rows($rsltListNotApprovedUsers) > 0)
{

// iterate through resultset
// print title with links to edit and delete scripts
while($ListNotApproved_row = mysql_fetch_object($rsltListNotApprovedUsers))
{

$cellcolor = ($i++ & 1) ? '#eeeeee' : '#ffffff';
{

echo
"
<table cellpadding=\"0\" cellspacing=\"0\" border=\"0\">
<input type=\"hidden\" name=\"id\" value=\"".$ListNotApproved_row->ID."\">
<tr class=\"intro\">
<td width=\"142\"height=\"19\" align=\"left\" valign=\"top\" bgcolor=\"".$cellcolor."\">".$ListNotApproved_row->UserID."</td>
<td width=\"6\" align=\"left\" valign=\"top\" bgcolor=\"".$cellcolor."\"></td>
<td width=\"182\" width=\"155\" align=\"left\" valign=\"top\" bgcolor=\"".$cellcolor."\">".$ListNotApproved_row->FullName."</td>
<td width=\"8\" align=\"left\" valign=\"top\" bgcolor=\"".$cellcolor."\"></td>
<td width=\"227\" align=\"left\" valign=\"top\" bgcolor=\"".$cellcolor."\">".$ListNotApproved_row->Email."</td>
<td width=\"4\" align=\"left\" valign=\"top\" bgcolor=\"".$cellcolor."\"></td>
<td width=\"250\" align=\"left\" valign=\"top\" bgcolor=\"".$cellcolor."\">".formatDate($ListNotApproved_row->RegistrationDate)."</td>
<td width=\"6\" align=\"left\" valign=\"top\" bgcolor=\"".$cellcolor."\"></td>
<td width=\"119\" align=\"left\" valign=\"top\" bgcolor=\"".$cellcolor."\"><input type=\"checkbox\" name=\"status\" value=\"1\"></td>

</tr>
</table>
"
;

}
}
}
?>

This part does not work.

<?PHP
else:

   // Process update

dbConnect('database');

$sql = "UPDATE tblUsers
SET fk_StatusID = '$status'
WHERE ID = '$id'";

$result = mysql_query($sql) or die ("Error in query: $sql. " . mysql_error());

if ($status == '1')
// Email the userid/password to the person.

 $message = "G'Day!

Your personal account for the Project Web Site has been created! To log in, proceed to the following address:
http://www.mydomain.com/
Your personal login ID and password are as follows:
userid: $UserID

password: $Password
You aren't stuck with this password! Your canchange it at any time after you have logged in.
If you have any problems, feel free to contact me at <[e-mail]>.
-Steve Fitzgerald
";

mail($ListNotApproved_row->Email,"Your Password for the Project Website",         
      $message, "From:Steve Fitzgerald <[e-mail]>");

     ?>

It appears that the proper e-mail is not being passed.

I could use some help.

Thanks.

[cgraz]

try

$to_email = $ListNotApproved_row->Email;
$headers = "From:Steve Fitzgerald <[e-mail]>";
$subject = "Your Password for the Project Website";

mail($to_email, $subject, $message, $headers); 

Cgraz

[[deleted]]

I made the change, but I am getting the same error.

<?PHP
else:

   // Process signup submission
dbConnect('database');

$sql = "UPDATE tblUsers
SET fk_StatusID = '$status'
WHERE ID = '$id'";

$result = mysql_query($sql) or die ("Error in query: $sql. " . mysql_error());

if ($status == '1')
// Email the new password to the person.

 $message = "G'Day!

Your personal account for the Project Web Site has been created! To log in, proceed to the following address:
http://www.mydomain.com/
Your personal login ID and password are as follows:
userid: $UserID

password: $Password
You aren't stuck with this password! Your canchange it at any time after you have logged in.
If you have any problems, feel free to contact me at <[e-mail]>.
-Steve Fitzgerald
";

$to_email = $ListNotApproved_row->Email;
$headers = "From:Steve Fitzgerald <[e-mail]>";
$subject = "Your Password for the Project Website";

mail($to_email, $subject, $message, $headers);

   ?>

[/B]

[cgraz]

What if you try changing $email to equal your email and test it rather than pulling it out of the database. This will let you know if the problem has something to do with the variable or not.

$to_email = "[e-mail]";
// maybe even try changing the headers to this
$headers = "From:Steve Fitzgerald"; 
$subject = "Your Password for the Project Website"; 

mail($to_email, $subject, $message, $headers); 

[[deleted]]

Using my e-mail address in $to_email worked. I noticed that the userid and password variables were not sent. This indicates to me that the e-mail variables was not being passed.

I'm not sure how to correct this. Any ideas?

[cgraz]

Yeah, try this.

// change your while to mysql_fetch_array
while($ListNotApproved_row = mysql_fetch_array($rsltListNotApprovedUsers)) 

// then on your mail function, call the variables like this
// (check for proper capitalization of field names)
$to_email = $ListNotApproved_row["Email"];
$headers = "From:Steve Fitzgerald <[e-mail]>"; 
$subject = "Your Password for the Project Website"; 

mail($to_email, $subject, $message, $headers); 

?> 

Note that you have to call the variables differently now: $ListNotApproved_row["field_name"];

Good luck.

[[deleted]]

Almost there. I'm getting an error:
Parse error: parse error, unexpected '\"', expecting T_STRING or T_VARIABLE or T_NUM_STRING in H:\MNS\Development\Dev.Projects\tf-dev\admin\index.php on line 169

Line 169 begins userid: $ListNotApproved_row["UserID"];

Here's the updated code.

<?PHP
else:

   // Process signup submission
dbConnect('database');

$sql = "UPDATE tblUsers
SET fk_StatusID = '$status'
WHERE ID = '$id'";

$result = mysql_query($sql) or die ("Error in query: $sql. " . mysql_error());

if ($status == '1')
// Email the new password to the person.

 $message = "G'Day!

Your personal account for the Project Web Site has been created! To log in, proceed to the following address:
http://www.theproject.com/
Your personal login ID and password are as follows:

userid: $ListNotApproved_row["UserID"];

password: $ListNotApproved_row["Password"];
You aren't stuck with this password! Your canchange it at any time after you have logged in.
If you have any problems, feel free to contact me at <[e-mail]>.
-Steve Fitzgerald
";

$to_email = $ListNotApproved_row["Email"];
$headers = "From:Steve Fitzgerald";
$subject = "Your Password for the Project Website";

mail($to_email, $subject, $message, $headers);

[/B]
?>

[cgraz]

is

userid: $ListNotApproved_row["UserID"];
password: $ListNotApproved_row["Password"];

within double quotes? If so, change it to

userid: $ListNotApproved_row['UserID'];
password: $ListNotApproved_row['Password'];

Cgraz

[[deleted]]

I'm back to getting a Bad Destination error. I put my e-mail into $to_mail and it worked, but I still did not get the UserID and Password.

$message = "G'Day!
Your personal account for the Project Web Site has been created! To log in, proceed to the following address:
http://www.theproject.com/
Your personal login ID and password are as follows:

userid: ".$ListNotApproved_row['UserID'].";

password: ".$ListNotApproved_row['Password'].";

You aren't stuck with this password! Your canchange it at any time after you have logged in.
If you have any problems, feel free to contact me at <[e-mail]>.
-Steve Fitzgerald
";

$to_email = $ListNotApproved_row['UserID'];
$headers = "From:Steve Fitzgerald";
$subject = "Your Password for the Project Website";

mail($to_email, $subject, $message, $headers);

[/B]

[cgraz]

You should just echo out the email somewhere on the page and see what it's returning.

echo "Email: ". $ListNotApproved_row['UserID'] . "";

I'm pretty sure bad destination errors are due to invalid email addresses.

[[deleted]]

Actually, I do echo the e-mail address earlier in the code and it displays the correct e-mail address.

I'm at a loss as to why this is happening.

[[deleted]]

I'm still at a loss as to why this is not working. I do not understand why the userid,password, and e-mail variables are not being passed.

At the minimum, I would like to be able to get the e-mail variable into the mail() function.

I still need help. If anyone has any ideas I would greatly appreciate some assistance.

Thanks.