Display in a correct table

[kmax]

Hello, I am displaying info from a mysql db on a web page...
I am trying to make the info go into a table with a NEW row for each new item...

Right now I have it making a new table for each new item...
and cannot get it to create a new row....

Can anyone spot the problem?

<?php

$db="products";
$link = mysql_connect("localhost") or die("Couldn't connect to MySQL");
mysql_select_db($db , $link) or die("Couldn't open $db: ".mysql_error());

$result = mysql_query("SELECT * FROM products") or die("SELECT Error: ".mysql_error());
while ($a_row=mysql_fetch_array($result))

{
print "<table width=200 border=1>\n";
print "<tr>\n";
print "\t<td><a href=details.php?id=" . $a_row["id"] . ">" . $a_row["title"] . "</a>\n</td>\n";
print "</tr>\n";
print "</table>\n";
}

?>

Thanks

[Valkrin]

The problem is this:

print "<table width=200 border=1>\n";

and this:

print "</table>\n";

Both of those lines are inside your while loop. So for each result the loop executes the above mentioned of lines, which create and close a table respectively.

Place print "<table width=200 border=1>\n"; before you start your loop and place print "</table>\n"; outside your loop. Like so:

print "<table width=200 border=1>\n";
while ($a_row=mysql_fetch_array($result))
{
print "<tr>\n";
print "\t<td><a href=details.php?id=" . $a_row["id"] . ">" . $a_row["title"] . "</a>\n</td>\n";
print "</tr>\n";
}
print "</table>\n";

That should work. Good luck.

[kmax]

Using this code...
<?php

$db="products";
$link = mysql_connect("localhost") or die("Couldn't connect to MySQL");
mysql_select_db($db , $link) or die("Couldn't open $db: ".mysql_error());

$result = mysql_query("SELECT * FROM products") or die("SELECT Error: ".mysql_error());
while ($a_row=mysql_fetch_array($result))

print "<table width=200 border=1>\n";
while ($a_row=mysql_fetch_array($result))
{
print "<tr>\n";
print "\t<td><a href=details.php?id=" . $a_row["id"] . ">" . $a_row["title"] . "</a>\n</td>\n";
print "</tr>\n";
}
print "</table>\n";

?>
Loops the table tag....
Like this....
<table width=200 border=1>
<table width=200 border=1>
<table width=200 border=1>
<table width=200 border=1>
<table width=200 border=1>
<table width=200 border=1>
<table width=200 border=1>
<tr>
<td><a href=details.php?id=></a>
</td>
</tr>
</table>

I have worked and worked with this... and just have not gotten that loop in the right place...

[Valkrin]

Okay here is the problem:

$result = mysql_query("SELECT * FROM products") or die("SELECT Error: ".mysql_error());
while ($a_row=mysql_fetch_array($result))

print "<table width=200 border=1>\n";

Above you have started a while statement correct?
Now right after the while statement you have the print line. That line is executed as long as your while statement holds true. Then you have the following line after the print statement:

while ($a_row=mysql_fetch_array($result))

Now this is the same while loop. You see the mistake? You are running the same loop twice. The first time you run the loop you run it on only the
following line:

print "<table width=200 border=1>\n";

That is why you get a loop of tables.

To correct your problem just delete the first while loop.
In the end your code should look like this:

<?php

$db="products";
$link = mysql_connect("localhost") or die("Couldn't connect to MySQL");
mysql_select_db($db , $link) or die("Couldn't open $db: ".mysql_error());

$result = mysql_query("SELECT * FROM products") or die("SELECT Error: ".mysql_error());

print "<table width=200 border=1>\n";
while ($a_row=mysql_fetch_array($result))
{
print "<tr>\n";
print "\t<td><a href=details.php?id=" . $a_row["id"] . ">" . $a_row["title"] . "</a>\n</td>\n";
print "</tr>\n";
}
print "</table>\n";

?>

[kmax]

i see what ya mean...
that one line "whilte" line was starting the loop...

thank you.