nothing recorded?????

[jonsof]

i have the following script and the problem is that nothing is recorded everytime it is executed.

<? session_start();
$user_id=$_SESSION['id'];mysql_connect("localhost");mysql_select_db("announcements_system");
$result=mysql_query("SELECT username FROM users WHERE userid=$user_id");
$user_element=mysql_fetch_assoc($result);mysql_close();

if(isset($_POST["send"])) {
mysql_connect("localhost");mysql_select_db("announcements_system");
if(isset($_POST['category'])&&isset($_POST['title'])&&isset($_POST['text'])) {


if($_FILES['file']['name']) {

$type_image=@getimagesize($_FILES['file']['tmp_name']);
if($type_image[2]){
$name=$_FILES['file']['name'];
if(is_uploaded_file($_FILES['file']['tmp_name'])) {

copy($_FILES['file']['tmp_name'], "images/".$name);
$result=mysql_query("SELECT postid FROM post ORDER BY postid DESC LIMIT 1");
$prefix=mysql_fetch_assoc($result);
$i=$prefix['postid'];
$new_prefix=++$i;

$extention=substr($name,strrpos($name,"."));
$newFileName=$new_prefix.$extention;
rename("images/$name","images/$newFileName");
unlink($_FILES['file']['tmp_name']);


}


mysql_query("INSERT INTO post VALUES ('','$user_id','".$_POST['title']."','".$_POST['category']."','".$_POST['text']."','$newFileName',now(),DATE_ADD(now(),INTERVAL 2 MONTH)");}

 else echo "You must enter an image file"; }

else mysql_query("INSERT INTO post VALUES ('','$user_id','".$_POST['title']."','".$_POST['category']."','".$_POST['text']."','',now(),DATE_ADD(now(),INTERVAL 2 MONTH)");

echo "<div align='center' valign='center'> Successfully Recorded To Database And The Post Will Be Shown In A While </div>";
} else "fill th fields"; }


mysql_close();
?>

[ElMongol]

Hi, I'm afraid you've got your INSERT syntax wrong, check out the manual page for the correct use, and options etc.

Briefly, an INSERT is thusly:

INSERT INTO tbl_name (col1, col2) VALUES ('$var1', '$var2');

Hope this helps,

M.

[edit] Use this command for better and faster uploading of files by the way!

[jonsof]

i think it's not the problem with insert be cause when you don't define the field names sql assumes that you mean all the fields and so it is in my case.

i think the problem is somewhere something else but where? 🙁

[ElMongol]

Originally posted by jonsof
i think it's not the problem with insert be cause when you don't define the field names sql assumes that you mean all the fields and so it is in my case.

Yes, this just occured to me! I'm very tired and am drinking whisky 🙂 (amazing I can still type well!)

Something tells me that it's the ' ' in the POST vars which is the problem. I vaguely recall something to do with this.

Try something like:

$foo = $_POST['foo]';
$foo2 = $_POST['foo2'];
mysql_query("INSERT INTO tbl_name VALUES ($foo, $foo2) ...

If you see what I mean? Or remove the ' ' from the $POST field names:

mysql_query("INSERT INTO post VALUES ('','$user_id','".$_POST[title]."','".$_POST[category]."',' ...

The above is slightly naughty, but works. I think! My INSERT syntax may not be right as I do mine a bit differently (as shown in an above post)

M.

[jonsof]

i tried both of your solutions you provided but nothing happened 🙁🙁🙁

For some reason the query is not execuded, but what is the reason?

[nnichols]

Try using some debug statements. Add an echo of mysql_error() after the query and see what it tells you, if anything.

[jonsof]

thank you for your reply but i fixed.

I had put in a wrong place the insert queries so the couldn't be executed.

[nnichols]

Another point (though irrelevant to your problem) -

don't use queries like this -

"SELECT postid FROM post ORDER BY postid DESC LIMIT 1"

I can hear your server crying out in pain from here. Use -

"SELECT MAX(postid) FROM post" or "SELECT MIN(postid) FROM post"

and make sure the columns is indexed properly.

[jonsof]

Then the index of the array how may looks like?

$result=query;
$prefix=mysql_fetch_assoc($result);
$i=prefix[???];

[nnichols]

You simply set the column alias in the query -

$result = mysql_query ("SELECT MAX(postid) AS postid FROM post");
$prefix=mysql_fetch_assoc($result); 
$i=prefix['postid'];

Hope this helps 😉

[jonsof]

i tried but it didn't work 🙁

[nnichols]

Might have been because of the missing '$' before prefix.
If not post again and explain what is happening, what fails etc.

$result = mysql_query ("SELECT MAX(postid) AS postid FROM post");
$prefix=mysql_fetch_assoc($result); 
$i=$prefix['postid'];