File Renaming Question

[Tony_Latino]

I have a site where the members are uploading images and such. I am trying to avoid a problem that I foresee- If MEMBER A and MEMBER B have pics on their drive that are named the SAME, then one of the files will be overwritten.

My solution to this is to have the script actually rename the file to their username, which is unique on our system. The problem is that I am not sure HOW to do this. I am recycling code found here on this site, I will put it below for you to look at. Can anyone tell me how I can accomplish this?

Get ready for BIG CODE

<?php

$my_max_file_size 	= "102400"; # in bytes
$image_max_width	= "300";
$image_max_height	= "300";
$the_path			= " /hsphere/local/home/trinity/members.trinitypa.com/UPLOADS/Personal_Pics/";

$registered_types = array(
					"application/x-gzip-compressed" 	=> ".tar.gz, .tgz",
					"application/x-zip-compressed" 		=> ".zip",
					"application/x-tar"					=> ".tar",
					"text/plain"						=> ".html, .php, .txt, .inc (etc)",
					"image/bmp" 						=> ".bmp, .ico",
					"image/gif" 						=> ".gif",
					"image/pjpeg"						=> ".jpg, .jpeg",
					"image/jpeg"						=> ".jpg, .jpeg",
					"application/x-shockwave-flash" 	=> ".swf",
					"application/msword"				=> ".doc",
					"application/vnd.ms-excel"			=> ".xls",
					"application/octet-stream"			=> ".exe, .fla (etc)"
					); # these are only a few examples, you can find many more!

$allowed_types = array("image/bmp","image/gif","image/pjpeg","image/jpeg");

# --

function form($error=false) {

global $PHP_SELF,$my_max_file_size;

if ($error) print $error . "<br><br>";

print "\n<form ENCTYPE=\"multipart/form-data\"  action=\"" . $PHP_SELF . "\" method=\"post\">";
print "\n<INPUT TYPE=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"" . $my_max_file_size . "\">";
print "\n<INPUT TYPE=\"hidden\" name=\"task\" value=\"upload\">";
print "\n<P>Upload a file";
print "\n<BR>NOTE: Max file size is " . ($my_max_file_size / 1024) . "KB";
print "\n<br><INPUT NAME=\"the_file\" TYPE=\"file\" SIZE=\"35\"><br>";
print "\n<input type=\"submit\" Value=\"Upload\">";
print "\n</form>";

} # END form

# --

if (!ereg("^4",phpversion())) {
	function in_array($needle,$haystack) { # we have this function in PHP4, so for you PHP3 people
		for ($i=0; $i < count($haystack); $i++) {
			if ($haystack[$i] == $needle) {
				return true;
			}
		}
	}
}

# --

function validate_upload($the_file) {

global $my_max_file_size, $image_max_width, $image_max_height,$allowed_types,$the_file_type,$registered_types;

$start_error = "\n<b>Error:</b>\n<ul>";

if ($the_file == "none") { # do we even have a file?

	$error .= "\n<li>You did not upload anything!</li>";

} else { # check if we are allowed to upload this file_type

	if (!in_array($the_file_type,$allowed_types)) {
		$error .= "\n<li>The file that you uploaded was of a type that is not allowed, you are only
					allowed to upload files of the type:\n<ul>";
		while ($type = current($allowed_types)) {
			$error .= "\n<li>" . $registered_types[$type] . " (" . $type . ")</li>";
			next($allowed_types);
		}
		$error .= "\n</ul>";
	}

	if (ereg("image",$the_file_type) && (in_array($the_file_type,$allowed_types))) {

		$size = GetImageSize($the_file);
		list($foo,$width,$bar,$height) = explode("\"",$size[3]);

		if ($width > $image_max_width) {
			$error .= "\n<li>Your image should be no wider than " . $image_max_width . " Pixels</li>";
		}

		if ($height > $image_max_height) {
			$error .= "\n<li>Your image should be no higher than " . $image_max_height . " Pixels</li>";
		}

	}

	if ($error) {
		$error = $start_error . $error . "\n</ul>";
		return $error;
	} else {
		return false;
	}
}
} # END validate_upload

# --


function list_files() {

global $the_path;

$handle = dir($the_path);
print "\n<b>Uploaded files:</b><br>";
while ($file = $handle->read()) {
	if (($file != ".") && ($file != "..")) {
		print "\n" . $file . "<br>";
   }
}
print "<hr>";
}

# --

function upload($the_file) {

global $the_path,$the_file_name;

$error = validate_upload($the_file);
if ($error) {
	form($error);
} else { # cool, we can continue
	if (!@copy($the_file, $the_path . "/" . $the_file_name)) {
		form("\n<b>Something barfed, check the path to and the permissions for the upload directory</b>");
	} else {
		list_files();
		form();
	}
}
} # END upload

# --

############ Start page

print "<html>\n<head>\n<title>Upload example</title>\n</head>\n<body>";

switch($task) {
	case 'upload':
		upload($the_file);
	break;
	default:
		form();
}

print "\n</body>\n</html>";

?>

[Kerry_Kobashi]

How I would do this is allocate space per user in their own directory to avoid the name clashes... this also lets you clean up the directories when a member is deleted/removed from the system. Dumping the image files all in one directory is a maintanence nightmare. I surely wouldn't want to look at a directory that has thousands of files in it.

You should be assigning a unique user identifier to each member if you setup a profile database. Why not use that same userId as a directory name?

/DocRoot/YourApp/UserId/Images

Kerry Kobashi
Kobashi Computing

[Tony_Latino]

I was not aware that php could create directories like that. How s that accomplished?

[stolzyboy]

as long as you are posting the form, and you are keeping track of the user somehow, you can use $the_file_name, like you have, once the file is submitted, once you have that, that is the whole file name without the full path, all you need to do is use an id or username like $user = "whatever from database", the when you do your copy function, and naming the file, put the $user in the filename that is being copied to the directory, this way you can easily search by the username when needed

<?
$user = "whatever from database";
else { # cool, we can continue
        if (!@copy($the_file, $the_path . "/" . $user . "_" . $the_file_name)) {
            form("\n<b>Something barfed, check the path to and the permissions for the upload directory</b>");
        } else {
            list_files();
            form();
        }

?>