Help....

cschotch

This script is supposed to list the players and (depending on whether they were in the log file or not) it will list the name and then a 1 if they were on or 0 if they were not. The script works but it always gives a 0.

<?php

function Chk_File($file) {

$fp = fopen($file,"r") or die("Failed!");  

$end_report = fread($fp, filesize($filename));

$names['Timmietie'] = 0;
$names['Hoot'] = 0;
$names['Jonesey'] = 0;

foreach(array_keys($names) as $value){ 
    $names[$value] = substr_count($end_report, $value); 
}  

foreach($names as $key=>$value) { 
    echo "$key: ";//$names[$key] <br />\n"; 
	if ($value >= '1') echo "1";
	else echo "0";
	echo '<br />';

} 
fclose($fp);  

}
echo "<TABLE>\n";
echo "     <TR>\n";
$filename = array('tuesday.txt','wednesday.txt','thursday.txt');
for($i = 0; $i < count($filename); $i++) {
     echo "          <TD>";
     Chk_File($filename[$i]);
     echo "          </TD>";
}
echo "     </TR>\n";
echo "</TABLE>\n";

?>

diego25

Try this:

if ($value >= 1

instead.

Diego

cschotch

Forgive me if I am wrong and don't understand but isnt that what I am already doing here

if ($value >= '1') echo "1";

or am I just not getting where its supposed to go?

diego25

Yours has single quotes around the 1; mine doesn't.

If you put single quotes, I think PHP will try to compare $value with the ASCII value of '1', which is 49. So your if statement ends up as
if ($value >= 49)
which will usually be false in your scenario.

Diego

cschotch

Oh I understand what you were saying now...unfortunately it doesnt change the scripts output...it still says 0 no matter if there are single quotes, double quotes, or no qoutes....
THUNK

Oh, sorry that was my head hitting the desk in frustration......
I wish it would give me an error or something just to let me know where to look at it thats not doing its job....

diego25

Could you print out $end_report, and tell us what its contents are?

Diego

cschotch

Got it now.....this

function Chk_File($file) {

$fp = fopen($file,"r") or die("Failed!");  

$end_report = fread($fp, filesize($filename));

had to be this for it to even check it...

function Chk_File($filename) {

$fp = fopen($filename,"r") or die("Failed!");  

$end_report = fread($fp, filesize($filename));

It wasn't even getting to the if/else statement because it
never opeened the file in the first place to go through it.