missing something

Harbinger

I am using this code to add to a database...

 <?PHP
	if (!$type || !$year || !$specs)
{
	echo "You have not entered all the required details.<br>"
		."Please go back and try again.";
	exit;
}

$type = addslashes($type);
$year = addslashes($year);
$specs = addslashes($specs);

@ $db = mysql_pconnect("localhost","****","****");

if (!$db)
{
	echo "Error: Could not connect to database. Please try again later.";
	exit;
}

mysql_select_db("surplus");
$query = "insert into surplus values
		('".$type."' , '".$year."' , '".$specs."')";
$result = mysql_query($query);
	if ($result)
		echo  mysql_affected_rows()." surplus added to the database.";
		?>

...but when I add a primary key (id) to the file and use the same code it doesnt work. why?

any help would be appreciated.

thanks!

scoppc

If you are adding new field, that is the PRIMARY KEY, then you should as well change your INSERT INTO statement.

I think it should be INSERT INTO tableName (field1,field2,field3,field4) VALUES ($id,'$some','$some2','$some3')

HTH.

regards,

scoppc

Harbinger

no i am not inserting a new field in the database...that is already there...

i just need to insert the value into the field.

here is the table:

+-------+--------------+------+-----+---------+----------------+
| Field | Type | Null | Key | Default | Extra |
+-------+--------------+------+-----+---------+----------------+
| type | varchar(100) | | | | |
| year | int(11) | | | 0 | |
| specs | varchar(255) | | | | |
| id | int(11) | | PRI | NULL | auto_increment |
+-------+--------------+------+-----+---------+----------------+

hand

?PHP
if (!$type || !$year || !$specs) {
    echo "You have not entered all the required details.<br>"
        ."Please go back and try again.";
    exit;
}

$type  = addslashes($type);
$year  = addslashes($year);
$specs = addslashes($specs);

@$db = mysql_pconnect("localhost","****","****");
if (!$db) {
    echo "Error: Could not connect to database. Please try again later.";
    exit;
}

mysql_select_db("surplus");
$query = "insert into surplus values('$type','$year','$specs',NULL)";
$result = mysql_query($query)
   or print "&gt;&gt;&gt; MySQL-Error: ".mysql_errno()." -&gt; ".mysql_error()."<br>\n";
if ($result) {
   echo  mysql_affected_rows()." surplus added to the database.";
}
?>

Harbinger

hand,

thanks for showing the code...could you explain to this novice why you did what you did? sorry if i am asking too much but i prefer to learn rather than have it handed to me..

thanks,

scoppc

mysql_select_db("surplus");
$query = "insert into surplus values
('".$type."' , '".$year."' , '".$specs."')";
$result = mysql_query($query);

If your code works fine without the insertion of Primary Key, umm... i dont really sure bout your problems.

Anyway, I always like to play safe. Even though to INSERT a data to a table seems just a piece of cake, but it can be problematic too.

Use the following, and it'll be okay.

mysql_select_db("surplus");
$query="INSERT INTO surplus (type,year,specs,id) VALUES('$type',$year,'$specs',$id)";
$result = mysql_query($query);

Of course, you need to ensure that the ID you are inserting should be the next id.
Good luck.

peace,

scoppc

Harbinger

trying to follow good design principles and have a primary key...otherwise my database will get fooked in a hurry. 🙂

thanks for the code peoples.

hand

I did two things:

First thing:

$query = "insert into surplus values('$type','$year','$specs',NULL)";

I added NULL as value for field "id". If NULL is defined the value increments automatically.

Alternatively you could define your insert statement without defining a, "id" value:

$query = "insert into surplus (type,year,specs) values('$type','$year','$specs')";
// or
$query = "insert into surplus (year,type,specs) values('$year','$type','$specs')";

Second thing:

$result = mysql_query($query)
   or print "&gt;&gt;&gt; MySQL-Error: ".mysql_errno()." -&gt; ".mysql_error()."<br>\n";

I added a "or print" - statement, to get some sql errors codes and messages in the case of sql some error.

Harbinger

got it, thanks!