variables and functions

[Nanoblaze]

I'm just beginning to mess with functions, and I'm redesigning my login/admin script for my website with them, instead of without ( so its cleaner, smaller, easier to tweak, etc etc etc. And I'm having a few problems, First off, the $PHP_SELF variable doesnt seem to return inside a function, and two variables i post ( through a function ) don't seem to actually get posted...Code follows, any help appreciated.

<?php

function login () {

echo "<center>Welcome to the Infrequency.net Admin page.";
echo "<br>";
echo "Please login.";
echo "<p>";
echo "<form action=$PHP_SELF method=post>";
echo "Username: <input type=username name=un>";
echo "<br>";
echo "Password:<input type=password name=pw>";
echo "<br>";
echo "<input type=submit value=Login>";
echo "</form>";
echo "</center>";

}

function checkpass () {
$db = mysql_connect("xxx", "xxx");
mysql_select_db("xxx",$db);
$resulta = mysql_query("SELECT * FROM login WHERE name=$un",$db);
$myrow = mysql_fetch_array($resulta);
$name = $myrow["name"];
$pass = $myrow["password"];
if ( $pw != $pass ) {
echo "Password Incorrect";
login();
}
if ( $pw == $pass ) {
echo "<meta http-equiv=\"refresh\" content=\"2; URL=linktoscripthere\">";
}
}
if ($un == "") {
if ($pw == "") {
login();
}
}
else {
checkpass();
}
?>

[rohithmr]

heres mah 2 cents:

1) I thought mysql_connect needs 3 arguments: the host, username and the password. Urs has only 2 args:

mysql_connect("xxx", "xxx");

2) register_globals might be off anf so u mite need to use $_SERVER['PHP_SELF'] instead of $PHP_SELF.(if that dont work try making a global declaration inthe function:

global $_SERVER['PHP_SELF'], but i dun think this step is necessary)

3) U also mite have to access the $un and $pw thru global arrays:
$POST['un'] and $POST['pw']

Tell me if dat helped

[Nanoblaze]

For the db you only need 2 if a password isnt set, insecure, but effective, since im on the server, and it has no outside access except through my firewall. 😃

using global to declare the variables inside the function appears to have worked, for everything, and using the $_POST calls as well, I wasn't aware of their existance until now, so thanks for bringing them to my attention, and much thanks for the help

[Nanoblaze]

also had an error in the db query that stopped working as of now for some reason, all is well and working 😃

thanks for the help 🙂