timeStamp Code Question?

[leon77]

Hey everyone, with the script below I am able to get the following
ouput:

  0 -->1038841200 -->Monday 02nd of December 2002 09:00:00 AM

through

2036 -->1041375600 -->Tuesday 31st of December 2002 05:00:00 PM

The script filters all business days of the month and selects timestamps every 5 minutes within the 9am-5pm work day.

Like i said it works, however, it seems to be pretty processor
intensive, and in some cases causes the browser to get stuck
in a loop. Just wondering if there is a "lighter" way to right
this so it doesnt chomp down on server time.

Any help greatly appreciated.

Thanks
leon

/* Date variables */
$currentMonth = "December";
$countDays = 31;
$start = strtotime("Sunday 1st December 2002 12:00:00 AM");
$end = strtotime("Tuesday 31st December 2002 11:59:59 PM");

/* National Holiday */
$christmas = "25";

/* 288 == number of 5 min increments in 24 hours */
$countDays = 288 * $countDays;

for ($i=0; $i<=$countDays; $i++) {
	$time = $start + 300; /* add 5 min to $start */
	$month[] = $time;
	$start = $time;

}

while (list ($key, $val) = each ($month)) {
	$monthName = date("F",  $val);
	$weekend = date("l", $val);
	$off = date("d", $val);
    $hour = date("H", $val);
	$minute = date("i", $val);
	$mod = 5; /* Set modular for minute increment */
	$second = date("s", $val);
	$after5 = date("h:i:s A", $val);

/* now to filter the timestamps */
if(
	($hour >= 9) && 
	($hour <= 17) && 
	($minute % $mod == 0) && 
	($second == 00) &&
	($after5 != "05:05:00 PM") &&
	($after5 != "05:10:00 PM") &&
	($after5 != "05:15:00 PM") &&
	($after5 != "05:20:00 PM") &&
	($after5 != "05:25:00 PM") &&
	($after5 != "05:30:00 PM") &&
	($after5 != "05:35:00 PM") &&
	($after5 != "05:40:00 PM") &&
	($after5 != "05:45:00 PM") &&
	($after5 != "05:50:00 PM") &&
	($after5 != "05:55:00 PM") &&
	($monthName == $currentMonth) &&
	($weekend != "Saturday") &&
	($weekend != "Sunday") &&
	($off != 25)
	) {

	$arrayMonth[] = "$val";
    }
}

echo "Attempting to print timestamps from arrayMonth.<br><br>\n";



while (list ($key, $val) = each ($arrayMonth)) {
		echo "$key --> $val -->";
		echo date("l dS of F Y h:i:s A", $val);
		echo "<br>\n";
		}

[bobthedog]

Ok - well - I can see your problem.... LOTS OF DUPLICATION of code and some very unnecessary calls to functions (which are pretty intensive funcs) and assignment operators.

I don't normally do this... but I have some time to spare... so lets go through your code and rewrite it to something resembling what I might have produced and see if we can't make it run a bit better. I'm not professing this is the best way to do it (being that I am still rubbing sleep from my eyes only having just got up), but I'll try me best...

$month = 12;
$year = 2002;
$day_count = date('t', mktime(0, 0, 0, $month, 1, $year));
$holiday = 25;
$arrMonth = array();

for ($day = 1; $day <= $day_count; $day++)
{
	$arrValues = getdate(mktime(12, 0, 0, $month, $day, $year));

if (($arrValues['wday'] > 0) && ($arrValues['wday'] < 6) && ($day != $holiday))
{
	$start_time = mktime(9, 0, 0, $month, $day, $year);
	$end_time = mktime(17, 0, 0, $month, $day, $year);

	for ($i = $start_time; $i <= $end_time; $i += 300)
	{
		$arrMonth[] = $i;
	}
}
}

foreach ($arrMonth as $key => $val)
{
	echo "$key --> $val -->";
	echo date("l dS of F Y h:i:s A", $val);
	echo "<br>\n";
}

Ok - several key points to note. Firstly.... you seemed to be looping through all the times for every day, even if that day was obviously a weekend or holiday. The code above does that check before we bother looping through the times for the day.

if (($arrValues['wday'] > 0) && ($arrValues['wday'] < 6) && ($day != $holiday))

An obvious enhancement to this would be to make $holiday an array of numbers with all the holidays for that month listed. You could then check whether the value existed in the array to see if it was a holiday.

Secondly, you seemed to be looping through every time for every day, even though you know you only wanted 9am till 5pm (this code could be easily modified to account for lunch breaks as well). So - we only go through timestamps for 9am - 5pm and get rid of unnecessary time scanning.

And my last major point is that you made an ENOURMOUS number of calls to the date function, when we can get all the info we require in one easy call to getdate. Then we can store this and reference it as required.

All in all, the script above runs and displays in about a second. I haven't done any actual tests for speed, but I am sure you'll find out the script time is negligable.

I'm not saying that the code above is perfect though... tbh I am not fond of all those mktime calls I put in. This could easily be changed to use one call to mktime at the top and all other calls could be changed to use some simple maths to add to this timestamp to get the next day (assuming simple facts like a day has 86400 seconds, and the number of seconds between 5pm and 9am are 57600 etc etc). This could possible speed it up some more... but I leave this for you to play with.

Hopefully the above will give you a good ground to work from.

[leon77]

gene louise christmas!

that's absolutely beautiful, I really do
appreciate you taking the time to open my eyes
on this code. i wasn't happy with the other

again, many thanks

oh and i will try to streamline a little more
with the tips you ended with

thanks,
leon