fwrite

twopeak

Hello,
When I try this code, I would like it to take an image, and copy it on my dir (like phpBB can do for avatars)
the problem is,
it does create the image file, but it seems like it never writes the data to the file!
What am I missing here?
I think somewhere I'm missing something that should be there....................(?)

<?
$domein = "http://www.sitemasters.be/";
$prentje = "sitemasters2.jpg";
ob_start();
readfile($domein . $prentje);
$extern_bestand = ob_get_contents();
ob_end_clean();
$mijn_prentjes = "/home/.sites/65/site131/web/php/upload/rommel/";
$nieuw = fopen("$mijn_prentjes$prentje","w+");
fwrite($nieuw, $extern_bestand);
fclose($nieuw);
?>

twopeak

please, I really need this!

Duey

have a look at php.net im not very good with files

twopeak

me neither,
I searched all over php.net, premade scripts, ...........
it should be correct, but it isnt 🙁

diego25

try using fread() to read the file, instead of using readfile and the output buffering functions.

Diego

twopeak

thanx for the help, but it doesn't change,
I did it once with ob, and once without, both giving same results, an empty image...

this is the last thing I tried:

<?
$domein = "http://www.sitemasters.be/";
$prentje = "sitemasters2.jpg";
$toegelaten_ext = array("gif","jpg","png");
$extensie = strtolower(substr($prentje, -3));
if (!in_array($extensie, $toegelaten_ext)) 
			exit("bestand heeft niet de juiste extensie");
ob_start();
//readfile($domein . $prentje);
fopen ("$domein$prentje", "r");
$extern_bestand = ob_get_contents();
ob_end_clean();
//$extern_bestand = 
$mijn_prentjes = "/home/.sites/65/site131/web/php/upload/rommel/";
$nieuw = fopen("$mijn_prentjes$prentje","w");
fwrite($nieuw, $extern_bestand);
echo "<img src=http://www.black-star.be/php/upload/rommel/$prentje>";
fclose($nieuw);
?>

Weedpacket

You've still got the output buffering commands in there. Like diego25 says, take those out. Just fopen() the file, fread() the whole thing into a variable, and then fwrite() it out.

See the manual for examples of these functions' usages; e.g., the user note on the [man]fread[/man] page by "mail at scherzbold dot net".

twopeak

I tried with and without
didn't change much

but I just thought of this, if I echo the content of $extern_bestand
(which is the var containing the result of $fread)
I get
"Resource id #1"

so I opened the image in Editpad, and exactly the same was written in it!

meaning the write command is correct, but there's something wrong with the read command!?

now question comes: what?

so I tried alot of things, and it still doesn't work
this is what I've got so far (I've translated the names of var to make it easy to understand

<?
$domain = "http://www.phpbuilder.com/board/images/";
$image = "go.gif";

$extern_file = fopen ("$domain$image", "r");
$externe_content =  fread ($extern_file, filesize("$domain$image"));
fclose($extern_file);

$my_dir = "/home/.sites/65/site131/web/php/upload/rommel/";

$new = fopen("$my_dir$image","w");
fwrite($new, $externe_content);
fclose($new);
?>

why is simple code so hard? :mad:

The ripper that is on the php site doesn't work for me
could it be it's something about my host?
I'm on a shared host, and I think a 2 year old tortoise knows more about server administration than this guy! 😃

Weedpacket

filesize("$domain$image"));

You can't get the filesize of a remote file as per the manual entry on [man]filesize[/man].

You say "The ripper that is on the php site doesn't work for me". - what do you mean "doesn't work"? Can't give a diagnosis without knowing the symptoms.

twopeak

I took a nap for a couple of days 🙂

it still doesn't work, but I think I got a little further...

The app dies on this:
$iets = fwrite($nieuw, $buffer) or die("nee, hier");

so the only output I get is "nee, hier"
The image is being created, but it doesn't get written to!
the content it should write, is ok!

<?
$mydir = "/home/.sites/65/site131/web/php/upload/rommel/";
$domein = "http://www.sitemasters.be/fotos/";
$prentje = "sitemasters.jpg";
if (file_exists($mydir.$prentje)) unlink($mijn_prentjes.$prentje);

$fd = fopen ($domein.$prentje, "r");
while (!feof ($fd)) {
    $externe_content .= fgets($fd, 4096);
}
fclose ($fd);


$nieuw = fopen($mydir.$prentje,"wb") or die ("hier");
$iets = fwrite($nieuw, $externe_content) or die("nee, hier");
?>

I've tried chmodding the file to 777 after creating it, but before writing to it, doesn't help

isn't there a way to get the error like I can use mysql_error()?
because if I do'nt do the die() after the fwrite() it will just act as if everything is normal!

suntra

I tried this and it worked perfectly :

<?
$domaine = "http://www.sitemasters.be/";
$fch = "sitemasters2.jpg";
$contenu = file($domaine . $fch);
$contenu = implode("", $contenu);
$rep = "./images/test_phpb12php3_";
$fp = fopen($rep . $fch,"wb+");
fwrite($fp, $contenu);
fclose($fp);
?>

Are you on Windows ? If yes, I think your error is that you forgot to write the file using the binary option... (wb+)

twopeak

I'm on a cobalt server, unix

I tried using the binary flag...same result!

is there some option in Apache that might prevent doing this?
Because I'm on a cheap shared host, that is STUPID as hell, he has the standard install he got when buying the pack...
I sent him the question, and he replied he didn't know anything about apache......

If I add or die("here's an error"); after the fwrite(); line, I get as output "here's an error"!
after that I have added
error_reporting(E_ALL);
on top of the script, and remove the die thing
and then I recieved no errors!

I'm completely flipping on this stupid code 🙁

twopeak

just hypotetically....
inside the image file, there is alot of garbage, showing that something gets written to the file

could it be that the function that takes the information of the original file, does not take the last parts of information, and so the image file is incomplete, and so my browser does not recognize this as a valid image file?

if yes, how can I prevent this?

Weedpacket

If you've got some sort of binary file viewer you can compare the image file with what's getting saved to see if they have anything in common.

I'd suggest that you use fread() instead of fgets(); I'm not confident this will fix the problem but will improve performance.

How well does suntra's code (using implode() on an array created by file()) work for you?

twopeak

it takes very long time to load, and then, it gives me permission problems!
I have been chmodding all to 777 to avoid problems

but no solution
checking the path... everything ok
rewriting it ..... still errors

after a while and alot of rewrites, it won't give me any errors anymore!
it also doesn't create the imagefile anymore 🙁

I think I'm giving up, and accuse my host! 😃