simple mail function with attachments

rul

FIRST, I GOT THIS FORM:

AND THEN THIS SCRIPT IN THE SEND_MAIL.PHP PAGE:

<?
function sendmsg($to, $subject, $text, $from, $file, $type) {
$content = fread(fopen($file,"r"),filesize($file));
$content = chunk_split(base64_encode($content));
$uid = strtoupper(md5(uniqid(time())));
$name = basename($file);

$header = "From: $from\nReply-To: $from\n";
$header .= "MIME-Version: 1.0\n";
$header .= "Content-Type: multipart/mixed; boundary=$uid\n";

$header .= "--$uid\n";
$header .= "Content-Type: text/plain\n";
$header .= "Content-Transfer-Encoding: 8bit\n\n";
$header .= "$text\n";

$header .= "--$uid\n";
$header .= "Content-Type: $type; name=\"$name\"\n";

$header .= "Content-Transfer-Encoding: base64\n";
$header .= "Content-Disposition: attachment; filename=\"$name\"\n\n";
$header .= "$content\n";

$header .= "--$uid--";

mail($to, $subject, "", $header);

return true;

}

sendmsg($to, "any subject", $msg, "from sombedy", $filename, $filename_type);
?>

HERE IS THE PROBLEM, THIS WORKS BUT ATTACHMENTS ARRIVES WITH RARE NAMES BUT KEEPING ITS FORMAT, I MEAN: I SEND A JPG FOR EXAMPLE (PIC.JPG) IT ARRIVES LIKE AN ATTACHMENT BUT IT ARRIVES NAMED WITH phpGYIxDb OR phpmY8C4r FOR EXAMPLE, BUT THEN IF I SAVE THE FILE AND GIVE IT A NAME AND CORRECT ITS EXTENSION IT WORKS

IT IS LIKE THE ATTACHMENTS ARRIVES WITH ITS NAME CHANGED

WHAT COULD BE HAPPENING???

Weedpacket

For Ralf's sake would you please stop shouting??? Some of us are having to deal with hangovers.

The answer to your question is simple: you're using the temporary name that PHP gives its uploaded files (which it has to do to stop them overwriting each other in the server), not the name it was uploaded with. Check back with the manual to see which file name variable you should be using.

rul

Originally posted by Weedpacket
For Ralf's sake would you please stop shouting??? Some of us are having to deal with hangovers.

The answer to your question is simple: you're using the temporary name that PHP gives its uploaded files (which it has to do to stop them overwriting each other in the server), not the name it was uploaded with. Check back with the manual to see which file name variable you should be using.

i dont understand...

diego25

Basically, what happens if 2 users are using your upload feature and both of them wants to upload pic.jpg? One of the e-mail receivers will receive the wrong file if both users upload using the name pic.jpg. So, to avoid this, PHP stores the uploaded file with temporary filenames. So that even if 2 users upload pic.jpg, they'll have different filenames on the server and they won't conflict with each other.

Diego

rul

but the attached file shouldnt arrive with the temp filename, it should arrive with the original one

diego25

That's because you used the wrong variable. You use the variable that had the temporary filename, and that's what we've been trying to tell you 🙂 So, NOW, go to the manual and find which variable you should be using. HINT: It's in the "Handling File Uploads" section.

Diego

rul

i understand it just a bit
what variable should i use?

is something here?

http://www.php.net/manual/en/index.php/es/features.file-upload.php

http://www.zend.com/manual/features.file-upload.php

diego25

It's in the second URL.

Diego

rul

i have this directive in my php configuration

upload_tmp_dir -> no value

is it bad?

diego25

No, it's not bad.

Just read the second URL that you posted. Read the whole page.

Diego

rul

i read it, but i dont get it

i'm sorry but i have to finish this to get paid for my work
can you help me? step by step?

rul

i made this modification but it still doesnt work

$filename=$HTTP_POST_FILES['filename'];
$filename_type=$HTTP_POST_FILES['filename']['type'];
sendmsg($to, "Contacto desde FlirtMonopol", $msg, "FlirtMonopol", $filename, $filename_type);

it tells me:
Warning: Unable to access Array in /www/flirtmonopol.com/send_mail.php on line 3

Warning: fopen("Array", "r") - No such file or directory in /www/flirtmonopol.com/send_mail.php on line 3

Warning: stat failed for Array (errno=2 - No such file or directory) in /www/flirtmonopol.com/send_mail.php on line 3

Warning: fread(): supplied argument is not a valid File-Handle resource in /www/flirtmonopol.com/send_mail.php on line 3

Warning: basename() expects parameter 1 to be string, array given in /www/flirtmonopol.com/send_mail.php on line 6

diego25

Ok, now that you've shown that you read the page, I'm gonna help you more 🙂

You're gonna need 2 $filenames. One for the fopen to read the correct file, and the other so that the client will have the correct name. So you'll need to add one more parameter to your function.

The real filename is in $HTTP_POST_FILES['filename']['name']
and
the temporary filename is in
$HTTP_POST_FILES['filename']['tmp_name']

You'll need to use both. The temporary filename will go with fopen(), and the real filename will go in the mail header.

Diego

dalecosp

Originally posted by Weedpacket
For Ralf's sake would you please stop shouting??? Some of us are having to deal with hangovers.

Originally posted by rul
I don't understand

I don't either, Weedpacket. Who's Ralf? 🙂

rul

thank you guys, really
i made it work but i didnt use the global variables, i made

<?php
function sendmsg($to, $subject, $text, $from, $file, $type, $name) {
$content = fread(fopen($file,"r"),filesize($file));
$content = chunk_split(base64_encode($content));
$uid = strtoupper(md5(uniqid(time())));

$header = "From: $from\nReply-To: $from\n";
$header .= "MIME-Version: 1.0\n";
$header .= "Content-Type: multipart/mixed; boundary=$uid\n";

$header .= "--$uid\n";
$header .= "Content-Type: text/plain\n";
$header .= "Content-Transfer-Encoding: 8bit\n\n";
$header .= "$text\n";

$header .= "--$uid\n";
$header .= "Content-Type: $type; name=\"$name\"\n";

$header .= "Content-Transfer-Encoding: base64\n";
$header .= "Content-Disposition: attachment; filename=\"$name\"\n\n";
$header .= "$content\n";

$header .= "--$uid--";

mail($to, $subject, "", $header);

return true;

}

sendmsg($to, "Contacto desde FlirtMonopol", $msg, "FlirtMonopol", $filename, $filename_type, $filename_name);

so now can you tell me , how to do it with the global variables?

diego25

What global variables are you talking about?

Diego

rul

like this $HTTP_POST_FILES

diego25

It'd be

sendmsg($to, "Contacto desde FlirtMonopol", $msg, "FlirtMonopol", $HTTP_POST_FILES['filename']['tmp_name'], $HTTP_POST_FILES['filename']['type'], $HTTP_POST_FILES['filename']['name']);

Diego

Weedpacket

Then the variables named $HTTP_POST_FILES[...] can be dropped from the call to sendmsg(), $file, $type, and $name. dropped from the list of variables in the function declaration, the line
global $HTTP_POST_FILES[]
inserted at the start of the function, then use $HTTP_POST_FILES[...] instead of $file, $type and $name throughout the function (or three extra lines going $file=$HTTP_POST_FILES['filename']['tmp_name'], etc.).

Then, if this is running on PHP4.1 or later, the line
global $HTTP_POST_FILES;
can be dropped, and $HTTP_POST_FILES replaced with $_FILES throughout the function.