insert not working!

scbmx

i have no idea why this insert isnt inserting. i think its a problem with the $user varible for the table that its going to insert into, however i have user that on other scripts before and it worked fine. do you see anything wrong?

	<?php
if (($REQUEST_METHOD=='POST')) {
if($user == NULL){ echo "USERNAME NOT SPECIFIED!!!"; }else{
$ip = "$REMOTE_ADDR";
$query = "INSERT INTO ".$user." (`guest_id`, `name`, `email`, `www`, `time`, `ip`, `message`) VALUES ('0000', '$name', '$email', '$www', '$time', '$ip', '$message'); ";
mysql_pconnect("localhost","mine","mine") or die("Unable to connect to SQL server");
mysql_select_db("guestbooks") or die("Unable to select database");
mysql_query($query) or die("Insert Failed!");
print("<center>Message added...</center>");
}
}
?>

bastien

what ever the value of $user is?

scbmx

yes

hand

<?php
if (($REQUEST_METHOD=='POST')) {
   if($user == NULL){
      echo "USERNAME NOT SPECIFIED!!!";
   } else {
      $ip = "$REMOTE_ADDR";
      $query = "INSERT INTO $user (guest_id, name, email, www, time, ip, message)
               VALUES ('0000', '$name', '$email', '$www', '$time', '$ip', '$message')";

  mysql_pconnect("localhost","mine","mine") or die("Unable to connect to SQL server");
  mysql_select_db("guestbooks") or die("Unable to select database");

  mysql_query($query)
     or print "&gt;&gt;&gt; MySQL-Error: ".mysql_errno()." -&gt; ".mysql_error()."<br>\n";

  print("<center>Message added...</center>");
   }
}
?>

Please post MySQL-Error message now.

philipolson

First, your script does require the php directive register_globals to be on.

Second, the example in the last post will always print "Message added" regardless of an error in the query but at least it'll print the error too. I think s/he meant to use die() or exit() instead of print().

Third, why don't you simply print out your query and make sure it looks right. print $query;

Fourth, use mysql_connect not mysql_pconnect. You have no reason for persistant connections here.

Fifth, mysql_error() is your friend.

ahundiak

philipolson,
What is your objection to the use of mysql_pconnect()?

Functionally, they are identical. But since persistant connections stay around then it would seem that the next script will get connected to the database server a bit faster.

As long as you are not using any of that table locking nonsense.

Weedpacket

Originally posted by ahundiak
philipolson,
What is your objection to the use of mysql_pconnect()?

Functionally, they are identical. But since persistant connections stay around then it would seem that the next script will get connected to the database server a bit faster.

As long as you are not using any of that table locking nonsense.

Here is a comparison of the effects of pconnect vs. connect. The question you have to answer: do the pros outweigh the cons in your particular case? Answering that would probably involve you stress-testing your site to some extent.

hand

What do you think? Did the member of connecticut solve the problem?

ahundiak

The link has some good stuff in it.

So let me rephrase the question:
Is there anything in the snippet of sql code presented that makes you say "aha, only use mysql_connect() here"?

scbmx

First --- wow, thanks for all the responses. I found my mistake, by accident i put a semicolin ";" within the insert query at the end.

Second --- philipolsen, it will not always print "message added" unless the query is successful, because if the query fails, it will "die" with the message specified, and none of the content after that on the page will be loaded. thats probably why its called "die" hehe.

Thrid --- I used mysql_pconnect because after the insert query, it also selects from two more tables in the same database. it just seems easiar to me to type less code.

Thanks.

philipolson

By last post I meant hand's post, not yours.

And that's not what a persistent connection means, read the link posted in this thread. mysql_connect will work fine, set one connection per script..

http://www.php.net/mysql_connect

And regarding persistent connections, I am no expert on this subject but feel too many people blindly use them thinking they're faster. Although, I had no idea scbmx's assumption on the meaning was what it was.

And btw, parse errors are ALWAYS syntax errors.

hand

@
It's not neccessary to criticize "my" code. scbmx had the problem, not somebody else. Everybody can see, that I structured his code and I primary added another or statement to display mysql_errno() and mysql_error(), to help him locating his problem.

philipolson

hand, don't take it so personally. I simply told him what it'd do just in case he got confused. Fact remains it would print 'message added' even when it wouldn't be, if you feel telling someone that isn't useful then that's not my problem. Sorry, nothing personal, a fact is a fact. I even said I thought it was a typo to use die, which is a very common use.