Confused with user defined functions code with register globals = off

erick_w

I used to write my codes with register globals = on, now I have to move my script to a different maschine with register globals = off. Anyone can tell me what I should change from my function below?

I mean, I have 2 global variables here i.e : $USR_TBL and $ERR_NO_USERNAME which I declared in a different file. I can have the $username value from $_POST['username'], but how about the other 2?

function check_user($username)
{
global $USR_TBL,$ERR_NO_USERNAME;

    $conn=db_connect();
    $result=mysql_query("SELECT * FROM $USR_TBL WHERE username='$username'");
  $row=mysql_fetch_array($result);

  if($result){
     return $row[username];
  }else{
      notify_user("$ERR_NO_USERNAME","error");
  }

}

128kb_com

You can use the $GLOBALS['global_var'] to access global variables but the way your importing them into your functions local scope looks fine to me being that your declared them global when they were created in your external script that you must of include()'d or something.

I did however notice that you a bare word (next to username) in the line:

return $row[username];

erick_w

Thanks 128kb.com, 🙂

So, should I change my code like this?

function check_user($username) 
{ 
$USR_TBL = $GLOBALS['USR_TBL'];
$ERR_NO_USERNAME = $GLOBALS['ERR_NO_USERNAME']; 

$conn=db_connect(); 
$result=mysql_query("SELECT * FROM $USR_TBL WHERE username='$username'"); 
$row=mysql_fetch_array($result); 

if($result){ 
return $row[username]; 
}else{ 
notify_user("$ERR_NO_USERNAME","error"); 
} 
}

The line :
return $row[username];

is returning the value of a username from the the table, and it is local... I'll try this script first 😉

128kb_com

What I said was that I thought your code looked fine to begin with EXCEPT the line:
return_$row[username];

which should be:
return$row['username'];
// or
return$row[$username];

you have a bare word in there and unless username was defined as a constant then your syntax is wrong.

erick_w

Now how can I register a session, since if register globals off, I must use $_SESSION['session_vars'], NOT session_register();. Can you give me an example how to do that?

128kb_com

Now how can I register a session, since if register globals off, I must use $_SESSION['session_vars'], NOT session_register();

I think your confused 😕

You can use a session reguardless of what your register_globals is set to and...

Yes you would use $_SESSION['session_vars'] to access a session variable but you have to call session_start() and session_register("session_vars") before you can access it.

check out these examples:
http://www.php.net/manual/en/ref.session.php

filch

Ummm .. sorry but I thought you did not have to call session_register() if you initialized your SESSION var with $_SESSION('var');

PHP manual states:

Note: Please note when working with sessions that a record of a session is not created until a variable has been registered using the session_register() function or by adding a new key to the $_SESSION superglobal array. This holds true regardless of if a session has been started using the session_start() function.

Am I missing something here?

Dave

128kb_com

Who are you... the PHP police?

Yes, your right you dont actually need to call session_register(), you can just add to the superglobal $_SESSION like a regular array, but the correct syntax is:

$_SESSION['var'] = "value";

not

$_SESSION('var');

filch

Good God no ... hardly the PHP Police ;-). I am simply trying to learn a lot fast and it was more of a question than a statement, although I was fairly certain I was right. I just wanted to make sure I wasn't confused ....... again!!! It is not often I have been right during this learning process so it feels kind of good.

Cheers

Dave