Anything wrong with this?...

evo4ever

Can anyone see any problems with this db query:

display.php echo'ing a member's profile:

<?php
  $dbhost = "";
  $dbuser = "";
  $dbpassword = "";
  $db = "";

@mysql_connect($dbhost, $dbuser, $dbpassword) or DIE("Couldn't Connect to MySQL Database");
@mysql_select_db($db) or DIE("Couldn't Select Database");

$query = mysql_query("SELECT * FROM cph_menu");
$query2 = mysql_query("SELECT * FROM cph_members");
?>

returning a row:

elseif($_GET["mid"] == "zenith" && ($_GET["opt"] == "prof")){

if ($a_row = mysql_fetch_array($query2));
echo '<font face="Tahoma" size="2"> ' . $a_row["aboutme"] . '</font>';

}

Im asking you coz it aint working for some reason.

diego25

Well, what's not working exactly?

Something that caught my eye:

if ($a_row = mysql_fetch_array($query2));

Did you actually mean to put the semicolon there? It's syntactically legal in PHP, but, IMO, if used, could lead to mistakes later on. If I wanted an empty statement, I'd just open and close curly brackets right away, e.g.

if (something) {}
instead of
if (something);

Diego

evo4ever

The member's profile isnt getting echo'ed back. I tried removing the semicolon but it didnt work. Any other suggestions?

[edit]But the weird thing is... im not getting any parse errors! so theoretically it should be working!?[/edit]

tomhath

Are you sure you ever got to the fetch? I'd put a couple of more echo's to see if you pass the if:

elseif($_GET["mid"] == "zenith" && ($_GET["opt"] == "prof")){

Cong

Did you meant to say:

if ($a_row = mysql_fetch_array($query2)) {
   echo '<font face="Tahoma" size="2"> ' . $a_row["aboutme"] . '</font>';
}

It's just seem strange to use

if ($a_row = mysql_fetch_array($query2));

. When

$a_row = mysql_fetch_array($query2);

will accomplish pretty much the same thing. Not to mention you won't get the scope of $a_row if your statement isn't true.

evo4ever

Ok. new script:

} elseif($_GET["mid"] == "zenith" && ($_GET["opt"] == "prof")){

$a_row = mysql_fetch_array($query2);
echo "<font face=\"Tahoma\" size=\"2\"> " . $a_row["aboutme"] . "</font>";

}

... still aint working!!! but I don't understand why!

tomhath

Not to mention you won't get the scope of $a_row if your statement isn't true.

if ($a_row = mysql_fetch_array($query2));

$a_row will be set to false if there was no row returned, so the boolean expression of the "if" will evaluate to false. Nothing strange about that, nor are there any scope issues.

Cong

Try

echo "show me the money<br>";

before

$a_row = mysql_fetch_array($query2);

just to see if you'll get into that elseif block.

evo4ever

lol. I knew id make a stupid mistake! in which case I did! I forgot to put a WHERE clause in my db query! I forgot I had more than one entry in the members table lol. It's fixed now. Thx for your help anyway!